| Message ID | 20211105015504.39226-1-vulab@iscas.ac.cn (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() | expand |
On Fri, Nov 5, 2021 at 3:02 AM Xu Wang <vulab@iscas.ac.cn> wrote: > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be> Gr{oetje,eeting}s, Geert -- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
Hi Xu, Thank you for the patch. > -----Original Message----- > From: Xu Wang <vulab@iscas.ac.cn> > Sent: 05 November 2021 01:55 > To: Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>; jic23@kernel.org; lars@metafoo.de > Cc: linux-iio@vger.kernel.org; linux-renesas-soc@vger.kernel.org; linux-kernel@vger.kernel.org > Subject: [PATCH] iio: adc: rzg2l_adc: Remove unnecessary print function dev_err() > > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> > --- > drivers/iio/adc/rzg2l_adc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> Cheers, Prabhakar > diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index > 32fbf57c362f..9d5be52bd948 100644 > --- a/drivers/iio/adc/rzg2l_adc.c > +++ b/drivers/iio/adc/rzg2l_adc.c > @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(dev, irq, rzg2l_adc_isr, > 0, dev_name(dev), adc); > -- > 2.25.1
On Fri, 5 Nov 2021 01:55:04 +0000 Xu Wang <vulab@iscas.ac.cn> wrote: > The print function dev_err() is redundant because > platform_get_irq() already prints an error. > > Signed-off-by: Xu Wang <vulab@iscas.ac.cn> Applied, thanks Jonathan > --- > drivers/iio/adc/rzg2l_adc.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c > index 32fbf57c362f..9d5be52bd948 100644 > --- a/drivers/iio/adc/rzg2l_adc.c > +++ b/drivers/iio/adc/rzg2l_adc.c > @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev) > } > > irq = platform_get_irq(pdev, 0); > - if (irq < 0) { > - dev_err(dev, "no irq resource\n"); > + if (irq < 0) > return irq; > - } > > ret = devm_request_irq(dev, irq, rzg2l_adc_isr, > 0, dev_name(dev), adc);
diff --git a/drivers/iio/adc/rzg2l_adc.c b/drivers/iio/adc/rzg2l_adc.c index 32fbf57c362f..9d5be52bd948 100644 --- a/drivers/iio/adc/rzg2l_adc.c +++ b/drivers/iio/adc/rzg2l_adc.c @@ -506,10 +506,8 @@ static int rzg2l_adc_probe(struct platform_device *pdev) } irq = platform_get_irq(pdev, 0); - if (irq < 0) { - dev_err(dev, "no irq resource\n"); + if (irq < 0) return irq; - } ret = devm_request_irq(dev, irq, rzg2l_adc_isr, 0, dev_name(dev), adc);
The print function dev_err() is redundant because platform_get_irq() already prints an error. Signed-off-by: Xu Wang <vulab@iscas.ac.cn> --- drivers/iio/adc/rzg2l_adc.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)