| Message ID | 20211214165608.7903-3-nuno.sa@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | Add support for LTC2688 | expand |
On Tue, 14 Dec 2021 17:56:07 +0100 Nuno Sá <nuno.sa@analog.com> wrote: > Define the sysfs interface for toggle or dither capable channels. Dither > capable channels will have the extended interface: > > * out_voltageY_dither_en > * out_voltageY_dither_raw > * out_voltageY_dither_raw_available > * out_voltageY_dither_frequency > * out_voltageY_dither_frequency_available > * out_voltageY_dither_phase > * out_voltageY_dither_phase_available > > Toggle enabled channels will have: > > * out_voltageY_toggle_en > * out_voltageY_raw1 > * out_voltageY_symbol > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> > --- > +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1 I was thinking more raw0 and raw1 rather than not having the 0 for the first one. If someone has the device in a circuit where they want to use the toggle mode then I'd assume they know about the special ABI and can cope with this. > +KernelVersion: 5.16 > +Contact: linux-iio@vger.kernel.org > +Description: > + It has the same meaning as out_voltageY_raw. This attribute is > + specific to toggle enabled channels and refers to the DAC output > + code in the INPUT_B register while regular out_voltageY_raw > + refers to INPUT_A. The same scale, offset, etc applies.
> -----Original Message----- > From: Jonathan Cameron <jic23@jic23.retrosnub.co.uk> > Sent: Thursday, December 16, 2021 2:35 PM > To: Sa, Nuno <Nuno.Sa@analog.com> > Cc: linux-iio@vger.kernel.org; devicetree@vger.kernel.org; Rob > Herring <robh+dt@kernel.org>; Lars-Peter Clausen > <lars@metafoo.de>; Hennerich, Michael > <Michael.Hennerich@analog.com> > Subject: Re: [PATCH 2/3] iio: ABI: add ABI file for the LTC2688 DAC > > [External] > > On Tue, 14 Dec 2021 17:56:07 +0100 > Nuno Sá <nuno.sa@analog.com> wrote: > > > Define the sysfs interface for toggle or dither capable channels. > Dither > > capable channels will have the extended interface: > > > > * out_voltageY_dither_en > > * out_voltageY_dither_raw > > * out_voltageY_dither_raw_available > > * out_voltageY_dither_frequency > > * out_voltageY_dither_frequency_available > > * out_voltageY_dither_phase > > * out_voltageY_dither_phase_available > > > > Toggle enabled channels will have: > > > > * out_voltageY_toggle_en > > * out_voltageY_raw1 > > * out_voltageY_symbol > > > > Signed-off-by: Nuno Sá <nuno.sa@analog.com> > > --- > > > +What: > /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1 > > I was thinking more raw0 and raw1 rather than not having the 0 for the > first one. If someone has the device in a circuit where they want to > use > the toggle mode then I'd assume they know about the special ABI and > can > cope with this. > Hmm I see. That means more probe time handling but well, we are doing a lot anyways that a bit more won't hurt :). - Nuno Sá
diff --git a/Documentation/ABI/testing/sysfs-bus-iio-dac-ltc2688 b/Documentation/ABI/testing/sysfs-bus-iio-dac-ltc2688 new file mode 100644 index 000000000000..0c45de94dd75 --- /dev/null +++ b/Documentation/ABI/testing/sysfs-bus-iio-dac-ltc2688 @@ -0,0 +1,67 @@ +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_en +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Dither enable. Write 1 to enable dither or 0 to disable it. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_raw +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + This raw, unscaled value refers to the dither signal amplitude. + The same scale as in out_voltageY_raw applies. However, the + offset might be different as it's always 0 for this attribute. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_raw_available +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Available range for dither raw amplitude values. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_frequency +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Sets the dither signal frequency. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_frequency_available +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Returns the available values for the dither frequency. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_phase +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Sets the dither signal phase. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_dither_phase_available +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Returns the available values for the dither phase. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_toggle_en +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Toggle enable. Write 1 to enable toggle or 0 to disable it. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_raw1 +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + It has the same meaning as out_voltageY_raw. This attribute is + specific to toggle enabled channels and refers to the DAC output + code in the INPUT_B register while regular out_voltageY_raw + refers to INPUT_A. The same scale, offset, etc applies. + +What: /sys/bus/iio/devices/iio:deviceX/out_voltageY_symbol +KernelVersion: 5.16 +Contact: linux-iio@vger.kernel.org +Description: + Performs a SW toggle. This attribute is specific to toggle + enabled channels and allows to toggle between out_voltageY_raw + and out_voltageY_raw1 through software. Writing 0 will select + out_voltageY_raw while 1 selects out_voltageY_raw1. diff --git a/MAINTAINERS b/MAINTAINERS index 90960e3d778f..61b1eaad4611 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -11167,6 +11167,7 @@ M: Nuno Sá <nuno.sa@analog.com> L: linux-iio@vger.kernel.org S: Supported W: http://ez.analog.com/community/linux-device-drivers +F: Documentation/ABI/testing/sysfs-bus-iio-dac-ltc2688 F: drivers/iio/dac/ltc2688.c LTC2947 HARDWARE MONITOR DRIVER
Define the sysfs interface for toggle or dither capable channels. Dither capable channels will have the extended interface: * out_voltageY_dither_en * out_voltageY_dither_raw * out_voltageY_dither_raw_available * out_voltageY_dither_frequency * out_voltageY_dither_frequency_available * out_voltageY_dither_phase * out_voltageY_dither_phase_available Toggle enabled channels will have: * out_voltageY_toggle_en * out_voltageY_raw1 * out_voltageY_symbol Signed-off-by: Nuno Sá <nuno.sa@analog.com> --- .../ABI/testing/sysfs-bus-iio-dac-ltc2688 | 67 +++++++++++++++++++ MAINTAINERS | 1 + 2 files changed, 68 insertions(+) create mode 100644 Documentation/ABI/testing/sysfs-bus-iio-dac-ltc2688