| Message ID | 20220316142313.92371-5-caleb.connolly@linaro.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: introduce Qualcomm SPMI Round Robin ADC | expand |
On 16/03/2022 15:23, Caleb Connolly wrote: > Add dt-binding docs for the Qualcomm SPMI RRADC found in PMICs like > PMI8998 and PMI8994 > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > Reviewed-by: Rob Herring <robh@kernel.org> > --- > .../bindings/iio/adc/qcom,spmi-rradc.yaml | 54 +++++++++++++++++++ > 1 file changed, 54 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > > diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > new file mode 100644 > index 000000000000..11d47c46a48d > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml > @@ -0,0 +1,54 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-rradc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm's SPMI PMIC Round Robin ADC > + > +maintainers: > + - Caleb Connolly <caleb.connolly@linaro.org> > + > +description: | > + The Qualcomm SPMI Round Robin ADC (RRADC) provides interface to clients to read the > + voltage, current and temperature for supported peripherals such as the battery thermistor > + die temperature, charger temperature, USB and DC input voltage / current and battery ID > + resistor. Please wrap at 80. It's still in the coding style and there is no readability increase by using 100. Same goes to other descriptions here. > + > +properties: > + compatible: > + enum: > + - qcom,pmi8998-rradc > + - qcom,pm660-rradc > + > + reg: > + description: rradc base address and length in the SPMI PMIC register map Obvious description, remove it. Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml new file mode 100644 index 000000000000..11d47c46a48d --- /dev/null +++ b/Documentation/devicetree/bindings/iio/adc/qcom,spmi-rradc.yaml @@ -0,0 +1,54 @@ +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/adc/qcom,spmi-rradc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Qualcomm's SPMI PMIC Round Robin ADC + +maintainers: + - Caleb Connolly <caleb.connolly@linaro.org> + +description: | + The Qualcomm SPMI Round Robin ADC (RRADC) provides interface to clients to read the + voltage, current and temperature for supported peripherals such as the battery thermistor + die temperature, charger temperature, USB and DC input voltage / current and battery ID + resistor. + +properties: + compatible: + enum: + - qcom,pmi8998-rradc + - qcom,pm660-rradc + + reg: + description: rradc base address and length in the SPMI PMIC register map + maxItems: 1 + + qcom,batt-id-delay-ms: + description: + Sets the hardware settling time for the battery ID resistor. + enum: [0, 1, 4, 12, 20, 40, 60, 80] + + "#io-channel-cells": + const: 1 + +required: + - compatible + - reg + +additionalProperties: false + +examples: + - | + pmic { + #address-cells = <1>; + #size-cells = <0>; + + pmic_rradc: adc@4500 { + compatible = "qcom,pmi8998-rradc"; + reg = <0x4500>; + #io-channel-cells = <1>; + }; + }; +...