| Message ID | 20220318162722.51215-3-alexandru.tachici@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: ad_sigma_delta: Add sequencer support | expand |
On Fri, 18 Mar 2022 18:27:16 +0200 <alexandru.tachici@analog.com> wrote: > From: Alexandru Tachici <alexandru.tachici@analog.com> > > The callback .set_channel cannot be used to enable > and disable multiple channels at once as they are > presented in the active_scan_mask. Trivial: Aim to wrap commit messages around 70ish chars and whatever you pick be consistent. Patch looks fine to me otherwise so if nothing else comes up, I may rewrap these patch descriptions whilst applying. Jonathan > > By adding an update_scan_mode callback, every time the > continuous mode is activated, channels will be enabled/disabled > accordingly. > > Signed-off-by: Alexandru Tachici <alexandru.tachici@analog.com> > --- > drivers/iio/adc/ad7124.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c > index 7249db2c4422..428ec3e257d7 100644 > --- a/drivers/iio/adc/ad7124.c > +++ b/drivers/iio/adc/ad7124.c > @@ -669,11 +669,32 @@ static const struct attribute_group ad7124_attrs_group = { > .attrs = ad7124_attributes, > }; > > +static int ad7124_update_scan_mode(struct iio_dev *indio_dev, > + const unsigned long *scan_mask) > +{ > + struct ad7124_state *st = iio_priv(indio_dev); > + bool bit_set; > + int ret; > + int i; > + > + for (i = 0; i < st->num_channels; i++) { > + bit_set = test_bit(i, scan_mask); > + ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i), > + AD7124_CHANNEL_EN_MSK, > + AD7124_CHANNEL_EN(bit_set), > + 2); > + if (ret < 0) > + return ret; > + } > + return 0; > +} > + > static const struct iio_info ad7124_info = { > .read_raw = ad7124_read_raw, > .write_raw = ad7124_write_raw, > .debugfs_reg_access = &ad7124_reg_access, > .validate_trigger = ad_sd_validate_trigger, > + .update_scan_mode = ad7124_update_scan_mode, > .attrs = &ad7124_attrs_group, > }; >
diff --git a/drivers/iio/adc/ad7124.c b/drivers/iio/adc/ad7124.c index 7249db2c4422..428ec3e257d7 100644 --- a/drivers/iio/adc/ad7124.c +++ b/drivers/iio/adc/ad7124.c @@ -669,11 +669,32 @@ static const struct attribute_group ad7124_attrs_group = { .attrs = ad7124_attributes, }; +static int ad7124_update_scan_mode(struct iio_dev *indio_dev, + const unsigned long *scan_mask) +{ + struct ad7124_state *st = iio_priv(indio_dev); + bool bit_set; + int ret; + int i; + + for (i = 0; i < st->num_channels; i++) { + bit_set = test_bit(i, scan_mask); + ret = ad7124_spi_write_mask(st, AD7124_CHANNEL(i), + AD7124_CHANNEL_EN_MSK, + AD7124_CHANNEL_EN(bit_set), + 2); + if (ret < 0) + return ret; + } + return 0; +} + static const struct iio_info ad7124_info = { .read_raw = ad7124_read_raw, .write_raw = ad7124_write_raw, .debugfs_reg_access = &ad7124_reg_access, .validate_trigger = ad_sd_validate_trigger, + .update_scan_mode = ad7124_update_scan_mode, .attrs = &ad7124_attrs_group, };