| Message ID | 20220323162820.110806-4-caleb@connolly.tech (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: adc: introduce Qualcomm SPMI Round Robin ADC | expand |
On Wed, 23 Mar 2022, Caleb Connolly wrote: > From: Caleb Connolly <caleb.connolly@linaro.org> > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > the RRADC to calibrate ADC values. > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > --- > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > include/soc/qcom/qcom-spmi-pmic.h | 1 + > 2 files changed, 8 insertions(+) Please change the Subject line to match the style of the sub-system? Once changed: Acked-by: Lee Jones <lee.jones@linaro.org>
On 25/04/2022 16:05, Lee Jones wrote: > On Wed, 23 Mar 2022, Caleb Connolly wrote: > >> From: Caleb Connolly <caleb.connolly@linaro.org> >> >> The PMI8998 and PM660 expose the fab_id, this is needed by drivers like >> the RRADC to calibrate ADC values. >> >> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> >> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >> --- >> drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ >> include/soc/qcom/qcom-spmi-pmic.h | 1 + >> 2 files changed, 8 insertions(+) > > Please change the Subject line to match the style of the sub-system? Hi, sorry if this is a silly question, I don't quite understand what you want me to change here, the subject line is in the same "mfd: driver:" format as other patches in the subsystem? > > Once changed: > > Acked-by: Lee Jones <lee.jones@linaro.org> >
On Tue, 26 Apr 2022, Caleb Connolly wrote: > On 25/04/2022 16:05, Lee Jones wrote: > > On Wed, 23 Mar 2022, Caleb Connolly wrote: > > > > > From: Caleb Connolly <caleb.connolly@linaro.org> > > > > > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > > > the RRADC to calibrate ADC values. > > > > > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > --- > > > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > > > include/soc/qcom/qcom-spmi-pmic.h | 1 + > > > 2 files changed, 8 insertions(+) > > > > Please change the Subject line to match the style of the sub-system? > Hi, sorry if this is a silly question, I don't quite understand what you > want me to change here, the subject line is in the same "mfd: driver:" > format as other patches in the subsystem? mfd: qcom-spmi-pmic: Read fab ID on supported PMICs What's 'fab' should that be capitalised too? > > Once changed: > > > > Acked-by: Lee Jones <lee.jones@linaro.org> > > >
On 26/04/2022 19:24, Lee Jones wrote: > On Tue, 26 Apr 2022, Caleb Connolly wrote: >> On 25/04/2022 16:05, Lee Jones wrote: >>> On Wed, 23 Mar 2022, Caleb Connolly wrote: >>> >>>> From: Caleb Connolly <caleb.connolly@linaro.org> >>>> >>>> The PMI8998 and PM660 expose the fab_id, this is needed by drivers like >>>> the RRADC to calibrate ADC values. >>>> >>>> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> >>>> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> >>>> --- >>>> drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ >>>> include/soc/qcom/qcom-spmi-pmic.h | 1 + >>>> 2 files changed, 8 insertions(+) >>> >>> Please change the Subject line to match the style of the sub-system? >> Hi, sorry if this is a silly question, I don't quite understand what you >> want me to change here, the subject line is in the same "mfd: driver:" >> format as other patches in the subsystem? > > mfd: qcom-spmi-pmic: Read fab ID on supported PMICs > > What's 'fab' should that be capitalised too? "fab" is short for fabrication I think, the register value can be used to determine which factory the chip was manufactured in. I can make it clearer and go for mfd: qcom-spmi-pmic: Read fabrication ID on supported PMICs > >>> Once changed: >>> >>> Acked-by: Lee Jones <lee.jones@linaro.org> >>> >> >
On Wed, 27 Apr 2022, Caleb Connolly wrote: > > > On 26/04/2022 19:24, Lee Jones wrote: > > On Tue, 26 Apr 2022, Caleb Connolly wrote: > > > On 25/04/2022 16:05, Lee Jones wrote: > > > > On Wed, 23 Mar 2022, Caleb Connolly wrote: > > > > > > > > > From: Caleb Connolly <caleb.connolly@linaro.org> > > > > > > > > > > The PMI8998 and PM660 expose the fab_id, this is needed by drivers like > > > > > the RRADC to calibrate ADC values. > > > > > > > > > > Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org> > > > > > Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > Tested-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org> > > > > > --- > > > > > drivers/mfd/qcom-spmi-pmic.c | 7 +++++++ > > > > > include/soc/qcom/qcom-spmi-pmic.h | 1 + > > > > > 2 files changed, 8 insertions(+) > > > > > > > > Please change the Subject line to match the style of the sub-system? > > > Hi, sorry if this is a silly question, I don't quite understand what you > > > want me to change here, the subject line is in the same "mfd: driver:" > > > format as other patches in the subsystem? > > > > mfd: qcom-spmi-pmic: Read fab ID on supported PMICs > > > > What's 'fab' should that be capitalised too? > "fab" is short for fabrication I think, the register value can be used to > determine which factory the chip was manufactured in. > > I can make it clearer and go for > > mfd: qcom-spmi-pmic: Read fabrication ID on supported PMICs Clearer, thanks.
diff --git a/drivers/mfd/qcom-spmi-pmic.c b/drivers/mfd/qcom-spmi-pmic.c index d8e54d9d3448..43e0c55696c7 100644 --- a/drivers/mfd/qcom-spmi-pmic.c +++ b/drivers/mfd/qcom-spmi-pmic.c @@ -19,6 +19,7 @@ #define PMIC_REV4 0x103 #define PMIC_TYPE 0x104 #define PMIC_SUBTYPE 0x105 +#define PMIC_FAB_ID 0x1f2 #define PMIC_TYPE_VALUE 0x51 @@ -168,6 +169,12 @@ static int pmic_spmi_load_revid(struct regmap *map, struct device *dev, if (ret < 0) return ret; + if (pmic->subtype == PMI8998_SUBTYPE || pmic->subtype == PM660_SUBTYPE) { + ret = regmap_read(map, PMIC_FAB_ID, &pmic->fab_id); + if (ret < 0) + return ret; + } + /* * In early versions of PM8941 and PM8226, the major revision number * started incrementing from 0 (eg 0 = v1.0, 1 = v2.0). diff --git a/include/soc/qcom/qcom-spmi-pmic.h b/include/soc/qcom/qcom-spmi-pmic.h index 5400e6509fe8..ff839b230e62 100644 --- a/include/soc/qcom/qcom-spmi-pmic.h +++ b/include/soc/qcom/qcom-spmi-pmic.h @@ -50,6 +50,7 @@ struct qcom_spmi_pmic { unsigned int major; unsigned int minor; unsigned int rev2; + unsigned int fab_id; const char *name; };