From patchwork Tue May 3 08:59:00 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 12835356 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 64488C433F5 for ; Tue, 3 May 2022 09:00:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233131AbiECJEV (ORCPT ); Tue, 3 May 2022 05:04:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233148AbiECJES (ORCPT ); Tue, 3 May 2022 05:04:18 -0400 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CBC8A1C912 for ; Tue, 3 May 2022 02:00:46 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 7111AB81BE1 for ; Tue, 3 May 2022 09:00:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 346FEC385B0; Tue, 3 May 2022 09:00:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651568444; bh=pzVBy2LFFe1hhjptCXaKXdwxdHcXshmyyEK/8jYSAdE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=O8eP/FGJHWnWnDbMCQXS6XZY2n/Eqe0/Y4UrJV/givjeWAIrpDURBBUOkLyJYoFtC UtRCFfK/hB3xIxExeF3n5FDbOJ0M+OMo11b6WsxmYG0qmceVi24Wo3ihJP/MgI3uyo vXSknjc6RFSTTpQ/upjHGPu4s9zbihul2OUHI2tdsx/4PYstPi8jg7M+eD+RjfLenu sVa5D714WSBOVN5wUBKA8guQlOh5BwO4IIBtFYw2qknx+9TOnHtgsCsR9sSkCF4Ywj HOgN8c1yvOzXqYCXgw2lB0PNKD/PvO/EpstxWckqJY2C4omCYeC2xc45CfsJJdr+gv zzXHRDFXVbs1g== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: Akinobu Mita , Alexandru Lazar , Alexandru Tachici , Antoniu Miclaus , Charles-Antoine Couret , Cosmin Tanislav , Cristian Pop , David Lechner , Ivan Mikhaylov , Jacopo Mondi , Jean-Baptiste Maneyrol , Lars-Peter Clausen , Marcelo Schmitt , =?utf-8?q?M=C3=A5rten_Lindahl?= , Matt Ranostay , Michael Hennerich , Michael Welling , Mugilraj Dhavachelvan , Navin Sankar Velliangiri , =?utf-8?q?Nuno_S=C3=A1?= , Paul Cercueil , Phil Reid , Puranjay Mohan , Ricardo Ribalda , Robert Jones , Rui Miguel Silva , Sean Nyekjaer , Tomas Melin , Tomislav Denis , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Jonathan Cameron Subject: [PATCH 57/92] iio: dac: ad7303: Fix alignment for DMA safety Date: Tue, 3 May 2022 09:59:00 +0100 Message-Id: <20220503085935.1533814-58-jic23@kernel.org> X-Mailer: git-send-email 2.36.0 In-Reply-To: <20220503085935.1533814-1-jic23@kernel.org> References: <20220503085935.1533814-1-jic23@kernel.org> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org From: Jonathan Cameron ____cacheline_aligned is an insufficient guarantee for non-coherent DMA on platforms with 128 byte cachelines above L1. Switch to the updated IIO_ALIGN definition. Update the comment to include 'may'. Fixes: f83478240e74 ("iio:dac: Add support for the AD7303") Signed-off-by: Jonathan Cameron --- drivers/iio/dac/ad7303.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/iio/dac/ad7303.c b/drivers/iio/dac/ad7303.c index 91eaaf793b3e..2a439ea9d1c7 100644 --- a/drivers/iio/dac/ad7303.c +++ b/drivers/iio/dac/ad7303.c @@ -44,10 +44,10 @@ struct ad7303_state { struct mutex lock; /* - * DMA (thus cache coherency maintenance) requires the + * DMA (thus cache coherency maintenance) may require the * transfer buffers to live in their own cache lines. */ - __be16 data ____cacheline_aligned; + __be16 data __aligned(IIO_ALIGN); }; static int ad7303_write(struct ad7303_state *st, unsigned int chan,