diff mbox series

[V5,6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l bindings

Message ID 20220526133359.2261928-7-Qing-wu.Li@leica-geosystems.com.cn (mailing list archive)
State Accepted
Headers show
Series iio: accel: bmi088: support BMI085 BMI090L | expand

Commit Message

LI Qingwu May 26, 2022, 1:33 p.m. UTC 
Adds the device-tree bindings for the Bosch
BMI085 and BMI090L IMU, the accelerometer part.

Datasheet: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi085-ds001.pdf
Datasheet: https://media.digikey.com/pdf/Data%20Sheets/Bosch/BST-BMI090L-DS000-00.pdf
Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
---
 Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
 1 file changed, 2 insertions(+)

Comments

Rob Herring June 2, 2022, 1:57 p.m. UTC | #1 
On Thu, May 26, 2022 at 01:33:59PM +0000, LI Qingwu wrote:
> Adds the device-tree bindings for the Bosch
> BMI085 and BMI090L IMU, the accelerometer part.
> 
> Datasheet: https://www.bosch-sensortec.com/media/boschsensortec/downloads/datasheets/bst-bmi085-ds001.pdf
> Datasheet: https://media.digikey.com/pdf/Data%20Sheets/Bosch/BST-BMI090L-DS000-00.pdf

blank line here. These aren't part of the tags.

With that,

Acked-by: Rob Herring <robh@kernel.org>

> Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> ---
>  Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> index 911a1ae9c83f..272eb48eef5a 100644
> --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> @@ -17,7 +17,9 @@ description: |
>  properties:
>    compatible:
>      enum:
> +      - bosch,bmi085-accel
>        - bosch,bmi088-accel
> +      - bosch,bmi090l-accel
>  
>    reg:
>      maxItems: 1
> -- 
> 2.25.1
> 
>
LI Qingwu June 3, 2022, 7:32 a.m. UTC | #2 
> -----Original Message-----
> From: Rob Herring <robh@kernel.org>
> Sent: Thursday, June 2, 2022 9:58 PM
> To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> Cc: jic23@kernel.org; lars@metafoo.de; mchehab+huawei@kernel.org;
> ardeleanalex@gmail.com; linux-iio@vger.kernel.org;
> linux-kernel@vger.kernel.org; mike.looijmans@topic.nl;
> devicetree@vger.kernel.org; HAEMMERLE Thomas
> <thomas.haemmerle@leica-geosystems.com>
> Subject: Re: [PATCH V5 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l
> bindings
> 
> This email is not from Hexagon's Office 365 instance. Please be careful while
> clicking links, opening attachments, or replying to this email.
> 
> 
> On Thu, May 26, 2022 at 01:33:59PM +0000, LI Qingwu wrote:
> > Adds the device-tree bindings for the Bosch
> > BMI085 and BMI090L IMU, the accelerometer part.
> >
> > Datasheet:
> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.bos
> ch-sensortec.com%2Fmedia%2Fboschsensortec%2Fdownloads%2Fdatasheets%
> 2Fbst-bmi085-ds001.pdf&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c4
> 08da449fd9bf%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C6378977
> 51065729986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdat
> a=K3PYyQAGsySCIjKuo1QRVm1HE0cuC3BVXbjuAwwhMjM%3D&amp;reserved=
> 0
> > Datasheet:
> https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmedia.di
> gikey.com%2Fpdf%2FData%2520Sheets%2FBosch%2FBST-BMI090L-DS000-00.p
> df&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c408da449fd9bf%7C1b1
> 6ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637897751065729986%7CUnk
> nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=8GfqaDLkn5whi%2F
> bsEH9UATPNkJVgsy859sIifJGv%2BHg%3D&amp;reserved=0
> 
> blank line here. These aren't part of the tags.
Thank you, Rob, I did check, the most datasheets are part of the tags,
and few of them has a blank line, do you agree to keep it?
> 
> With that,
> 
> Acked-by: Rob Herring <robh@kernel.org>
> 
> > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > ---
> >  Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
> >  1 file changed, 2 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > index 911a1ae9c83f..272eb48eef5a 100644
> > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > @@ -17,7 +17,9 @@ description: |
> >  properties:
> >    compatible:
> >      enum:
> > +      - bosch,bmi085-accel
> >        - bosch,bmi088-accel
> > +      - bosch,bmi090l-accel
> >
> >    reg:
> >      maxItems: 1
> > --
> > 2.25.1
> >
> >
Jonathan Cameron June 3, 2022, 3:38 p.m. UTC | #3 
On Fri, 3 Jun 2022 07:32:17 +0000
LI Qingwu <qing-wu.li@leica-geosystems.com.cn> wrote:

> > -----Original Message-----
> > From: Rob Herring <robh@kernel.org>
> > Sent: Thursday, June 2, 2022 9:58 PM
> > To: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > Cc: jic23@kernel.org; lars@metafoo.de; mchehab+huawei@kernel.org;
> > ardeleanalex@gmail.com; linux-iio@vger.kernel.org;
> > linux-kernel@vger.kernel.org; mike.looijmans@topic.nl;
> > devicetree@vger.kernel.org; HAEMMERLE Thomas
> > <thomas.haemmerle@leica-geosystems.com>
> > Subject: Re: [PATCH V5 6/6] dt-bindings: iio: accel: Add bmi085 and bmi090l
> > bindings
> > 
> > This email is not from Hexagon's Office 365 instance. Please be careful while
> > clicking links, opening attachments, or replying to this email.
> > 
> > 
> > On Thu, May 26, 2022 at 01:33:59PM +0000, LI Qingwu wrote:  
> > > Adds the device-tree bindings for the Bosch
> > > BMI085 and BMI090L IMU, the accelerometer part.
> > >
> > > Datasheet:  
> > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fwww.bos
> > ch-sensortec.com%2Fmedia%2Fboschsensortec%2Fdownloads%2Fdatasheets%
> > 2Fbst-bmi085-ds001.pdf&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c4
> > 08da449fd9bf%7C1b16ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C6378977
> > 51065729986%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjo
> > iV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdat
> > a=K3PYyQAGsySCIjKuo1QRVm1HE0cuC3BVXbjuAwwhMjM%3D&amp;reserved=
> > 0  
> > > Datasheet:  
> > https://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fmedia.di
> > gikey.com%2Fpdf%2FData%2520Sheets%2FBosch%2FBST-BMI090L-DS000-00.p
> > df&amp;data=05%7C01%7C%7C6bb7d63d627c49b946c408da449fd9bf%7C1b1
> > 6ab3eb8f64fe39f3e2db7fe549f6a%7C0%7C0%7C637897751065729986%7CUnk
> > nown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1h
> > aWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&amp;sdata=8GfqaDLkn5whi%2F
> > bsEH9UATPNkJVgsy859sIifJGv%2BHg%3D&amp;reserved=0
> > 
> > blank line here. These aren't part of the tags.  
> Thank you, Rob, I did check, the most datasheets are part of the tags,
> and few of them has a blank line, do you agree to keep it?

Seems we have some disagreement on this.  Personally I thought they'd been
adopted as a standard tag block entry, though I can't immediately find
a clear statement of that. 

+CC Andy who has commented on this before.


> > 
> > With that,
> > 
> > Acked-by: Rob Herring <robh@kernel.org>
> >   
> > > Signed-off-by: LI Qingwu <Qing-wu.Li@leica-geosystems.com.cn>
> > > ---
> > >  Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml | 2 ++
> > >  1 file changed, 2 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml  
> > b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml  
> > > index 911a1ae9c83f..272eb48eef5a 100644
> > > --- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > > +++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
> > > @@ -17,7 +17,9 @@ description: |
> > >  properties:
> > >    compatible:
> > >      enum:
> > > +      - bosch,bmi085-accel
> > >        - bosch,bmi088-accel
> > > +      - bosch,bmi090l-accel
> > >
> > >    reg:
> > >      maxItems: 1
> > > --
> > > 2.25.1
> > >
> > >
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
index 911a1ae9c83f..272eb48eef5a 100644
--- a/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
+++ b/Documentation/devicetree/bindings/iio/accel/bosch,bmi088.yaml
@@ -17,7 +17,9 @@  description: |
 properties:
   compatible:
     enum:
+      - bosch,bmi085-accel
       - bosch,bmi088-accel
+      - bosch,bmi090l-accel
 
   reg:
     maxItems: 1