diff mbox series

[v7,1/3] dt-bindings: adc-joystick: add poll-interval

Message ID 20220705190354.69263-2-macromorgan@hotmail.com (mailing list archive)
State Changes Requested
Headers show
Series adc-joystick: Add polled support | expand

Commit Message

Chris Morgan July 5, 2022, 7:03 p.m. UTC 
From: Chris Morgan <macroalpha82@gmail.com>

Add poll-interval support for the adc-joystick documentation. This is
an optional value and if not provided the adc-joystick works as it
does today (with buffers). If this value is provided, the adc-joystick
driver is polled at the specified interval. The existing attribute of
"poll-interval" was used instead of complying with property-units.yaml
after discussion of the issue on the mailing list.

Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
---
 Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Rob Herring (Arm) July 6, 2022, 2:37 p.m. UTC | #1 
On Tue, 05 Jul 2022 14:03:52 -0500, Chris Morgan wrote:
> From: Chris Morgan <macroalpha82@gmail.com>
> 
> Add poll-interval support for the adc-joystick documentation. This is
> an optional value and if not provided the adc-joystick works as it
> does today (with buffers). If this value is provided, the adc-joystick
> driver is polled at the specified interval. The existing attribute of
> "poll-interval" was used instead of complying with property-units.yaml
> after discussion of the issue on the mailing list.
> 
> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
> ---
>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++
>  1 file changed, 5 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>
Artur Rojek July 6, 2022, 8:58 p.m. UTC | #2 
On 2022-07-06 16:37, Rob Herring wrote:
> On Tue, 05 Jul 2022 14:03:52 -0500, Chris Morgan wrote:
>> From: Chris Morgan <macroalpha82@gmail.com>
>> 
>> Add poll-interval support for the adc-joystick documentation. This is
>> an optional value and if not provided the adc-joystick works as it
>> does today (with buffers). If this value is provided, the adc-joystick
>> driver is polled at the specified interval. The existing attribute of
>> "poll-interval" was used instead of complying with property-units.yaml
>> after discussion of the issue on the mailing list.
>> 
>> Signed-off-by: Maya Matuszczyk <maccraft123mc@gmail.com>
>> Signed-off-by: Chris Morgan <macromorgan@hotmail.com>
>> ---
>>  Documentation/devicetree/bindings/input/adc-joystick.yaml | 5 +++++
>>  1 file changed, 5 insertions(+)
>> 
> 
> Reviewed-by: Rob Herring <robh@kernel.org>

Acked-by: Artur Rojek <contact@artur-rojek.eu>
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/input/adc-joystick.yaml b/Documentation/devicetree/bindings/input/adc-joystick.yaml
index 2ee04e03bc22..ab5caad055ea 100644
--- a/Documentation/devicetree/bindings/input/adc-joystick.yaml
+++ b/Documentation/devicetree/bindings/input/adc-joystick.yaml
@@ -14,6 +14,9 @@  description: >
   Bindings for joystick devices connected to ADC controllers supporting
   the Industrial I/O subsystem.
 
+allOf:
+  - $ref: input.yaml#
+
 properties:
   compatible:
     const: adc-joystick
@@ -28,6 +31,8 @@  properties:
       https://github.com/devicetree-org/dt-schema/blob/master/schemas/iio/iio-consumer.yaml
       for details.
 
+  poll-interval: true
+
   '#address-cells':
     const: 1