| Message ID | 20220921063026.89619-4-matt.ranostay@konsulko.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | HID: mcp2221: iio support and device resource management | expand |
On Tue, 20 Sep 2022 23:30:24 -0700 Matt Ranostay <matt.ranostay@konsulko.com> wrote: > When using 'imply IIO' for other configurations which have 'select GPIOLIB' > the following recursive dependency is detected for AD5592R/AD5593R > > Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per > recommendation in kconfig-language.rst > > drivers/gpio/Kconfig:14:error: recursive dependency detected! > drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by AD5592R > drivers/iio/dac/Kconfig:93: symbol AD5592R depends on IIO > drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221 > drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB > > Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> Acked-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- > drivers/iio/dac/Kconfig | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig > index 80521bd28d0f..b93003e80b70 100644 > --- a/drivers/iio/dac/Kconfig > +++ b/drivers/iio/dac/Kconfig > @@ -92,8 +92,7 @@ config AD5592R_BASE > > config AD5592R > tristate "Analog Devices AD5592R ADC/DAC driver" > - depends on SPI_MASTER > - select GPIOLIB > + depends on SPI_MASTER && GPIOLIB > select AD5592R_BASE > help > Say yes here to build support for Analog Devices AD5592R > @@ -104,8 +103,7 @@ config AD5592R > > config AD5593R > tristate "Analog Devices AD5593R ADC/DAC driver" > - depends on I2C > - select GPIOLIB > + depends on I2C && GPIOLIB > select AD5592R_BASE > help > Say yes here to build support for Analog Devices AD5593R
diff --git a/drivers/iio/dac/Kconfig b/drivers/iio/dac/Kconfig index 80521bd28d0f..b93003e80b70 100644 --- a/drivers/iio/dac/Kconfig +++ b/drivers/iio/dac/Kconfig @@ -92,8 +92,7 @@ config AD5592R_BASE config AD5592R tristate "Analog Devices AD5592R ADC/DAC driver" - depends on SPI_MASTER - select GPIOLIB + depends on SPI_MASTER && GPIOLIB select AD5592R_BASE help Say yes here to build support for Analog Devices AD5592R @@ -104,8 +103,7 @@ config AD5592R config AD5593R tristate "Analog Devices AD5593R ADC/DAC driver" - depends on I2C - select GPIOLIB + depends on I2C && GPIOLIB select AD5592R_BASE help Say yes here to build support for Analog Devices AD5593R
When using 'imply IIO' for other configurations which have 'select GPIOLIB' the following recursive dependency is detected for AD5592R/AD5593R Switch from 'select GPIOLIB' to 'depends on GPIOLIB' to avoid this per recommendation in kconfig-language.rst drivers/gpio/Kconfig:14:error: recursive dependency detected! drivers/gpio/Kconfig:14: symbol GPIOLIB is selected by AD5592R drivers/iio/dac/Kconfig:93: symbol AD5592R depends on IIO drivers/iio/Kconfig:6: symbol IIO is implied by HID_MCP2221 drivers/hid/Kconfig:1227: symbol HID_MCP2221 depends on GPIOLIB Signed-off-by: Matt Ranostay <matt.ranostay@konsulko.com> --- drivers/iio/dac/Kconfig | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)