| Message ID | 20221004115642.63749-1-krzysztof.kozlowski@linaro.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [1/8] dt-bindings: iio: addac: adi,ad74413r: use spi-peripheral-props.yaml | expand |
On Tue, 04 Oct 2022 13:56:35 +0200, Krzysztof Kozlowski wrote: > Reference the spi-peripheral-props.yaml schema to allow using all > properties typical for SPI-connected devices, even these which device > bindings author did not tried yet. > > While changing additionalProperties->unevaluatedProperties, put it in > typical place, just before example DTS. > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > --- > .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > Acked-by: Rob Herring <robh@kernel.org>
On Wed, 5 Oct 2022 08:25:27 -0500 Rob Herring <robh@kernel.org> wrote: > On Tue, 04 Oct 2022 13:56:35 +0200, Krzysztof Kozlowski wrote: > > Reference the spi-peripheral-props.yaml schema to allow using all > > properties typical for SPI-connected devices, even these which device > > bindings author did not tried yet. > > > > While changing additionalProperties->unevaluatedProperties, put it in > > typical place, just before example DTS. > > > > Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > --- > > .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 7 +++++-- > > 1 file changed, 5 insertions(+), 2 deletions(-) > > > > Acked-by: Rob Herring <robh@kernel.org> Series applied,. Kryzsztof, thanks for your continuing work to clean this stuff up. One small request for future similar series. Please add a cover letter with a very minimal intro. If nothing else it gives me an obviously place to reply to in order to say I applied them all! Also works for anyone who wants to give series wide tags. Thanks, Jonathan
On 09/10/2022 12:16, Jonathan Cameron wrote: > On Wed, 5 Oct 2022 08:25:27 -0500 > Rob Herring <robh@kernel.org> wrote: > >> On Tue, 04 Oct 2022 13:56:35 +0200, Krzysztof Kozlowski wrote: >>> Reference the spi-peripheral-props.yaml schema to allow using all >>> properties typical for SPI-connected devices, even these which device >>> bindings author did not tried yet. >>> >>> While changing additionalProperties->unevaluatedProperties, put it in >>> typical place, just before example DTS. >>> >>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> --- >>> .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 7 +++++-- >>> 1 file changed, 5 insertions(+), 2 deletions(-) >>> >> >> Acked-by: Rob Herring <robh@kernel.org> > > Series applied,. > > Kryzsztof, thanks for your continuing work to clean this stuff up. > One small request for future similar series. Please add a cover > letter with a very minimal intro. If nothing else it gives me an > obviously place to reply to in order to say I applied them all! > > Also works for anyone who wants to give series wide tags. Sure! Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml index 03bb90a7f4f8..2e8dad9278f2 100644 --- a/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml +++ b/Documentation/devicetree/bindings/iio/addac/adi,ad74413r.yaml @@ -58,8 +58,6 @@ required: - spi-cpol - refin-supply -additionalProperties: false - patternProperties: "^channel@[0-3]$": type: object @@ -103,6 +101,11 @@ patternProperties: required: - reg +allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# + +unevaluatedProperties: false + examples: - | #include <dt-bindings/gpio/gpio.h>
Reference the spi-peripheral-props.yaml schema to allow using all properties typical for SPI-connected devices, even these which device bindings author did not tried yet. While changing additionalProperties->unevaluatedProperties, put it in typical place, just before example DTS. Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> --- .../devicetree/bindings/iio/addac/adi,ad74413r.yaml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)