| Message ID | 20230113141117.23353-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/1] iio: chemical: scd30_core: use sysfs_emit() to instead of scnprintf() | expand |
On Fri, 13 Jan 2023 16:11:17 +0200 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > Follow the advice of the Documentation/filesystems/sysfs.rst and show() > should only use sysfs_emit() or sysfs_emit_at() when formatting the > value to be returned to user space. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Applied Thanks, > --- > drivers/iio/chemical/scd30_core.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c > index 682fca39d14d..e0bb1dd5e790 100644 > --- a/drivers/iio/chemical/scd30_core.c > +++ b/drivers/iio/chemical/scd30_core.c > @@ -354,7 +354,7 @@ static ssize_t sampling_frequency_available_show(struct device *dev, struct devi > ssize_t len = 0; > > do { > - len += scnprintf(buf + len, PAGE_SIZE - len, "0.%09u ", 1000000000 / i); > + len += sysfs_emit_at(buf, len, "0.%09u ", 1000000000 / i); > /* > * Not all values fit PAGE_SIZE buffer hence print every 6th > * (each frequency differs by 6s in time domain from the > @@ -380,7 +380,7 @@ static ssize_t calibration_auto_enable_show(struct device *dev, struct device_at > ret = scd30_command_read(state, CMD_ASC, &val); > mutex_unlock(&state->lock); > > - return ret ?: sprintf(buf, "%d\n", val); > + return ret ?: sysfs_emit(buf, "%d\n", val); > } > > static ssize_t calibration_auto_enable_store(struct device *dev, struct device_attribute *attr, > @@ -414,7 +414,7 @@ static ssize_t calibration_forced_value_show(struct device *dev, struct device_a > ret = scd30_command_read(state, CMD_FRC, &val); > mutex_unlock(&state->lock); > > - return ret ?: sprintf(buf, "%d\n", val); > + return ret ?: sysfs_emit(buf, "%d\n", val); > } > > static ssize_t calibration_forced_value_store(struct device *dev, struct device_attribute *attr,
diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c index 682fca39d14d..e0bb1dd5e790 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -354,7 +354,7 @@ static ssize_t sampling_frequency_available_show(struct device *dev, struct devi ssize_t len = 0; do { - len += scnprintf(buf + len, PAGE_SIZE - len, "0.%09u ", 1000000000 / i); + len += sysfs_emit_at(buf, len, "0.%09u ", 1000000000 / i); /* * Not all values fit PAGE_SIZE buffer hence print every 6th * (each frequency differs by 6s in time domain from the @@ -380,7 +380,7 @@ static ssize_t calibration_auto_enable_show(struct device *dev, struct device_at ret = scd30_command_read(state, CMD_ASC, &val); mutex_unlock(&state->lock); - return ret ?: sprintf(buf, "%d\n", val); + return ret ?: sysfs_emit(buf, "%d\n", val); } static ssize_t calibration_auto_enable_store(struct device *dev, struct device_attribute *attr, @@ -414,7 +414,7 @@ static ssize_t calibration_forced_value_show(struct device *dev, struct device_a ret = scd30_command_read(state, CMD_FRC, &val); mutex_unlock(&state->lock); - return ret ?: sprintf(buf, "%d\n", val); + return ret ?: sysfs_emit(buf, "%d\n", val); } static ssize_t calibration_forced_value_store(struct device *dev, struct device_attribute *attr,
Follow the advice of the Documentation/filesystems/sysfs.rst and show() should only use sysfs_emit() or sysfs_emit_at() when formatting the value to be returned to user space. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/chemical/scd30_core.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)