| Message ID | 20230312210933.2275376-1-lars@metafoo.de (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: adc: ti-ads7950: Set `can_sleep` flag for GPIO chip | expand |
On 3/12/23 4:09 PM, Lars-Peter Clausen wrote: > The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks. > This means these callbacks can sleep and the `can_sleep` flag should be > set. > > Having the flag set will make sure that warnings are generated when calling > any of the callbacks from a potentially non-sleeping context. > > Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support") > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > --- Acked-by: David Lechner <david@lechnology.com>
On Mon, 13 Mar 2023 13:44:33 -0500 David Lechner <david@lechnology.com> wrote: > On 3/12/23 4:09 PM, Lars-Peter Clausen wrote: > > The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks. > > This means these callbacks can sleep and the `can_sleep` flag should be > > set. > > > > Having the flag set will make sure that warnings are generated when calling > > any of the callbacks from a potentially non-sleeping context. > > > > Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support") > > Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> > > --- > > Acked-by: David Lechner <david@lechnology.com> > > Applied to the fixes-togreg branch of iio.git and marked for stable. Thanks, Jonathan
diff --git a/drivers/iio/adc/ti-ads7950.c b/drivers/iio/adc/ti-ads7950.c index 2cc9a9bd9db6..263fc3a1b87e 100644 --- a/drivers/iio/adc/ti-ads7950.c +++ b/drivers/iio/adc/ti-ads7950.c @@ -634,6 +634,7 @@ static int ti_ads7950_probe(struct spi_device *spi) st->chip.label = dev_name(&st->spi->dev); st->chip.parent = &st->spi->dev; st->chip.owner = THIS_MODULE; + st->chip.can_sleep = true; st->chip.base = -1; st->chip.ngpio = TI_ADS7950_NUM_GPIOS; st->chip.get_direction = ti_ads7950_get_direction;
The ads7950 uses a mutex as well as SPI transfers in its GPIO callbacks. This means these callbacks can sleep and the `can_sleep` flag should be set. Having the flag set will make sure that warnings are generated when calling any of the callbacks from a potentially non-sleeping context. Fixes: c97dce792dc8 ("iio: adc: ti-ads7950: add GPIO support") Signed-off-by: Lars-Peter Clausen <lars@metafoo.de> --- Sorry if you received this twice. Forgot to cc the mailinglist on the first try. --- drivers/iio/adc/ti-ads7950.c | 1 + 1 file changed, 1 insertion(+)