| Message ID | 20230316203426.224745-1-william.gray@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | counter: 104-quad-8: Fix Synapse action reported for Index signals | expand |
On Thu, Mar 16, 2023 at 04:34:26PM -0400, William Breathitt Gray wrote: > Signal 16 and higher represent the device's Index lines. The > priv->preset_enable array holds the device configuration for these Index > lines. The preset_enable configuration is active low on the device, so > invert the conditional check in quad8_action_read() to properly handle > the logical state of preset_enable. > > Fixes: f1d8a071d45b ("counter: 104-quad-8: Add Generic Counter interface support") > Cc: <stable@vger.kernel.org> > Signed-off-by: William Breathitt Gray <william.gray@linaro.org> Applied to counter-fixes. William Breathitt Gray
diff --git a/drivers/counter/104-quad-8.c b/drivers/counter/104-quad-8.c index deed4afadb29..529bce4ee631 100644 --- a/drivers/counter/104-quad-8.c +++ b/drivers/counter/104-quad-8.c @@ -378,7 +378,7 @@ static int quad8_action_read(struct counter_device *counter, /* Handle Index signals */ if (synapse->signal->id >= 16) { - if (priv->preset_enable[count->id]) + if (!priv->preset_enable[count->id]) *action = COUNTER_SYNAPSE_ACTION_RISING_EDGE; else *action = COUNTER_SYNAPSE_ACTION_NONE;
Signal 16 and higher represent the device's Index lines. The priv->preset_enable array holds the device configuration for these Index lines. The preset_enable configuration is active low on the device, so invert the conditional check in quad8_action_read() to properly handle the logical state of preset_enable. Fixes: f1d8a071d45b ("counter: 104-quad-8: Add Generic Counter interface support") Cc: <stable@vger.kernel.org> Signed-off-by: William Breathitt Gray <william.gray@linaro.org> --- drivers/counter/104-quad-8.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6