| Message ID | 20230731094455.26742-1-antoniu.miclaus@analog.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v3,1/2] dt-bindings: iio: admv1013: add vcc regulators | expand |
On Mon, Jul 31, 2023 at 12:44:54PM +0300, Antoniu Miclaus wrote: > Add bindings for the VCC regulators of the ADMV1013 microware > upconverter. > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> Assuming the driver or regulator core handles the missing regulators on older devicetrees (which I think it does with dummy regulators?) Acked-by: Conor Dooley <conor.dooley@microchip.com> Thanks, Conor. > --- > changes in v3: > - add missing spaces in the commit subject. > .../bindings/iio/frequency/adi,admv1013.yaml | 60 +++++++++++++++++++ > 1 file changed, 60 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > index fc813bcb6532..f2eb2287ed9e 100644 > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > @@ -39,6 +39,46 @@ properties: > description: > Analog voltage regulator. > > + vcc-drv-supply: > + description: > + RF Driver voltage regulator. > + > + vcc2-drv-supply: > + description: > + RF predriver voltage regulator. > + > + vcc-vva-supply: > + description: > + VVA Control Circuit voltage regulator. > + > + vcc-amp1-supply: > + description: > + RF Amplifier 1 voltage regulator. > + > + vcc-amp2-supply: > + description: > + RF Amplifier 2 voltage regulator. > + > + vcc-env-supply: > + description: > + Envelope Detector voltage regulator. > + > + vcc-bg-supply: > + description: > + Mixer Chip Band Gap Circuit voltage regulator. > + > + vcc-bg2-supply: > + description: > + VGA Chip Band Gap Circuit voltage regulator. > + > + vcc-mixer-supply: > + description: > + Mixer voltage regulator. > + > + vcc-quad-supply: > + description: > + Quadruppler voltage regulator. > + > adi,detector-enable: > description: > Enable the Envelope Detector available at output pins VENV_P and > @@ -69,6 +109,16 @@ required: > - clocks > - clock-names > - vcm-supply > + - vcc-drv-supply > + - vcc2-drv-supply > + - vcc-vva-supply > + - vcc-amp1-supply > + - vcc-amp2-supply > + - vcc-env-supply > + - vcc-bg-supply > + - vcc-bg2-supply > + - vcc-mixer-supply > + - vcc-quad-supply > > allOf: > - $ref: /schemas/spi/spi-peripheral-props.yaml# > @@ -87,6 +137,16 @@ examples: > clocks = <&admv1013_lo>; > clock-names = "lo_in"; > vcm-supply = <&vcm>; > + vcc-drv-supply = <&vcc_drv>; > + vcc2-drv-supply = <&vcc2_drv>; > + vcc-vva-supply = <&vcc_vva>; > + vcc-amp1-supply = <&vcc_amp1>; > + vcc-amp2-supply = <&vcc_amp2>; > + vcc-env-supply = <&vcc_env>; > + vcc-bg-supply = <&vcc_bg>; > + vcc-bg2-supply = <&vcc_bg2>; > + vcc-mixer-supply = <&vcc_mixer>; > + vcc-quad-supply = <&vcc_quad>; > adi,quad-se-mode = "diff"; > adi,detector-enable; > }; > -- > 2.41.0 >
On Tue, 1 Aug 2023 22:09:28 +0100 Conor Dooley <conor@kernel.org> wrote: > On Mon, Jul 31, 2023 at 12:44:54PM +0300, Antoniu Miclaus wrote: > > Add bindings for the VCC regulators of the ADMV1013 microware > > upconverter. > > > > Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> > > Assuming the driver or regulator core handles the missing regulators on > older devicetrees (which I think it does with dummy regulators?) Yup - that should happen fine. > Acked-by: Conor Dooley <conor.dooley@microchip.com> Series applied to the togreg branch of iio.git and pushed out as testing for 0-day to poke at it. Thanks, Jonathan > > Thanks, > Conor. > > > --- > > changes in v3: > > - add missing spaces in the commit subject. > > .../bindings/iio/frequency/adi,admv1013.yaml | 60 +++++++++++++++++++ > > 1 file changed, 60 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > index fc813bcb6532..f2eb2287ed9e 100644 > > --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml > > @@ -39,6 +39,46 @@ properties: > > description: > > Analog voltage regulator. > > > > + vcc-drv-supply: > > + description: > > + RF Driver voltage regulator. > > + > > + vcc2-drv-supply: > > + description: > > + RF predriver voltage regulator. > > + > > + vcc-vva-supply: > > + description: > > + VVA Control Circuit voltage regulator. > > + > > + vcc-amp1-supply: > > + description:in/v3_20230731_antoniu_miclaus_dt_bindings_iio_admv1013_add_vcc_regulators.mbx > > + RF Amplifier 1 voltage regulator. > > + > > + vcc-amp2-supply: > > + description: > > + RF Amplifier 2 voltage regulator. > > + > > + vcc-env-supply: > > + description: > > + Envelope Detector voltage regulator. > > + > > + vcc-bg-supply: > > + description: > > + Mixer Chip Band Gap Circuit voltage regulator. > > + > > + vcc-bg2-supply: > > + description: > > + VGA Chip Band Gap Circuit voltage regulator. > > + > > + vcc-mixer-supply: > > + description: > > + Mixer voltage regulator. > > + > > + vcc-quad-supply: > > + description: > > + Quadruppler voltage regulator. > > + > > adi,detector-enable: > > description: > > Enable the Envelope Detector available at output pins VENV_P and > > @@ -69,6 +109,16 @@ required: > > - clocks > > - clock-names > > - vcm-supply > > + - vcc-drv-supply > > + - vcc2-drv-supply > > + - vcc-vva-supply > > + - vcc-amp1-supply > > + - vcc-amp2-supply > > + - vcc-env-supply > > + - vcc-bg-supply > > + - vcc-bg2-supply > > + - vcc-mixer-supply > > + - vcc-quad-supply > > > > allOf: > > - $ref: /schemas/spi/spi-peripheral-props.yaml# > > @@ -87,6 +137,16 @@ examples: > > clocks = <&admv1013_lo>; > > clock-names = "lo_in"; > > vcm-supply = <&vcm>; > > + vcc-drv-supply = <&vcc_drv>; > > + vcc2-drv-supply = <&vcc2_drv>; > > + vcc-vva-supply = <&vcc_vva>; > > + vcc-amp1-supply = <&vcc_amp1>; > > + vcc-amp2-supply = <&vcc_amp2>; > > + vcc-env-supply = <&vcc_env>; > > + vcc-bg-supply = <&vcc_bg>; > > + vcc-bg2-supply = <&vcc_bg2>; > > + vcc-mixer-supply = <&vcc_mixer>; > > + vcc-quad-supply = <&vcc_quad>; > > adi,quad-se-mode = "diff"; > > adi,detector-enable; > > }; > > -- > > 2.41.0 > >
diff --git a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml index fc813bcb6532..f2eb2287ed9e 100644 --- a/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml +++ b/Documentation/devicetree/bindings/iio/frequency/adi,admv1013.yaml @@ -39,6 +39,46 @@ properties: description: Analog voltage regulator. + vcc-drv-supply: + description: + RF Driver voltage regulator. + + vcc2-drv-supply: + description: + RF predriver voltage regulator. + + vcc-vva-supply: + description: + VVA Control Circuit voltage regulator. + + vcc-amp1-supply: + description: + RF Amplifier 1 voltage regulator. + + vcc-amp2-supply: + description: + RF Amplifier 2 voltage regulator. + + vcc-env-supply: + description: + Envelope Detector voltage regulator. + + vcc-bg-supply: + description: + Mixer Chip Band Gap Circuit voltage regulator. + + vcc-bg2-supply: + description: + VGA Chip Band Gap Circuit voltage regulator. + + vcc-mixer-supply: + description: + Mixer voltage regulator. + + vcc-quad-supply: + description: + Quadruppler voltage regulator. + adi,detector-enable: description: Enable the Envelope Detector available at output pins VENV_P and @@ -69,6 +109,16 @@ required: - clocks - clock-names - vcm-supply + - vcc-drv-supply + - vcc2-drv-supply + - vcc-vva-supply + - vcc-amp1-supply + - vcc-amp2-supply + - vcc-env-supply + - vcc-bg-supply + - vcc-bg2-supply + - vcc-mixer-supply + - vcc-quad-supply allOf: - $ref: /schemas/spi/spi-peripheral-props.yaml# @@ -87,6 +137,16 @@ examples: clocks = <&admv1013_lo>; clock-names = "lo_in"; vcm-supply = <&vcm>; + vcc-drv-supply = <&vcc_drv>; + vcc2-drv-supply = <&vcc2_drv>; + vcc-vva-supply = <&vcc_vva>; + vcc-amp1-supply = <&vcc_amp1>; + vcc-amp2-supply = <&vcc_amp2>; + vcc-env-supply = <&vcc_env>; + vcc-bg-supply = <&vcc_bg>; + vcc-bg2-supply = <&vcc_bg2>; + vcc-mixer-supply = <&vcc_mixer>; + vcc-quad-supply = <&vcc_quad>; adi,quad-se-mode = "diff"; adi,detector-enable; };
Add bindings for the VCC regulators of the ADMV1013 microware upconverter. Signed-off-by: Antoniu Miclaus <antoniu.miclaus@analog.com> --- changes in v3: - add missing spaces in the commit subject. .../bindings/iio/frequency/adi,admv1013.yaml | 60 +++++++++++++++++++ 1 file changed, 60 insertions(+)