| Message ID | 20230808164204.66818-1-andriy.shevchenko@linux.intel.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [v1,1/1] iio: accel: kionix-kx022a: Use correct header(s) instead of string_helpers.h | expand |
On 8/8/23 19:42, Andy Shevchenko wrote: > There is nothing from string_helpers.h used in the driver, correct > the header inclusion block accordingly. > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Acked-by: Matti Vaittinen <mazziesaccount@gmail.com> Out of the curiosity - is the goal to get rid of including choices from helpers? (I think) then the header split would be more beneficial. > --- > drivers/iio/accel/kionix-kx022a.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c > index 4ea3c6718ed4..f164b09520c9 100644 > --- a/drivers/iio/accel/kionix-kx022a.c > +++ b/drivers/iio/accel/kionix-kx022a.c > @@ -15,7 +15,7 @@ > #include <linux/regmap.h> > #include <linux/regulator/consumer.h> > #include <linux/slab.h> > -#include <linux/string_helpers.h> > +#include <linux/string_choices.h> > #include <linux/units.h> > > #include <linux/iio/iio.h>
On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote: > On 8/8/23 19:42, Andy Shevchenko wrote: > > There is nothing from string_helpers.h used in the driver, correct > > the header inclusion block accordingly. > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > Acked-by: Matti Vaittinen <mazziesaccount@gmail.com> > > Out of the curiosity - is the goal to get rid of including choices from > helpers? (I think) then the header split would be more beneficial. At the end, yes. Thank you for acknowledging!
On Thu, 10 Aug 2023 16:29:25 +0300 Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote: > On Wed, Aug 09, 2023 at 09:00:39AM +0300, Matti Vaittinen wrote: > > On 8/8/23 19:42, Andy Shevchenko wrote: > > > There is nothing from string_helpers.h used in the driver, correct > > > the header inclusion block accordingly. > > > > > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > > > > Acked-by: Matti Vaittinen <mazziesaccount@gmail.com> > > > > Out of the curiosity - is the goal to get rid of including choices from > > helpers? (I think) then the header split would be more beneficial. > > At the end, yes. > > Thank you for acknowledging! > Applied.
diff --git a/drivers/iio/accel/kionix-kx022a.c b/drivers/iio/accel/kionix-kx022a.c index 4ea3c6718ed4..f164b09520c9 100644 --- a/drivers/iio/accel/kionix-kx022a.c +++ b/drivers/iio/accel/kionix-kx022a.c @@ -15,7 +15,7 @@ #include <linux/regmap.h> #include <linux/regulator/consumer.h> #include <linux/slab.h> -#include <linux/string_helpers.h> +#include <linux/string_choices.h> #include <linux/units.h> #include <linux/iio/iio.h>
There is nothing from string_helpers.h used in the driver, correct the header inclusion block accordingly. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> --- drivers/iio/accel/kionix-kx022a.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)