| Message ID | 20230814121010.184842-2-marcus.folkesson@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v5,1/6] dt-bindings: iio: adc: mcp3911: add support for the whole MCP39xx family | expand |
On Mon, Aug 14, 2023 at 02:10:06PM +0200, Marcus Folkesson wrote: > Simplify code by switch to dev_err_probe(). > > Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> > --- > > Notes: > v5: > - New patch in this series > > drivers/iio/adc/mcp3911.c | 11 +++-------- > 1 file changed, 3 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c > index 974c5bd923a6..681248a3ddde 100644 > --- a/drivers/iio/adc/mcp3911.c > +++ b/drivers/iio/adc/mcp3911.c > @@ -468,6 +468,7 @@ static int mcp3911_probe(struct spi_device *spi) > { > struct iio_dev *indio_dev; > struct mcp3911 *adc; > + struct device *dev = &spi->dev; > int ret; With preserved reversed xmas tree order (longer line comes first), Reviewed-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc)); > @@ -482,10 +483,7 @@ static int mcp3911_probe(struct spi_device *spi) > if (PTR_ERR(adc->vref) == -ENODEV) { > adc->vref = NULL; > } else { > - dev_err(&adc->spi->dev, > - "failed to get regulator (%ld)\n", > - PTR_ERR(adc->vref)); > - return PTR_ERR(adc->vref); > + return dev_err_probe(dev, PTR_ERR(adc->vref), "failed to get regulator\n"); > } > > } else { > @@ -504,10 +502,7 @@ static int mcp3911_probe(struct spi_device *spi) > if (PTR_ERR(adc->clki) == -ENOENT) { > adc->clki = NULL; > } else { > - dev_err(&adc->spi->dev, > - "failed to get adc clk (%ld)\n", > - PTR_ERR(adc->clki)); > - return PTR_ERR(adc->clki); > + return dev_err_probe(dev, PTR_ERR(adc->clki), "failed to get adc clk\n"); > } > } > > -- > 2.41.0 >
diff --git a/drivers/iio/adc/mcp3911.c b/drivers/iio/adc/mcp3911.c index 974c5bd923a6..681248a3ddde 100644 --- a/drivers/iio/adc/mcp3911.c +++ b/drivers/iio/adc/mcp3911.c @@ -468,6 +468,7 @@ static int mcp3911_probe(struct spi_device *spi) { struct iio_dev *indio_dev; struct mcp3911 *adc; + struct device *dev = &spi->dev; int ret; indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*adc)); @@ -482,10 +483,7 @@ static int mcp3911_probe(struct spi_device *spi) if (PTR_ERR(adc->vref) == -ENODEV) { adc->vref = NULL; } else { - dev_err(&adc->spi->dev, - "failed to get regulator (%ld)\n", - PTR_ERR(adc->vref)); - return PTR_ERR(adc->vref); + return dev_err_probe(dev, PTR_ERR(adc->vref), "failed to get regulator\n"); } } else { @@ -504,10 +502,7 @@ static int mcp3911_probe(struct spi_device *spi) if (PTR_ERR(adc->clki) == -ENOENT) { adc->clki = NULL; } else { - dev_err(&adc->spi->dev, - "failed to get adc clk (%ld)\n", - PTR_ERR(adc->clki)); - return PTR_ERR(adc->clki); + return dev_err_probe(dev, PTR_ERR(adc->clki), "failed to get adc clk\n"); } }
Simplify code by switch to dev_err_probe(). Suggested-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Signed-off-by: Marcus Folkesson <marcus.folkesson@gmail.com> --- Notes: v5: - New patch in this series drivers/iio/adc/mcp3911.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-)