| Message ID | 20230903113052.846298-1-jic23@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: imu: bno055: Fix missing Kconfig dependencies | expand |
On 9/3/23 04:30, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > This driver uses IIO triggered buffers so it needs to select them in > Kconfig. > > on riscv-32bit: > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: drivers/iio/imu/bno055/bno055.o: in function `.L367': > bno055.c:(.text+0x2c96): undefined reference to `devm_iio_triggered_buffer_setup_ext' > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > Closes: https://lore.kernel.org/linux-next/40566b4b-3950-81fe-ff14-871d8c447627@infradead.org/ > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > Cc: Andrea Merello <andrea.merello@iit.it> Acked-by: Randy Dunlap <rdunlap@infradead.org> Tested-by: Randy Dunlap <rdunlap@infradead.org> Thanks. > --- > drivers/iio/imu/bno055/Kconfig | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig > index fa79b1ac4f85..83e53acfbe88 100644 > --- a/drivers/iio/imu/bno055/Kconfig > +++ b/drivers/iio/imu/bno055/Kconfig > @@ -2,6 +2,8 @@ > > config BOSCH_BNO055 > tristate > + select IIO_BUFFER > + select IIO_TRIGGERED_BUFFER > > config BOSCH_BNO055_SERIAL > tristate "Bosch BNO055 attached via UART"
On Sun, 3 Sep 2023 08:27:36 -0700 Randy Dunlap <rdunlap@infradead.org> wrote: > On 9/3/23 04:30, Jonathan Cameron wrote: > > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > > > This driver uses IIO triggered buffers so it needs to select them in > > Kconfig. > > > > on riscv-32bit: > > > > /opt/crosstool/gcc-13.2.0-nolibc/riscv32-linux/bin/riscv32-linux-ld: drivers/iio/imu/bno055/bno055.o: in function `.L367': > > bno055.c:(.text+0x2c96): undefined reference to `devm_iio_triggered_buffer_setup_ext' > > > > Reported-by: Randy Dunlap <rdunlap@infradead.org> > > Closes: https://lore.kernel.org/linux-next/40566b4b-3950-81fe-ff14-871d8c447627@infradead.org/ > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > Cc: Andrea Merello <andrea.merello@iit.it> > > Acked-by: Randy Dunlap <rdunlap@infradead.org> > Tested-by: Randy Dunlap <rdunlap@infradead.org> Applied to the fixes togreg branch of iio.git and marked for stable. I added missing fixes tag as well whilst doing so. Goes all the way back to first introduction of the driver. Thanks, Jonathan > > Thanks. > > > --- > > drivers/iio/imu/bno055/Kconfig | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig > > index fa79b1ac4f85..83e53acfbe88 100644 > > --- a/drivers/iio/imu/bno055/Kconfig > > +++ b/drivers/iio/imu/bno055/Kconfig > > @@ -2,6 +2,8 @@ > > > > config BOSCH_BNO055 > > tristate > > + select IIO_BUFFER > > + select IIO_TRIGGERED_BUFFER > > > > config BOSCH_BNO055_SERIAL > > tristate "Bosch BNO055 attached via UART" >
diff --git a/drivers/iio/imu/bno055/Kconfig b/drivers/iio/imu/bno055/Kconfig index fa79b1ac4f85..83e53acfbe88 100644 --- a/drivers/iio/imu/bno055/Kconfig +++ b/drivers/iio/imu/bno055/Kconfig @@ -2,6 +2,8 @@ config BOSCH_BNO055 tristate + select IIO_BUFFER + select IIO_TRIGGERED_BUFFER config BOSCH_BNO055_SERIAL tristate "Bosch BNO055 attached via UART"