From patchwork Thu Oct 26 14:35:31 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Subhajit Ghosh X-Patchwork-Id: 13437623 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D4EA7C25B48 for ; Thu, 26 Oct 2023 14:35:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1345236AbjJZOf4 (ORCPT ); Thu, 26 Oct 2023 10:35:56 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59302 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345286AbjJZOfw (ORCPT ); Thu, 26 Oct 2023 10:35:52 -0400 Received: from mail-pg1-x52f.google.com (mail-pg1-x52f.google.com [IPv6:2607:f8b0:4864:20::52f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 06F5F1AE for ; Thu, 26 Oct 2023 07:35:50 -0700 (PDT) Received: by mail-pg1-x52f.google.com with SMTP id 41be03b00d2f7-5aaebfac4b0so766298a12.2 for ; Thu, 26 Oct 2023 07:35:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tweaklogic.com; s=google; t=1698330949; x=1698935749; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=GADNeU8VMeN+ZUsjhqFuupJrDh+gDckp8FVMntouBr8=; b=W9Y5WaIcN4awD9r+6ORw9C5n5X3EVu+JK9PDLClR41b1f4msKxyTpfFe5/NNqamxO2 ndfDbIAOk3WUOzR4nX9d+iiMsEVd7Lp98i0zMptSjMeXs/ZHA74gNfRjadan0Kg753zI Bf4k/MX8EL6blJE93xlhlwKt6svpIQwVHznuCOQS5Fbj/UVF8dZ2rBsCW6uX92Yi1W9V hTCYBDoXkssRTiRp/iU3CgF1UEIiDK8iQOYpbQ8E5XR/CogHGMAPfwTM2/AxptVQrCER 6mHlFDQaWxLAsc8jExi78KKtm6LwRglwFenokUZ0KFP6vE2e7319X6aDIwng/7XeWzvg 0DrQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1698330949; x=1698935749; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GADNeU8VMeN+ZUsjhqFuupJrDh+gDckp8FVMntouBr8=; b=jQSCNewyHyu+Y6Igc97g94ZxgCP83YqvMQAZBUMlDikZypMbu6ZaTa0/hK1anGfhmW gECauFjvH/tBbZHETtPhqIvuz4pJGOnY5DdX9aOsdNqLMRvbAtun+edUWjCfXrDSgPOS 5aLX5p6dZK5bWcoFSCvKkj4FPaW49/bk6t1TxfTRY388JLSL+jBhDsji1EhrzIH4qBcX u59vM8k3qae5SqsNXpfBzPNOyQk+pJcMkeMu6QHHWTU1CetWY55CaTqXA/U2aKBxj4/v +jwMtVBF1wW92a2jKE2PjQsn8CmZ6FUd9+2a0aTLZNIQPPBwNrAmd34nmi+una5gDS68 MyBg== X-Gm-Message-State: AOJu0YwzlM1Dl4FmI4DRUEUjKib06A8v6dFnaX4RVWi96+RMQWCsaqVM TIfcH8VqPyddKLG1Ri9EbT2QLw== X-Google-Smtp-Source: AGHT+IHP5gsv0gW18Tmg8C3ceRMS/SpMC1HPwLXEy6DtWHIfi4mrXfn77tau1E4st7x7akwUSL2umA== X-Received: by 2002:a17:90a:35c:b0:27f:fa4c:ebaf with SMTP id 28-20020a17090a035c00b0027ffa4cebafmr1423484pjf.14.1698330949399; Thu, 26 Oct 2023 07:35:49 -0700 (PDT) Received: from localhost.localdomain (2403-580d-82f4-0-16bf-4026-a446-e128.ip6.aussiebb.net. [2403:580d:82f4:0:16bf:4026:a446:e128]) by smtp.gmail.com with ESMTPSA id iq11-20020a17090afb4b00b00256b67208b1sm1727519pjb.56.2023.10.26.07.35.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 26 Oct 2023 07:35:49 -0700 (PDT) From: Subhajit Ghosh To: Jonathan Cameron , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Matti Vaittinen , Andy Shevchenko , Paul Gazzillo Cc: Subhajit Ghosh , Matt Ranostay , Stefan Windfeldt-Prytz , linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH v1 1/2] dt-bindings: iio: light: Avago APDS9306 Date: Fri, 27 Oct 2023 01:05:31 +1030 Message-Id: <20231026143532.39660-2-subhajit.ghosh@tweaklogic.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20231026143532.39660-1-subhajit.ghosh@tweaklogic.com> References: <20231026143532.39660-1-subhajit.ghosh@tweaklogic.com> MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org v0 -> v1 - Squashing Avago (Broadcom) APDS9300 and APDS9960 schemas into one as they look similar - Adding support for APDS9306 in the same schema file - Adding mandatory interrupt property requirement for APDS9960 as per the driver's probe method which fails if interrupt bindings are not defined. Both APDS9300 and APDS9306 (this patch set) supports sensors with and without hardware interrupt bindings - In the device tree example, replacing interrupt type number with macro from irq.h - Updated the vin to vdd which is the same for all the three sensors - Used proper "Datasheet:" tags Signed-off-by: Subhajit Ghosh --- .../bindings/iio/light/avago,apds9300.yaml | 35 ++++++++++++--- .../bindings/iio/light/avago,apds9960.yaml | 44 ------------------- 2 files changed, 30 insertions(+), 49 deletions(-) delete mode 100644 Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml index 206af44f2c43..7a24a97d0594 100644 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml +++ b/Documentation/devicetree/bindings/iio/light/avago,apds9300.yaml @@ -4,17 +4,26 @@ $id: http://devicetree.org/schemas/iio/light/avago,apds9300.yaml# $schema: http://devicetree.org/meta-schemas/core.yaml# -title: Avago APDS9300 ambient light sensor +title: Avago Gesture, RGB, ALS and Proximity sensors maintainers: - Jonathan Cameron + - Matt Ranostay + - Subhajit Ghosh description: | - Datasheet at https://www.avagotech.com/docs/AV02-1077EN + Avago (Broadcom) optical and proximity sensors with I2C interfaces. + Datasheet: https://docs.broadcom.com/doc/AV02-1077EN + Datasheet: https://docs.broadcom.com/doc/AV02-4191EN + Datasheet: https://docs.broadcom.com/doc/AV02-4755EN properties: compatible: - const: avago,apds9300 + oneOf: + - enum: + - avago,apds9300 + - avago,apds9306 + - avago,apds9960 reg: maxItems: 1 @@ -22,14 +31,30 @@ properties: interrupts: maxItems: 1 -additionalProperties: false + vdd-supply: true required: - compatible - reg +allOf: + - $ref: ../common.yaml# + - if: + properties: + compatible: + contains: + enum: + - avago,apds9960 + then: + required: + - interrupts + +additionalProperties: false + examples: - | + #include + i2c { #address-cells = <1>; #size-cells = <0>; @@ -38,7 +63,7 @@ examples: compatible = "avago,apds9300"; reg = <0x39>; interrupt-parent = <&gpio2>; - interrupts = <29 8>; + interrupts = <29 IRQ_TYPE_EDGE_FALLING>; }; }; ... diff --git a/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml b/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml deleted file mode 100644 index f06e0fda5629..000000000000 --- a/Documentation/devicetree/bindings/iio/light/avago,apds9960.yaml +++ /dev/null @@ -1,44 +0,0 @@ -# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) -%YAML 1.2 ---- -$id: http://devicetree.org/schemas/iio/light/avago,apds9960.yaml# -$schema: http://devicetree.org/meta-schemas/core.yaml# - -title: Avago APDS9960 gesture/RGB/ALS/proximity sensor - -maintainers: - - Matt Ranostay - -description: | - Datasheet at https://www.avagotech.com/docs/AV02-4191EN - -properties: - compatible: - const: avago,apds9960 - - reg: - maxItems: 1 - - interrupts: - maxItems: 1 - -additionalProperties: false - -required: - - compatible - - reg - -examples: - - | - i2c { - #address-cells = <1>; - #size-cells = <0>; - - light-sensor@39 { - compatible = "avago,apds9960"; - reg = <0x39>; - interrupt-parent = <&gpio1>; - interrupts = <16 1>; - }; - }; -...