| Message ID | 20231118000614.186558-1-marex@denx.de (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/2] dt-bindings: iio: light: isl76682: Document ISL76682 | expand |
On Sat, 18 Nov 2023 01:06:09 +0100 Marek Vasut <marex@denx.de> wrote: > The ISL76682 is very basic ALS which only supports ALS or IR mode > in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any > other fancy functionality. Document it as trivial device. > > Acked-by: Conor Dooley <conor.dooley@microchip.com> > Signed-off-by: Marek Vasut <marex@denx.de> I'm always a bit in 2 minds about trivial-devices as it doesn't include a basic power supply. In this case vdd which I'd prefer to see documented even on such a simple device as this. Not everyone is going to leave it powered up all the time! Still I'm not that fussed. Maybe it's worth allowing vdd-supply in trivial-devices.yaml? Jonathan > --- > Cc: Alexander Stein <alexander.stein@ew.tq-group.com> > Cc: Andre Werner <andre.werner@systec-electronic.com> > Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com> > Cc: Bjorn Helgaas <bhelgaas@google.com> > Cc: Conor Dooley <conor+dt@kernel.org> > Cc: Fabio Estevam <festevam@denx.de> > Cc: Guenter Roeck <linux@roeck-us.net> > Cc: Jonathan Cameron <jic23@kernel.org> > Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> > Cc: Lars-Peter Clausen <lars@metafoo.de> > Cc: Luca Ceresoli <luca.ceresoli@bootlin.com> > Cc: Mark Brown <broonie@kernel.org> > Cc: Matti Vaittinen <mazziesaccount@gmail.com> > Cc: Naresh Solanki <naresh.solanki@9elements.com> > Cc: Patrick Rudolph <patrick.rudolph@9elements.com> > Cc: Rob Herring <robh+dt@kernel.org> > Cc: Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com> > Cc: Vincent Tremblay <vincent@vtremblay.dev> > Cc: devicetree@vger.kernel.org > Cc: linux-iio@vger.kernel.org > --- > V2: Add AB from Conor > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index c3190f2a168a2..27164e9219276 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -179,6 +179,8 @@ properties: > - isil,isl29030 > # Intersil ISL68137 Digital Output Configurable PWM Controller > - isil,isl68137 > + # Intersil ISL76682 Ambient Light Sensor > + - isil,isl76682 > # Linear Technology LTC2488 > - lineartechnology,ltc2488 > # 5 Bit Programmable, Pulse-Width Modulator
On 11/19/23 16:07, Jonathan Cameron wrote: > On Sat, 18 Nov 2023 01:06:09 +0100 > Marek Vasut <marex@denx.de> wrote: > >> The ISL76682 is very basic ALS which only supports ALS or IR mode >> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any >> other fancy functionality. Document it as trivial device. >> >> Acked-by: Conor Dooley <conor.dooley@microchip.com> >> Signed-off-by: Marek Vasut <marex@denx.de> > > I'm always a bit in 2 minds about trivial-devices as it doesn't > include a basic power supply. In this case vdd which I'd prefer > to see documented even on such a simple device as this. > Not everyone is going to leave it powered up all the time! > > Still I'm not that fussed. Maybe it's worth allowing vdd-supply in > trivial-devices.yaml? The hardware I have is powered all the time, so I'd be adding completely untested code which is no less useless for me (at least right now). Lets postpone this until there is a need for it, can we ? I addressed all the other comments in 2/2.
On Sun, 19 Nov 2023 19:08:45 +0100 Marek Vasut <marex@denx.de> wrote: > On 11/19/23 16:07, Jonathan Cameron wrote: > > On Sat, 18 Nov 2023 01:06:09 +0100 > > Marek Vasut <marex@denx.de> wrote: > > > >> The ISL76682 is very basic ALS which only supports ALS or IR mode > >> in four ranges, 1k/4k/16k/64k LUX. There is no IRQ support or any > >> other fancy functionality. Document it as trivial device. > >> > >> Acked-by: Conor Dooley <conor.dooley@microchip.com> > >> Signed-off-by: Marek Vasut <marex@denx.de> > > > > I'm always a bit in 2 minds about trivial-devices as it doesn't > > include a basic power supply. In this case vdd which I'd prefer > > to see documented even on such a simple device as this. > > Not everyone is going to leave it powered up all the time! > > > > Still I'm not that fussed. Maybe it's worth allowing vdd-supply in > > trivial-devices.yaml? > > The hardware I have is powered all the time, so I'd be adding completely > untested code which is no less useless for me (at least right now). Lets > postpone this until there is a need for it, can we ? It's untested but trivial code (one call and an error code check) but fair enough. Previous experience says that we'll soon see it added... Its probably the most common follow up patch for a new driver. > > I addressed all the other comments in 2/2. >
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index c3190f2a168a2..27164e9219276 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -179,6 +179,8 @@ properties: - isil,isl29030 # Intersil ISL68137 Digital Output Configurable PWM Controller - isil,isl68137 + # Intersil ISL76682 Ambient Light Sensor + - isil,isl76682 # Linear Technology LTC2488 - lineartechnology,ltc2488 # 5 Bit Programmable, Pulse-Width Modulator