| Message ID | 20231129070432.1437-1-petre.rodan@subdimension.ro (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v5,1/2] dt-bindings: iio: pressure: add honeywell,hsc030 | expand |
On 29/11/2023 08:04, Petre Rodan wrote: > Adds binding for digital Honeywell TruStability HSC and SSC series > pressure and temperature sensors. > Communication is one way. The sensor only requires 4 bytes worth of > clock pulses on both i2c and spi in order to push the data out. > The i2c address is hardcoded and depends on the part number. > There is no additional GPIO control. Your threading is broken (not existing) since v4, making it difficult to apply the patchset. Please fix it when sending v6. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
hi, On Wed, Nov 29, 2023 at 09:04:17AM +0100, Krzysztof Kozlowski wrote: > On 29/11/2023 08:04, Petre Rodan wrote: > > Adds binding for digital Honeywell TruStability HSC and SSC series > > pressure and temperature sensors. > > Communication is one way. The sensor only requires 4 bytes worth of > > clock pulses on both i2c and spi in order to push the data out. > > The i2c address is hardcoded and depends on the part number. > > There is no additional GPIO control. > > Your threading is broken (not existing) since v4, making it difficult to > apply the patchset. Please fix it when sending v6. I'm confused. you mean the lack of 'In-Reply-To' and 'References' headers in the emails `git send-email` is generating? I've added them for v2, but was told that was a mistake [1] [1] https://lore.kernel.org/lkml/20231125191915.7f1f2dc4@jic23-huawei/ I'm probably misunderstanding something. also, I hope v5 is flawless enough. best regards, peter > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Best regards, > Krzysztof >
On 29/11/2023 09:44, Petre Rodan wrote: > > hi, > > On Wed, Nov 29, 2023 at 09:04:17AM +0100, Krzysztof Kozlowski wrote: >> On 29/11/2023 08:04, Petre Rodan wrote: >>> Adds binding for digital Honeywell TruStability HSC and SSC series >>> pressure and temperature sensors. >>> Communication is one way. The sensor only requires 4 bytes worth of >>> clock pulses on both i2c and spi in order to push the data out. >>> The i2c address is hardcoded and depends on the part number. >>> There is no additional GPIO control. >> >> Your threading is broken (not existing) since v4, making it difficult to >> apply the patchset. Please fix it when sending v6. > > I'm confused. > > you mean the lack of 'In-Reply-To' and 'References' headers in the emails > `git send-email` is generating? > I've added them for v2, but was told that was a mistake [1] > > [1] https://lore.kernel.org/lkml/20231125191915.7f1f2dc4@jic23-huawei/ > > I'm probably misunderstanding something. > also, I hope v5 is flawless enough. No, v5 is still wrong. Patchset should be threaded. Open lore.kernel.org and look how patchsets are organized and how your patchset is done. It is as simple as: git format-patch -v6 -2 scripts/get_maintainers.pl git send-email v6* (I combine the last two steps, so I don't even bother with script/maintainers: https://github.com/krzk/tools/blob/master/linux/.bash_aliases_linux#L91 ) But actually you should use b4, which also does this job correctly for you. Best regards, Krzysztof
On Wed, Nov 29, 2023 at 09:47:57AM +0100, Krzysztof Kozlowski wrote: > On 29/11/2023 09:44, Petre Rodan wrote: > > > > hi, > > > > On Wed, Nov 29, 2023 at 09:04:17AM +0100, Krzysztof Kozlowski wrote: > >> On 29/11/2023 08:04, Petre Rodan wrote: > >>> Adds binding for digital Honeywell TruStability HSC and SSC series > >>> pressure and temperature sensors. > >>> Communication is one way. The sensor only requires 4 bytes worth of > >>> clock pulses on both i2c and spi in order to push the data out. > >>> The i2c address is hardcoded and depends on the part number. > >>> There is no additional GPIO control. > >> > >> Your threading is broken (not existing) since v4, making it difficult to > >> apply the patchset. Please fix it when sending v6. > > > > I'm confused. > > > > you mean the lack of 'In-Reply-To' and 'References' headers in the emails > > `git send-email` is generating? > > I've added them for v2, but was told that was a mistake [1] > > > > [1] https://lore.kernel.org/lkml/20231125191915.7f1f2dc4@jic23-huawei/ The instructions there were don't thread v2 to v1. Here, we're talking about threading within this version. > > > > I'm probably misunderstanding something. > > also, I hope v5 is flawless enough. > > No, v5 is still wrong. Patchset should be threaded. Open lore.kernel.org > and look how patchsets are organized and how your patchset is done. > > It is as simple as: > git format-patch -v6 -2 > scripts/get_maintainers.pl > git send-email v6* By default, git does the right thing, but the '--thread' option could be changed in your config. Note both commands can do the threading. If you are mucking with 'In-Reply-To' then it is probably wrong. Rob
diff --git a/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml new file mode 100644 index 000000000000..65a24ed67b3c --- /dev/null +++ b/Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml @@ -0,0 +1,142 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/iio/pressure/honeywell,hsc030pa.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Honeywell TruStability HSC and SSC pressure sensor series + +description: | + support for Honeywell TruStability HSC and SSC digital pressure sensor + series. + + These sensors have either an I2C, an SPI or an analog interface. Only the + digital versions are supported by this driver. + + There are 118 models with different pressure ranges available in each family. + The vendor calls them "HSC series" and "SSC series". All of them have an + identical programming model but differ in pressure range, unit and transfer + function. + + To support different models one needs to specify the pressure range as well + as the transfer function. Pressure range can either be provided via + pressure-triplet (directly extracted from the part number) or in case it's + a custom chip via numerical range limits converted to pascals. + + The transfer function defines the ranges of raw conversion values delivered + by the sensor. pmin-pascal and pmax-pascal corespond to the minimum and + maximum pressure that can be measured. + + Please note that in case of an SPI-based sensor, the clock signal should not + exceed 800kHz and the MOSI signal is not required. + + Specifications about the devices can be found at: + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf + https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf + +maintainers: + - Petre Rodan <petre.rodan@subdimension.ro> + +properties: + compatible: + const: honeywell,hsc030pa + + reg: + maxItems: 1 + + honeywell,transfer-function: + description: | + Transfer function which defines the range of valid values delivered by + the sensor. + 0 - A, 10% to 90% of 2^14 + 1 - B, 5% to 95% of 2^14 + 2 - C, 5% to 85% of 2^14 + 3 - F, 4% to 94% of 2^14 + enum: [0, 1, 2, 3] + $ref: /schemas/types.yaml#/definitions/uint32 + + honeywell,pressure-triplet: + description: | + Case-sensitive five character string that defines pressure range, unit + and type as part of the device nomenclature. In the unlikely case of a + custom chip, set to "NA" and provide pmin-pascal and pmax-pascal. + enum: [001BA, 1.6BA, 2.5BA, 004BA, 006BA, 010BA, 1.6MD, 2.5MD, 004MD, + 006MD, 010MD, 016MD, 025MD, 040MD, 060MD, 100MD, 160MD, 250MD, + 400MD, 600MD, 001BD, 1.6BD, 2.5BD, 004BD, 2.5MG, 004MG, 006MG, + 010MG, 016MG, 025MG, 040MG, 060MG, 100MG, 160MG, 250MG, 400MG, + 600MG, 001BG, 1.6BG, 2.5BG, 004BG, 006BG, 010BG, 100KA, 160KA, + 250KA, 400KA, 600KA, 001GA, 160LD, 250LD, 400LD, 600LD, 001KD, + 1.6KD, 2.5KD, 004KD, 006KD, 010KD, 016KD, 025KD, 040KD, 060KD, + 100KD, 160KD, 250KD, 400KD, 250LG, 400LG, 600LG, 001KG, 1.6KG, + 2.5KG, 004KG, 006KG, 010KG, 016KG, 025KG, 040KG, 060KG, 100KG, + 160KG, 250KG, 400KG, 600KG, 001GG, 015PA, 030PA, 060PA, 100PA, + 150PA, 0.5ND, 001ND, 002ND, 004ND, 005ND, 010ND, 020ND, 030ND, + 001PD, 005PD, 015PD, 030PD, 060PD, 001NG, 002NG, 004NG, 005NG, + 010NG, 020NG, 030NG, 001PG, 005PG, 015PG, 030PG, 060PG, 100PG, + 150PG, NA] + $ref: /schemas/types.yaml#/definitions/string + + honeywell,pmin-pascal: + description: | + Minimum pressure value the sensor can measure in pascal. + To be specified only if honeywell,pressure-triplet is set to "NA". + + honeywell,pmax-pascal: + description: | + Maximum pressure value the sensor can measure in pascal. + To be specified only if honeywell,pressure-triplet is set to "NA". + + vdd-supply: + description: + Provide VDD power to the sensor (either 3.3V or 5V depending on the chip) + + spi-max-frequency: + maximum: 800000 + +required: + - compatible + - reg + - honeywell,transfer-function + - honeywell,pressure-triplet + +additionalProperties: false + +dependentSchemas: + honeywell,pmin-pascal: + properties: + honeywell,pressure-triplet: + const: NA + honeywell,pmax-pascal: + properties: + honeywell,pressure-triplet: + const: NA + +examples: + - | + i2c { + #address-cells = <1>; + #size-cells = <0>; + + pressure@28 { + compatible = "honeywell,hsc030pa"; + reg = <0x28>; + honeywell,transfer-function = <0>; + honeywell,pressure-triplet = "030PA"; + }; + }; + - | + spi { + #address-cells = <1>; + #size-cells = <0>; + + pressure@0 { + compatible = "honeywell,hsc030pa"; + reg = <0>; + spi-max-frequency = <800000>; + honeywell,transfer-function = <0>; + honeywell,pressure-triplet = "NA"; + honeywell,pmin-pascal = <0>; + honeywell,pmax-pascal = <200000>; + }; + }; +...
Adds binding for digital Honeywell TruStability HSC and SSC series pressure and temperature sensors. Communication is one way. The sensor only requires 4 bytes worth of clock pulses on both i2c and spi in order to push the data out. The i2c address is hardcoded and depends on the part number. There is no additional GPIO control. Datasheet: https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-hsc-series/documents/sps-siot-trustability-hsc-series-high-accuracy-board-mount-pressure-sensors-50099148-a-en-ciid-151133.pdf [HSC] Datasheet: https://prod-edam.honeywell.com/content/dam/honeywell-edam/sps/siot/en-us/products/sensors/pressure-sensors/board-mount-pressure-sensors/trustability-ssc-series/documents/sps-siot-trustability-ssc-series-standard-accuracy-board-mount-pressure-sensors-50099533-a-en-ciid-151134.pdf [SSC] Signed-off-by: Petre Rodan <petre.rodan@subdimension.ro> --- V2: - fix yaml struct - cleanup based on Krzysztof's review V3: - rename range_str -> honeywell,pressure-triplet to define the string containing the pressure range, measurement unit and type - honeywell,pmax-pascal becomes uint32 V4: - added enum to honeywell,transfer-function V5: - removed pmin-pascal, pmax-pascal $ref - added pmin-pascal, pmax-pascal constraints --- .../iio/pressure/honeywell,hsc030pa.yaml | 142 ++++++++++++++++++ 1 file changed, 142 insertions(+) create mode 100644 Documentation/devicetree/bindings/iio/pressure/honeywell,hsc030pa.yaml