From patchwork Tue Dec 5 17:06:41 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nuno Sa via B4 Relay X-Patchwork-Id: 13480479 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 42BA46928B for ; Tue, 5 Dec 2023 17:06:46 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="fWCauffX" Received: by smtp.kernel.org (Postfix) with ESMTPS id D6B03C433C8; Tue, 5 Dec 2023 17:06:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1701796005; bh=sjUP64TzXG9MuFbyLhkat8sU5mUfln6N25I4AI6lZW0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=fWCauffXAr1RSJQrWGF6ToyLzYPNsA35GhEGLDUxj2GR7J9x1frONNv6Rp71T4Aag EEcRggcOnZDMReTdShPqVmuP9CYODD1XvOow9DD3n1mcdmC2gvFrpmh5Nd4wjdht6x /8N/7eNaNbAyIAJtiwuBhUunqYTPbxeeHGPLyNQnPW/Vxa3nuJ6xu7oYoKn66OOY8l 31VkB5eCrvUBBG1yXqm6/uSyqAh0+6yBXkfHXIEOLN/sQXjVwdI+h3JKKdIUuiRfb6 HQU3ojW+UJfZrVD437+0bUbUKGT6oGG0mhc12XP3bOTF8guzKxkXlKx5HPjInnxDlA XLnmSq3240H5Q== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBC7EC10DCE; Tue, 5 Dec 2023 17:06:45 +0000 (UTC) From: Nuno Sa via B4 Relay Date: Tue, 05 Dec 2023 18:06:41 +0100 Subject: [PATCH 1/8] iio: adc: ad9467: fix reset gpio handling Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20231205-iio-backend-prep-v1-1-7c9bc18d612b@analog.com> References: <20231205-iio-backend-prep-v1-0-7c9bc18d612b@analog.com> In-Reply-To: <20231205-iio-backend-prep-v1-0-7c9bc18d612b@analog.com> To: linux-iio@vger.kernel.org Cc: Michael Hennerich , Jonathan Cameron , Lars-Peter Clausen X-Mailer: b4 0.12.3 X-Developer-Signature: v=1; a=ed25519-sha256; t=1701796004; l=2385; i=nuno.sa@analog.com; s=20231116; h=from:subject:message-id; bh=jSRdyxiCoJT95OyuOsgiz/xzqOuZXfUDVd39nEe6GjE=; b=ViXcMuziGM9kkRx+zo9zzYxxHcv50HWzMMyeuuuNIjTMWFTsN84xbPWzgXPFBHN2VtjwGpT0j C1dExWSO4JXDq/HRf7tH8vhFiwIj70c4SGMyyHXCE58QF418LF4/IPu X-Developer-Key: i=nuno.sa@analog.com; a=ed25519; pk=3NQwYA013OUYZsmDFBf8rmyyr5iQlxV/9H4/Df83o1E= X-Endpoint-Received: by B4 Relay for nuno.sa@analog.com/20231116 with auth_id=100 X-Original-From: Nuno Sa Reply-To: From: Nuno Sa The reset gpio was being requested with GPIOD_OUT_LOW which means, not asserted. Then it was being asserted but never de-asserted which means the devices was left in reset. Fix it by de-asserting the gpio. While at it, moved the handling to it's own function and dropped 'reset_gpio' from the 'struct ad9467_state' as we only need it during probe. On top of that, refactored things so that we now request the gpio asserted (i.e in reset) and then de-assert it. Also note that we now use gpiod_set_value_cansleep() instead of gpiod_direction_output() as we already request the pin as output. Fixes: ad6797120238 ("iio: adc: ad9467: add support AD9467 ADC") Signed-off-by: Nuno Sa Reviewed-by: David Lechner --- drivers/iio/adc/ad9467.c | 33 ++++++++++++++++++++------------- 1 file changed, 20 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/ad9467.c b/drivers/iio/adc/ad9467.c index 39eccc28debe..5ecf486bf5d1 100644 --- a/drivers/iio/adc/ad9467.c +++ b/drivers/iio/adc/ad9467.c @@ -121,7 +121,6 @@ struct ad9467_state { unsigned int output_mode; struct gpio_desc *pwrdown_gpio; - struct gpio_desc *reset_gpio; }; static int ad9467_spi_read(struct spi_device *spi, unsigned int reg) @@ -378,6 +377,23 @@ static int ad9467_preenable_setup(struct adi_axi_adc_conv *conv) return ad9467_outputmode_set(st->spi, st->output_mode); } +static int ad9467_reset(struct device *dev) +{ + struct gpio_desc *gpio; + + gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH); + if (IS_ERR(gpio)) + return PTR_ERR(gpio); + if (!gpio) + return 0; + + fsleep(1); + gpiod_set_value_cansleep(gpio, 0); + fsleep(10 * USEC_PER_MSEC); + + return 0; +} + static int ad9467_probe(struct spi_device *spi) { const struct ad9467_chip_info *info; @@ -408,18 +424,9 @@ static int ad9467_probe(struct spi_device *spi) if (IS_ERR(st->pwrdown_gpio)) return PTR_ERR(st->pwrdown_gpio); - st->reset_gpio = devm_gpiod_get_optional(&spi->dev, "reset", - GPIOD_OUT_LOW); - if (IS_ERR(st->reset_gpio)) - return PTR_ERR(st->reset_gpio); - - if (st->reset_gpio) { - udelay(1); - ret = gpiod_direction_output(st->reset_gpio, 1); - if (ret) - return ret; - mdelay(10); - } + ret = ad9467_reset(&spi->dev); + if (ret) + return ret; conv->chip_info = &info->axi_adc_info;