| Message ID | 20231208021715.32450-1-jiapeng.chong@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: light: isl76682: remove unreachable code | expand |
On Fri, 8 Dec 2023 10:17:15 +0800 Jiapeng Chong <jiapeng.chong@linux.alibaba.com> wrote: > The function isl76682_read_raw cannot execute return -EINVAL up to 145 > lines, delete the invalid code. > > drivers/iio/light/isl76682.c:145 isl76682_read_raw() warn: ignoring unreachable code. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7698 > Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> Applied. Thanks, Jonathan > --- > drivers/iio/light/isl76682.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/light/isl76682.c b/drivers/iio/light/isl76682.c > index 0a7c3b09c3c0..cf6ddee44ffc 100644 > --- a/drivers/iio/light/isl76682.c > +++ b/drivers/iio/light/isl76682.c > @@ -142,7 +142,6 @@ static int isl76682_read_raw(struct iio_dev *indio_dev, > default: > return -EINVAL; > } > - return -EINVAL; > case IIO_CHAN_INFO_SCALE: > for (i = 0; i < ARRAY_SIZE(isl76682_range_table); i++) { > if (chip->range != isl76682_range_table[i].range)
diff --git a/drivers/iio/light/isl76682.c b/drivers/iio/light/isl76682.c index 0a7c3b09c3c0..cf6ddee44ffc 100644 --- a/drivers/iio/light/isl76682.c +++ b/drivers/iio/light/isl76682.c @@ -142,7 +142,6 @@ static int isl76682_read_raw(struct iio_dev *indio_dev, default: return -EINVAL; } - return -EINVAL; case IIO_CHAN_INFO_SCALE: for (i = 0; i < ARRAY_SIZE(isl76682_range_table); i++) { if (chip->range != isl76682_range_table[i].range)
The function isl76682_read_raw cannot execute return -EINVAL up to 145 lines, delete the invalid code. drivers/iio/light/isl76682.c:145 isl76682_read_raw() warn: ignoring unreachable code. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=7698 Signed-off-by: Jiapeng Chong <jiapeng.chong@linux.alibaba.com> --- drivers/iio/light/isl76682.c | 1 - 1 file changed, 1 deletion(-)