| Message ID | 20240510141836.1624009-1-adureghello@baylibre.org (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] dt-bindings: iio: dac: add ad35xxr single output variants | expand |
On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello <adureghello@baylibre.com> wrote: > > From: Angelo Dureghello <adureghello@baylibre.com> > > Add support for ad3541r and ad3551r single output variants. > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> > --- > .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > index 8265d709094d..17442cdfbe27 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml It would be nice to also add the datasheet links in the description. > @@ -19,7 +19,9 @@ description: | > properties: > compatible: > enum: > + - adi,ad3541r > - adi,ad3542r > + - adi,ad3551r > - adi,ad3552r > > reg: > @@ -128,7 +130,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3542r > + enum: > + - adi,ad3541r > + - adi,ad3542r > then: > patternProperties: > "^channel@([0-1])$": > @@ -158,7 +162,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3552r > + enum: > + - adi,ad3551r > + - adi,ad3552r > then: > patternProperties: > "^channel@([0-1])$": > -- > 2.45.0.rc1 > > Since these are single channel, it would not hurt to restrict the `reg` property of of the `channel@` nodes to 1.
On Fri, 10 May 2024 16:18:34 +0200 Angelo Dureghello <adureghello@baylibre.com> wrote: > From: Angelo Dureghello <adureghello@baylibre.com> > > Add support for ad3541r and ad3551r single output variants. I'd expect to see constraints on reg for the channel nodes. Am I missing some reason those don't make sense? > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> > --- > .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > index 8265d709094d..17442cdfbe27 100644 > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > @@ -19,7 +19,9 @@ description: | > properties: > compatible: > enum: > + - adi,ad3541r > - adi,ad3542r > + - adi,ad3551r > - adi,ad3552r > > reg: > @@ -128,7 +130,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3542r > + enum: > + - adi,ad3541r > + - adi,ad3542r > then: > patternProperties: > "^channel@([0-1])$": > @@ -158,7 +162,9 @@ allOf: > properties: > compatible: > contains: > - const: adi,ad3552r > + enum: > + - adi,ad3551r > + - adi,ad3552r > then: > patternProperties: > "^channel@([0-1])$":
On Fri, 10 May 2024 10:39:31 -0500 David Lechner <dlechner@baylibre.com> wrote: > On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello > <adureghello@baylibre.com> wrote: > > > > From: Angelo Dureghello <adureghello@baylibre.com> > > > > Add support for ad3541r and ad3551r single output variants. > > > > Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> > > --- > > .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- > > 1 file changed, 8 insertions(+), 2 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > > index 8265d709094d..17442cdfbe27 100644 > > --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > > +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml > > It would be nice to also add the datasheet links in the description. > > > @@ -19,7 +19,9 @@ description: | > > properties: > > compatible: > > enum: > > + - adi,ad3541r > > - adi,ad3542r > > + - adi,ad3551r > > - adi,ad3552r > > > > reg: > > @@ -128,7 +130,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: adi,ad3542r > > + enum: > > + - adi,ad3541r > > + - adi,ad3542r > > then: > > patternProperties: > > "^channel@([0-1])$": > > @@ -158,7 +162,9 @@ allOf: > > properties: > > compatible: > > contains: > > - const: adi,ad3552r > > + enum: > > + - adi,ad3551r > > + - adi,ad3552r > > then: > > patternProperties: > > "^channel@([0-1])$": > > -- > > 2.45.0.rc1 > > > > > > Since these are single channel, it would not hurt to restrict the > `reg` property of of the `channel@` nodes to 1. Ah. I missed David's email because threading goes weird without a cover letter and hence duplicated his comment. Please add a cover letter with a brief description of the series to your v2. Means we get a nice title in patchwork as well! Thanks, Jonathan
Hi, On 11/05/24 6:05 PM, Jonathan Cameron wrote: > On Fri, 10 May 2024 10:39:31 -0500 > David Lechner <dlechner@baylibre.com> wrote: > >> On Fri, May 10, 2024 at 9:19 AM Angelo Dureghello >> <adureghello@baylibre.com> wrote: >>> From: Angelo Dureghello <adureghello@baylibre.com> >>> >>> Add support for ad3541r and ad3551r single output variants. >>> >>> Signed-off-by: Angelo Dureghello <adureghello@baylibre.com> >>> --- >>> .../devicetree/bindings/iio/dac/adi,ad3552r.yaml | 10 ++++++++-- >>> 1 file changed, 8 insertions(+), 2 deletions(-) >>> >>> diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >>> index 8265d709094d..17442cdfbe27 100644 >>> --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >>> +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml >> It would be nice to also add the datasheet links in the description. ack, >>> @@ -19,7 +19,9 @@ description: | >>> properties: >>> compatible: >>> enum: >>> + - adi,ad3541r >>> - adi,ad3542r >>> + - adi,ad3551r >>> - adi,ad3552r >>> >>> reg: >>> @@ -128,7 +130,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: adi,ad3542r >>> + enum: >>> + - adi,ad3541r >>> + - adi,ad3542r >>> then: >>> patternProperties: >>> "^channel@([0-1])$": >>> @@ -158,7 +162,9 @@ allOf: >>> properties: >>> compatible: >>> contains: >>> - const: adi,ad3552r >>> + enum: >>> + - adi,ad3551r >>> + - adi,ad3552r >>> then: >>> patternProperties: >>> "^channel@([0-1])$": >>> -- >>> 2.45.0.rc1 >>> >>> >> Since these are single channel, it would not hurt to restrict the >> `reg` property of of the `channel@` nodes to 1. ack, > Ah. I missed David's email because threading goes weird without a cover letter > and hence duplicated his comment. > Please add a cover letter with a brief description of the series to > your v2. Means we get a nice title in patchwork as well! > > Thanks, > > Jonathan > > Thanks for the feedbacks, will fix all in v2. Regards, angelo
diff --git a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml index 8265d709094d..17442cdfbe27 100644 --- a/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml +++ b/Documentation/devicetree/bindings/iio/dac/adi,ad3552r.yaml @@ -19,7 +19,9 @@ description: | properties: compatible: enum: + - adi,ad3541r - adi,ad3542r + - adi,ad3551r - adi,ad3552r reg: @@ -128,7 +130,9 @@ allOf: properties: compatible: contains: - const: adi,ad3542r + enum: + - adi,ad3541r + - adi,ad3542r then: patternProperties: "^channel@([0-1])$": @@ -158,7 +162,9 @@ allOf: properties: compatible: contains: - const: adi,ad3552r + enum: + - adi,ad3551r + - adi,ad3552r then: patternProperties: "^channel@([0-1])$":