| Message ID | 20240603162122.165943-3-muditsharma.info@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [v2,1/3] dt-bindings: iio: light: ROHM BH1745 | expand |
On 6/3/24 17:21, Mudit Sharma wrote: > Add myself as maintainer for ROHM BH1745 colour sensor driver. > > Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com> > --- > v1->v2: > - No changes > > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6c90161c7bf..945873321fef 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19407,6 +19407,13 @@ S: Supported > F: drivers/power/supply/bd99954-charger.c > F: drivers/power/supply/bd99954-charger.h > > +ROHM BH1745 COLOUR SENSOR > +M: Mudit Sharma <muditsharma.info@gmail.com> > +L: linux-iio@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml > +F: drivers/iio/light/bh1745.c > + > ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER > M: Tomasz Duszynski <tduszyns@gmail.com> > S: Maintained Looks good to me, Reviewed-by: Ivan Orlov <ivan.orlov0322@gmail.com>
On 03/06/2024 18:21, Mudit Sharma wrote: > Add myself as maintainer for ROHM BH1745 colour sensor driver. > > Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com> > --- > v1->v2: > - No changes > > MAINTAINERS | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index d6c90161c7bf..945873321fef 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -19407,6 +19407,13 @@ S: Supported > F: drivers/power/supply/bd99954-charger.c > F: drivers/power/supply/bd99954-charger.h > > +ROHM BH1745 COLOUR SENSOR > +M: Mudit Sharma <muditsharma.info@gmail.com> > +L: linux-iio@vger.kernel.org > +S: Maintained > +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml > +F: drivers/iio/light/bh1745.c > + > ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER > M: Tomasz Duszynski <tduszyns@gmail.com> > S: Maintained Hi Mudit, is there any special reason to have a separate patch for this? The addition to MAINTANERS for new drives is usually included in the patch that provides the driver itself. Best regards, Javier Carrasco
On 03/06/2024 23:37, Javier Carrasco wrote: > On 03/06/2024 18:21, Mudit Sharma wrote: >> Add myself as maintainer for ROHM BH1745 colour sensor driver. >> >> Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com> >> --- >> v1->v2: >> - No changes >> >> MAINTAINERS | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/MAINTAINERS b/MAINTAINERS >> index d6c90161c7bf..945873321fef 100644 >> --- a/MAINTAINERS >> +++ b/MAINTAINERS >> @@ -19407,6 +19407,13 @@ S: Supported >> F: drivers/power/supply/bd99954-charger.c >> F: drivers/power/supply/bd99954-charger.h >> >> +ROHM BH1745 COLOUR SENSOR >> +M: Mudit Sharma <muditsharma.info@gmail.com> >> +L: linux-iio@vger.kernel.org >> +S: Maintained >> +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml >> +F: drivers/iio/light/bh1745.c >> + >> ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER >> M: Tomasz Duszynski <tduszyns@gmail.com> >> S: Maintained > > Hi Mudit, > > is there any special reason to have a separate patch for this? The > addition to MAINTANERS for new drives is usually included in the patch > that provides the driver itself. > > Best regards, > Javier Carrasco Hi Javier, Adding this in a separate commit was just a pattern I notices with some other drivers, for instance 3b4e0e9. If necessary and/or considered good practice, I can squash this in the patch that brings in the driver. Best regards, Mudit Sharma
On 04/06/2024 12:44, Mudit Sharma wrote: > On 03/06/2024 23:37, Javier Carrasco wrote: >> On 03/06/2024 18:21, Mudit Sharma wrote: >>> Add myself as maintainer for ROHM BH1745 colour sensor driver. >>> >>> Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com> >>> --- >>> v1->v2: >>> - No changes >>> >>> MAINTAINERS | 7 +++++++ >>> 1 file changed, 7 insertions(+) >>> >>> diff --git a/MAINTAINERS b/MAINTAINERS >>> index d6c90161c7bf..945873321fef 100644 >>> --- a/MAINTAINERS >>> +++ b/MAINTAINERS >>> @@ -19407,6 +19407,13 @@ S: Supported >>> F: drivers/power/supply/bd99954-charger.c >>> F: drivers/power/supply/bd99954-charger.h >>> +ROHM BH1745 COLOUR SENSOR >>> +M: Mudit Sharma <muditsharma.info@gmail.com> >>> +L: linux-iio@vger.kernel.org >>> +S: Maintained >>> +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml >>> +F: drivers/iio/light/bh1745.c >>> + >>> ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER >>> M: Tomasz Duszynski <tduszyns@gmail.com> >>> S: Maintained >> >> Hi Mudit, >> >> is there any special reason to have a separate patch for this? The >> addition to MAINTANERS for new drives is usually included in the patch >> that provides the driver itself. >> >> Best regards, >> Javier Carrasco > > Hi Javier, > > Adding this in a separate commit was just a pattern I notices with some > other drivers, for instance 3b4e0e9. > > If necessary and/or considered good practice, I can squash this in the > patch that brings in the driver. > > Best regards, > Mudit Sharma Although there might be some cases where it was added separately, it is much more common that it is added to the patch that provides the driver. Some perfectionists even include the entry in the dt-bindings patch, and then add the link to the driver code in the driver patch. I believe that a simple squash would be ok, though. Best regards, Javier Carrasco
On 6/4/24 15:53, Javier Carrasco wrote: > On 04/06/2024 12:44, Mudit Sharma wrote: >> On 03/06/2024 23:37, Javier Carrasco wrote: >>> On 03/06/2024 18:21, Mudit Sharma wrote: >>>> Add myself as maintainer for ROHM BH1745 colour sensor driver. >>>> >>> >>> is there any special reason to have a separate patch for this? The >>> addition to MAINTANERS for new drives is usually included in the patch >>> that provides the driver itself. >> >> Adding this in a separate commit was just a pattern I notices with some >> other drivers, for instance 3b4e0e9. >> >> If necessary and/or considered good practice, I can squash this in the >> patch that brings in the driver. > > Although there might be some cases where it was added separately, it is > much more common that it is added to the patch that provides the driver. > Some perfectionists even include the entry in the dt-bindings patch, and > then add the link to the driver code in the driver patch. I believe that > a simple squash would be ok, though. I believe there is a notable case where having MAINTAINERS updates as a separate patch makes sense. When one creates drivers for a device which touches multiple subsystems, typically a set of MFD drivers. This is usually done as a set of subsystem specific patches, each adding subsystem specific file(s). In this case adding MAINTAINER info separately for each sub-driver will create unnecessary churn in the MAINTAINERS file - which I believe is already now a major source of merge conflicts. I am not sure of this is a reason to have MAINTAINERS updates in own patch though. Furthermore, I've been instructed by Rob (AFAIR) to omit the dt-binding files from the MAINTAINERS because the maintainer information is already contained in the bindings itself. Yours, -- Matti
On 04/06/2024 15:38, Matti Vaittinen wrote: > On 6/4/24 15:53, Javier Carrasco wrote: >> On 04/06/2024 12:44, Mudit Sharma wrote: >>> On 03/06/2024 23:37, Javier Carrasco wrote: >>>> On 03/06/2024 18:21, Mudit Sharma wrote: >>>>> Add myself as maintainer for ROHM BH1745 colour sensor driver. >>>>> >>>> >>>> is there any special reason to have a separate patch for this? The >>>> addition to MAINTANERS for new drives is usually included in the patch >>>> that provides the driver itself. >>> >>> Adding this in a separate commit was just a pattern I notices with some >>> other drivers, for instance 3b4e0e9. >>> >>> If necessary and/or considered good practice, I can squash this in the >>> patch that brings in the driver. >> >> Although there might be some cases where it was added separately, it is >> much more common that it is added to the patch that provides the driver. >> Some perfectionists even include the entry in the dt-bindings patch, and >> then add the link to the driver code in the driver patch. I believe that >> a simple squash would be ok, though. > > I believe there is a notable case where having MAINTAINERS updates as a > separate patch makes sense. When one creates drivers for a device which > touches multiple subsystems, typically a set of MFD drivers. This is > usually done as a set of subsystem specific patches, each adding > subsystem specific file(s). In this case adding MAINTAINER info > separately for each sub-driver will create unnecessary churn in the > MAINTAINERS file - which I believe is already now a major source of > merge conflicts. I am not sure of this is a reason to have MAINTAINERS > updates in own patch though. > > Furthermore, I've been instructed by Rob (AFAIR) to omit the dt-binding > files from the MAINTAINERS because the maintainer information is already > contained in the bindings itself. > > Yours, > -- Matti > Good point, in that case it would make more sense. But this driver only apllies to iio, and there won't be such conflicts. But thank you for that clarification. By the way, I think you have some issue with your email configuration (no line wrapping). Best regards, Javier Carrasco
diff --git a/MAINTAINERS b/MAINTAINERS index d6c90161c7bf..945873321fef 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -19407,6 +19407,13 @@ S: Supported F: drivers/power/supply/bd99954-charger.c F: drivers/power/supply/bd99954-charger.h +ROHM BH1745 COLOUR SENSOR +M: Mudit Sharma <muditsharma.info@gmail.com> +L: linux-iio@vger.kernel.org +S: Maintained +F: Documentation/devicetree/bindings/iio/light/rohm,bh1745.yaml +F: drivers/iio/light/bh1745.c + ROHM BH1750 AMBIENT LIGHT SENSOR DRIVER M: Tomasz Duszynski <tduszyns@gmail.com> S: Maintained
Add myself as maintainer for ROHM BH1745 colour sensor driver. Signed-off-by: Mudit Sharma <muditsharma.info@gmail.com> --- v1->v2: - No changes MAINTAINERS | 7 +++++++ 1 file changed, 7 insertions(+)