| Message ID | 20240726-ad7380-add-single-ended-chips-v1-1-2d628b60ccd1@baylibre.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | ad7380: add support for single-ended parts | expand |
On 26/07/2024 17:20, Julien Stephan wrote: > Adding ad7386/7/8 single-ended compatible parts, and the corresponding > ad7386-4/7-4/8-4 4 channels. > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml > index 899b777017ce..bd19abb867d9 100644 > --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml > +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml > @@ -15,10 +15,17 @@ description: | > * https://www.analog.com/en/products/ad7381.html > * https://www.analog.com/en/products/ad7383.html > * https://www.analog.com/en/products/ad7384.html > + * https://www.analog.com/en/products/ad7386.html > + * https://www.analog.com/en/products/ad7387.html > + * https://www.analog.com/en/products/ad7388.html > * https://www.analog.com/en/products/ad7380-4.html > * https://www.analog.com/en/products/ad7381-4.html > * https://www.analog.com/en/products/ad7383-4.html > * https://www.analog.com/en/products/ad7384-4.html > + * https://www.analog.com/en/products/ad7386-4.html > + * https://www.analog.com/en/products/ad7387-4.html > + * https://www.analog.com/en/products/ad7388-4.html > + > > $ref: /schemas/spi/spi-peripheral-props.yaml# > > @@ -29,10 +36,16 @@ properties: > - adi,ad7381 > - adi,ad7383 > - adi,ad7384 > + - adi,ad7386 > + - adi,ad7387 > + - adi,ad7388 > - adi,ad7380-4 > - adi,ad7381-4 > - adi,ad7383-4 > - adi,ad7384-4 > + - adi,ad7386-4 Lists are ordered alphabetically. Do not add new entries to the end of the lists (like in your commit "add support for ad738x-4 4") because that is conflict prone. Best regards, Krzysztof
On 26/07/2024 17:20, Julien Stephan wrote: > Adding ad7386/7/8 single-ended compatible parts, and the corresponding > ad7386-4/7-4/8-4 4 channels. > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml | 13 +++++++++++++ FWIW, since ordering is already broken: Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml index 899b777017ce..bd19abb867d9 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml @@ -15,10 +15,17 @@ description: | * https://www.analog.com/en/products/ad7381.html * https://www.analog.com/en/products/ad7383.html * https://www.analog.com/en/products/ad7384.html + * https://www.analog.com/en/products/ad7386.html + * https://www.analog.com/en/products/ad7387.html + * https://www.analog.com/en/products/ad7388.html * https://www.analog.com/en/products/ad7380-4.html * https://www.analog.com/en/products/ad7381-4.html * https://www.analog.com/en/products/ad7383-4.html * https://www.analog.com/en/products/ad7384-4.html + * https://www.analog.com/en/products/ad7386-4.html + * https://www.analog.com/en/products/ad7387-4.html + * https://www.analog.com/en/products/ad7388-4.html + $ref: /schemas/spi/spi-peripheral-props.yaml# @@ -29,10 +36,16 @@ properties: - adi,ad7381 - adi,ad7383 - adi,ad7384 + - adi,ad7386 + - adi,ad7387 + - adi,ad7388 - adi,ad7380-4 - adi,ad7381-4 - adi,ad7383-4 - adi,ad7384-4 + - adi,ad7386-4 + - adi,ad7387-4 + - adi,ad7388-4 reg: maxItems: 1
Adding ad7386/7/8 single-ended compatible parts, and the corresponding ad7386-4/7-4/8-4 4 channels. Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- Documentation/devicetree/bindings/iio/adc/adi,ad7380.yaml | 13 +++++++++++++ 1 file changed, 13 insertions(+)