| Message ID | 20241016003919.113306-1-yang.lee@linux.alibaba.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | [-next] iio: imu: bmi270: Remove duplicated include in bmi270_i2c.c | expand |
On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote: > The header files linux/module.h is included twice in bmi270_i2c.c, > so one inclusion of each can be removed. > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363 > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > --- > drivers/iio/imu/bmi270/bmi270_i2c.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c > index e9025d22d5cc..71cc271cdf30 100644 > --- a/drivers/iio/imu/bmi270/bmi270_i2c.c > +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c > @@ -3,7 +3,6 @@ > #include <linux/module.h> > #include <linux/i2c.h> > #include <linux/iio/iio.h> > -#include <linux/module.h> > #include <linux/mod_devicetable.h> > #include <linux/regmap.h> Good catch! Minor nit: Should remove the top module.h include instead to keep alphabetical ordering.
On Tue, 15 Oct 2024 22:31:57 -0400 Alex Lanzano <lanzano.alex@gmail.com> wrote: > On Wed, Oct 16, 2024 at 08:39:19AM +0800, Yang Li wrote: > > The header files linux/module.h is included twice in bmi270_i2c.c, > > so one inclusion of each can be removed. > > > > Reported-by: Abaci Robot <abaci@linux.alibaba.com> > > Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363 > > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> > > --- > > drivers/iio/imu/bmi270/bmi270_i2c.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c > > index e9025d22d5cc..71cc271cdf30 100644 > > --- a/drivers/iio/imu/bmi270/bmi270_i2c.c > > +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c > > @@ -3,7 +3,6 @@ > > #include <linux/module.h> > > #include <linux/i2c.h> > > #include <linux/iio/iio.h> > > -#include <linux/module.h> > > #include <linux/mod_devicetable.h> > > #include <linux/regmap.h> > > Good catch! > > Minor nit: Should remove the top module.h include instead to keep > alphabetical ordering. > Given I messed up the pull request anyway, I've snuck this one is as an obviously fine last minute tidy up. With the other entry removed as suggested.
diff --git a/drivers/iio/imu/bmi270/bmi270_i2c.c b/drivers/iio/imu/bmi270/bmi270_i2c.c index e9025d22d5cc..71cc271cdf30 100644 --- a/drivers/iio/imu/bmi270/bmi270_i2c.c +++ b/drivers/iio/imu/bmi270/bmi270_i2c.c @@ -3,7 +3,6 @@ #include <linux/module.h> #include <linux/i2c.h> #include <linux/iio/iio.h> -#include <linux/module.h> #include <linux/mod_devicetable.h> #include <linux/regmap.h>
The header files linux/module.h is included twice in bmi270_i2c.c, so one inclusion of each can be removed. Reported-by: Abaci Robot <abaci@linux.alibaba.com> Closes: https://bugzilla.openanolis.cn/show_bug.cgi?id=11363 Signed-off-by: Yang Li <yang.lee@linux.alibaba.com> --- drivers/iio/imu/bmi270/bmi270_i2c.c | 1 - 1 file changed, 1 deletion(-)