diff mbox series

[v3,3/6] dt-bindings: iio: imu: bmi270: Add Bosch BMI260

Message ID 20241020220011.212395-4-justin@justinweiss.com (mailing list archive)
State Changes Requested
Headers show
Series Add i2c driver for Bosch BMI260 IMU | expand

Commit Message

Justin Weiss Oct. 20, 2024, 10 p.m. UTC 
Add compatible ID for Bosch BMI260 to BMI270 documentation.

Signed-off-by: Justin Weiss <justin@justinweiss.com>
---
 Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

Comments

Krzysztof Kozlowski Oct. 21, 2024, 7:38 a.m. UTC | #1 
On Sun, Oct 20, 2024 at 03:00:07PM -0700, Justin Weiss wrote:
> Add compatible ID for Bosch BMI260 to BMI270 documentation.

This we see from the diff. Say something about the hardware, are they
compatible? No? What are the differences?

Best regards,
Krzysztof
Justin Weiss Oct. 22, 2024, 3:51 p.m. UTC | #2 
Krzysztof Kozlowski <krzk@kernel.org> writes:

> On Sun, Oct 20, 2024 at 03:00:07PM -0700, Justin Weiss wrote:
>> Add compatible ID for Bosch BMI260 to BMI270 documentation.
>
> This we see from the diff. Say something about the hardware, are they
> compatible? No? What are the differences?

Got it, I'll update the commit message.

The bmi260 has nearly identical register maps and capabilities as the
bmi270, but the devices have different chip IDs and require different
initialization firmware.

Thanks,
Justin

> Best regards,
> Krzysztof
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
index 792d1483af3c..7b0cde1c9b0a 100644
--- a/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
+++ b/Documentation/devicetree/bindings/iio/imu/bosch,bmi270.yaml
@@ -18,7 +18,9 @@  description: |
 
 properties:
   compatible:
-    const: bosch,bmi270
+    enum:
+      - bosch,bmi260
+      - bosch,bmi270
 
   reg:
     maxItems: 1