From patchwork Thu Oct 24 09:11:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Julien Stephan X-Patchwork-Id: 13848579 Received: from mail-wm1-f52.google.com (mail-wm1-f52.google.com [209.85.128.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EC9FF1BDA95 for ; Thu, 24 Oct 2024 09:12:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.52 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729761178; cv=none; b=eVqJ63QV5twxOonVSJ8vpscu46Kf89dgM/2s+GB4rUU2CB0rVtrdeBIAlMMUdaXE26XIaJJMWD0E8pYyuGrmsLSCyqrDg4v/oLauw2TNE7W2QqW+Fg416JA81KNfzMJgHD/GPS0HV/DjrtthBnd9DF5cPVSZO8rq8Ya/5js4o78= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1729761178; c=relaxed/simple; bh=gxT5UJtPsva0rf/TD2YMcs8UCCD2ZDF5U8pMvCjVzqI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=IpYNcCvw2NM3Ci1ADnU+zHAd1ocu2rVHaGKSzfZLkNszAJsCN+Fa6kh0G6JXhBit92INLjHtGXyJvA8iPN9e85cg6PyNRRX+k0t/cVBdYKNT9Z2bKqNETBR18YYNIDaqyBZcXenySToGmZY3eGznT4L+1nqjZuR6USHjmnl35mk= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com; spf=pass smtp.mailfrom=baylibre.com; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b=vO4ZMXMP; arc=none smtp.client-ip=209.85.128.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=baylibre.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=baylibre.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=baylibre-com.20230601.gappssmtp.com header.i=@baylibre-com.20230601.gappssmtp.com header.b="vO4ZMXMP" Received: by mail-wm1-f52.google.com with SMTP id 5b1f17b1804b1-4315df7b43fso7275945e9.0 for ; Thu, 24 Oct 2024 02:12:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=baylibre-com.20230601.gappssmtp.com; s=20230601; t=1729761174; x=1730365974; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=0ExSlIGvQ1qKjNeppy5CslHA0+Ug61+8Wg56jV+Rbdo=; b=vO4ZMXMPQLxDzGZzWC0C4qYT4KWHdsYAJ6Lc1fvUQCtANW8saCsYNVZH41sSoMhusb RgNutDh6UjMfNYlYUgjBri2wpawg8heedUgB7CFoux5sajv4HO4G6SOXxSiKZ/9iv3W2 qaaDuMamDHX2ce8tC2XLzU4G/f7S43EpbdNfvqU36o3t8aoCkJ1SKIVuNh9tcqITBUIX CLQGRdz6QF0zMO1y0S0reyR6MP7iCuESjKfNa3X/rWCTb3SR6UVsTlzHeesMcazXaAPc +EGpHXZRudb/ZZiq+q0WtPSTvt9DuJ0Kp2S9hrBZsS2SzoA7TWvphIABrqkvG1u6rIag skgA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1729761174; x=1730365974; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=0ExSlIGvQ1qKjNeppy5CslHA0+Ug61+8Wg56jV+Rbdo=; b=BpRi/yo7ArYCQ0MGEguhEJ6+YPPEKyoftDhcFJmAijl5XzjcF5/g/Koj6QsfPl9Doh hDHnt3uu3Gq+vMnGXDMVd5DtgbGQwerK39NUc0lr49vuTNyN205nQVCh5DyJ9EHQw22d 3YNGqFQvZge1kbqRhV75dpMmzEKPhBgLnlEtOwd9oW3DUhX3ZLUFVaRclfh+hP97O8co dUe+MM7b10nHv2mrvC6bwIjcinBr7MRIyNrbMRucLqSmb2S86gSBsyn0s0YYA38GJ0F9 NgzecsjpPh4AxkiU5pIlo0+e5io9sAJnfy1YgGvcxzmuzk4idH/vWk9+o+Q86kPTcVok 0PDA== X-Gm-Message-State: AOJu0YxzYPMi56Yxnat7ybDUSCDnms4gJAhwGrsMuIf71ScOuc5/L1b2 GZzWQJDuJgTUEiVbAGz4whuReTCOJG04F45oK5CTE7a0CjO+okZX1wZYkjJWGOs= X-Google-Smtp-Source: AGHT+IHssIn5+2M6/mPZQxU0hUVx3UQF3gcvmL8dKPbUHqhz4gdaCpTX+p1XSijdvMnFvDxT9HuOTQ== X-Received: by 2002:a5d:66c7:0:b0:37d:50f8:a7f4 with SMTP id ffacd0b85a97d-380458f3f6bmr784047f8f.52.1729761173970; Thu, 24 Oct 2024 02:12:53 -0700 (PDT) Received: from [192.168.1.64] (2a02-842a-d52e-6101-6fd0-06c4-5d68-f0a5.rev.sfr.net. [2a02:842a:d52e:6101:6fd0:6c4:5d68:f0a5]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-37ee0b94071sm10843701f8f.89.2024.10.24.02.12.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 24 Oct 2024 02:12:53 -0700 (PDT) From: Julien Stephan Date: Thu, 24 Oct 2024 11:11:28 +0200 Subject: [PATCH 6/7] iio: light: stk3310: simplify code in write_event_config callback Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20241024-iio-fix-write-event-config-signature-v1-6-7d29e5a31b00@baylibre.com> References: <20241024-iio-fix-write-event-config-signature-v1-0-7d29e5a31b00@baylibre.com> In-Reply-To: <20241024-iio-fix-write-event-config-signature-v1-0-7d29e5a31b00@baylibre.com> To: Mudit Sharma , Jonathan Cameron , Lars-Peter Clausen , Anshul Dalal , Javier Carrasco , Jean-Baptiste Maneyrol , Michael Hennerich , Cosmin Tanislav , Ramona Gradinariu , Antoniu Miclaus , Dan Robertson , Marcelo Schmitt , Matteo Martelli , Anand Ashok Dumbre , Michal Simek , Mariel Tinaco , Jagath Jog J , Lorenzo Bianconi , Subhajit Ghosh , Kevin Tsai , Linus Walleij , Benson Leung , Guenter Roeck Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, chrome-platform@lists.linux.dev, Julien Stephan X-Mailer: b4 0.14.2 iio_ev_state_store is actually using kstrtobool to check user input, then gives the converted boolean value to the write_event_config callback. Remove useless code in write_event_config callback. Signed-off-by: Julien Stephan --- drivers/iio/light/stk3310.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/iio/light/stk3310.c b/drivers/iio/light/stk3310.c index ed20b67145463d253a0dff28a4c1c3e02e710319..c6f950af5afa0f77a617bd2baf0a08eef5ec26f0 100644 --- a/drivers/iio/light/stk3310.c +++ b/drivers/iio/light/stk3310.c @@ -330,9 +330,6 @@ static int stk3310_write_event_config(struct iio_dev *indio_dev, struct stk3310_data *data = iio_priv(indio_dev); struct i2c_client *client = data->client; - if (state < 0 || state > 7) - return -EINVAL; - /* Set INT_PS value */ mutex_lock(&data->lock); ret = regmap_field_write(data->reg_int_ps, state);