| Message ID | 20241031-iio-fix-write-event-config-signature-v2-15-2bcacbb517a2@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: fix write_event_config signature | expand |
On Thu, 31 Oct 2024 16:27:10 +0100 Julien Stephan <jstephan@baylibre.com> wrote: > return 0 statement at the end of apds9960_read_event_config is useless. > Remove it. Strange that never triggered a build warning that I noticed. Anyhow applied. So I did end up more or less (i.e. with tweaks) applying the whole series. If you have time to follow up on the few cases I spotted where passing the bool value into functions instead of an int may make for better readability. > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> > --- > drivers/iio/light/apds9960.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c > index 7b3da88885693c488807da459ceaa1cbb3881bcd..d30441d3370309fce9d6c717d42b829ff1db3174 100644 > --- a/drivers/iio/light/apds9960.c > +++ b/drivers/iio/light/apds9960.c > @@ -749,8 +749,6 @@ static int apds9960_read_event_config(struct iio_dev *indio_dev, > default: > return -EINVAL; > } > - > - return 0; > } > > static int apds9960_write_event_config(struct iio_dev *indio_dev, >
diff --git a/drivers/iio/light/apds9960.c b/drivers/iio/light/apds9960.c index 7b3da88885693c488807da459ceaa1cbb3881bcd..d30441d3370309fce9d6c717d42b829ff1db3174 100644 --- a/drivers/iio/light/apds9960.c +++ b/drivers/iio/light/apds9960.c @@ -749,8 +749,6 @@ static int apds9960_read_event_config(struct iio_dev *indio_dev, default: return -EINVAL; } - - return 0; } static int apds9960_write_event_config(struct iio_dev *indio_dev,
return 0 statement at the end of apds9960_read_event_config is useless. Remove it. Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- drivers/iio/light/apds9960.c | 2 -- 1 file changed, 2 deletions(-)