| Message ID | 20241031-iio-fix-write-event-config-signature-v2-4-2bcacbb517a2@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: fix write_event_config signature | expand |
On Thu, 31 Oct 2024 16:26:59 +0100 Julien Stephan <jstephan@baylibre.com> wrote: > iio_ev_state_store is actually using kstrtobool to check user > input, then gives the converted boolean value to the write_event_config > callback. > > Remove useless code in write_event_config callback. > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> Applied and pushed out as testing. If anyone has time to review I can still add tags (or pull the patches if there is something I missed!) Thanks, Jonathan > --- > drivers/iio/proximity/irsd200.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/iio/proximity/irsd200.c b/drivers/iio/proximity/irsd200.c > index 6e96b764fed8b577d71c3146210679b0b61d4c38..fb0691da99ee621e19013a64d122f097e793efd9 100644 > --- a/drivers/iio/proximity/irsd200.c > +++ b/drivers/iio/proximity/irsd200.c > @@ -662,7 +662,7 @@ static int irsd200_write_event_config(struct iio_dev *indio_dev, > return ret; > > return regmap_field_write( > - data->regfields[IRS_REGF_INTR_COUNT_THR_OR], !!state); > + data->regfields[IRS_REGF_INTR_COUNT_THR_OR], state); > default: > return -EINVAL; > } >
diff --git a/drivers/iio/proximity/irsd200.c b/drivers/iio/proximity/irsd200.c index 6e96b764fed8b577d71c3146210679b0b61d4c38..fb0691da99ee621e19013a64d122f097e793efd9 100644 --- a/drivers/iio/proximity/irsd200.c +++ b/drivers/iio/proximity/irsd200.c @@ -662,7 +662,7 @@ static int irsd200_write_event_config(struct iio_dev *indio_dev, return ret; return regmap_field_write( - data->regfields[IRS_REGF_INTR_COUNT_THR_OR], !!state); + data->regfields[IRS_REGF_INTR_COUNT_THR_OR], state); default: return -EINVAL; }
iio_ev_state_store is actually using kstrtobool to check user input, then gives the converted boolean value to the write_event_config callback. Remove useless code in write_event_config callback. Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- drivers/iio/proximity/irsd200.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)