| Message ID | 20241031-iio-fix-write-event-config-signature-v2-8-2bcacbb517a2@baylibre.com (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: fix write_event_config signature | expand |
On Thu, 31 Oct 2024 16:27:03 +0100 Julien Stephan <jstephan@baylibre.com> wrote: > Since the write_event_config callback now uses a bool for the state > parameter, update the signature of the function it calls accordingly, > and use a bool array for event_enabled. > > Signed-off-by: Julien Stephan <jstephan@baylibre.com> Applied. > --- > drivers/iio/accel/mma9551.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c > index 605022f5239a6412827f4ba059aa18d490908720..6d73eec951263956f314f82542becbbae933de91 100644 > --- a/drivers/iio/accel/mma9551.c > +++ b/drivers/iio/accel/mma9551.c > @@ -45,7 +45,7 @@ enum mma9551_tilt_axis { > struct mma9551_data { > struct i2c_client *client; > struct mutex mutex; > - int event_enabled[3]; > + bool event_enabled[3]; > int irqs[MMA9551_GPIO_COUNT]; > }; > > @@ -162,7 +162,7 @@ static int mma9551_read_event_config(struct iio_dev *indio_dev, > > static int mma9551_config_incli_event(struct iio_dev *indio_dev, > enum iio_modifier axis, > - int state) > + bool state) > { > struct mma9551_data *data = iio_priv(indio_dev); > enum mma9551_tilt_axis mma_axis; > @@ -174,7 +174,7 @@ static int mma9551_config_incli_event(struct iio_dev *indio_dev, > if (data->event_enabled[mma_axis] == state) > return 0; > > - if (state == 0) { > + if (!state) { > ret = mma9551_gpio_config(data->client, > (enum mma9551_gpio_pin)mma_axis, > MMA9551_APPID_NONE, 0, 0); >
diff --git a/drivers/iio/accel/mma9551.c b/drivers/iio/accel/mma9551.c index 605022f5239a6412827f4ba059aa18d490908720..6d73eec951263956f314f82542becbbae933de91 100644 --- a/drivers/iio/accel/mma9551.c +++ b/drivers/iio/accel/mma9551.c @@ -45,7 +45,7 @@ enum mma9551_tilt_axis { struct mma9551_data { struct i2c_client *client; struct mutex mutex; - int event_enabled[3]; + bool event_enabled[3]; int irqs[MMA9551_GPIO_COUNT]; }; @@ -162,7 +162,7 @@ static int mma9551_read_event_config(struct iio_dev *indio_dev, static int mma9551_config_incli_event(struct iio_dev *indio_dev, enum iio_modifier axis, - int state) + bool state) { struct mma9551_data *data = iio_priv(indio_dev); enum mma9551_tilt_axis mma_axis; @@ -174,7 +174,7 @@ static int mma9551_config_incli_event(struct iio_dev *indio_dev, if (data->event_enabled[mma_axis] == state) return 0; - if (state == 0) { + if (!state) { ret = mma9551_gpio_config(data->client, (enum mma9551_gpio_pin)mma_axis, MMA9551_APPID_NONE, 0, 0);
Since the write_event_config callback now uses a bool for the state parameter, update the signature of the function it calls accordingly, and use a bool array for event_enabled. Signed-off-by: Julien Stephan <jstephan@baylibre.com> --- drivers/iio/accel/mma9551.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)