| Message ID | 20241101130742.3479110-3-darius.berghe@analog.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/3] iio: imu: adis16480: add devices to adis16480 driver | expand |
On Fri, 1 Nov 2024 15:07:42 +0200 Darius Berghe <darius.berghe@analog.com> wrote: > Add the adis16486, adis16487 and adis16489 Six Degrees > of Freedom Inertial Sensors to the list of compatible devices > of the adis16480 iio subsystem driver. Hi Darius Please give a brief statement of what differs between these and the many other compatibles in this binding (beyond the ID register)? (usually scales, features etc) In particularly you state in the docs patch that one of them is functionally equivalent to an existing part so there a fallback compatible is appropriate. See how the st,lsm6dsx does it. The reason to do this it allows the potential for an old kernel driver to work fine with a newer device tree. Other than that the series looks good to me. Given we have a case where data could be shared, longer term breaking up the chip_info array into individual structures would allow sharing of the data. The name handling in here isn't ideal as it relies on matching in the spi_device_id table which is fragile. Doing that more cleanly might break the sharing of structures. Oh well, not relevant for this set anyway. Jonathan > > Signed-off-by: Darius Berghe <darius.berghe@analog.com> > --- > Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml > index e3eec38897bf..5bef2878a0df 100644 > --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml > +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml > @@ -15,7 +15,10 @@ properties: > - adi,adis16375 > - adi,adis16480 > - adi,adis16485 > + - adi,adis16486 > + - adi,adis16487 > - adi,adis16488 > + - adi,adis16489 > - adi,adis16490 > - adi,adis16495-1 > - adi,adis16495-2
diff --git a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml index e3eec38897bf..5bef2878a0df 100644 --- a/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml +++ b/Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml @@ -15,7 +15,10 @@ properties: - adi,adis16375 - adi,adis16480 - adi,adis16485 + - adi,adis16486 + - adi,adis16487 - adi,adis16488 + - adi,adis16489 - adi,adis16490 - adi,adis16495-1 - adi,adis16495-2
Add the adis16486, adis16487 and adis16489 Six Degrees of Freedom Inertial Sensors to the list of compatible devices of the adis16480 iio subsystem driver. Signed-off-by: Darius Berghe <darius.berghe@analog.com> --- Documentation/devicetree/bindings/iio/imu/adi,adis16480.yaml | 3 +++ 1 file changed, 3 insertions(+)