| Message ID | 20241107-p3t1085-v1-1-9a76cb85673f@nxp.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: temperature: Add support for P3T1085 | expand |
On 24-11-07, Frank Li wrote: > P3T1085UK is a temperature-to-digital converter with a -40 °C to +125 °C > range. The device can be communicated by a controller via the 2-wire serial > I3C (up to 12.5 MHz) and I2C (up to 3.4 MHz) interface. > > Add it to trivial-devices.yaml because only one 'reg' and 'interrupts' > needs. > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 6ecd6432b021b..361943b3d73bc 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -301,6 +301,8 @@ properties: > - national,lm92 > # Nuvoton Temperature Sensor > - nuvoton,w83773g > + # NXP I2C/I3C Temperature Sensor (-40 °C to +125 °C) > + - nxp,p3t1085 The description of this binding says: "This is a list of trivial I2C and SPI devices ..." but you add a I2C and I3C device. Also I really like to see that you add a "power-supply" property which is most the time missing for such simple devices but always required. Regards, Marco > # OKI ML86V7667 video decoder > - oki,ml86v7667 > # ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller > > -- > 2.34.1 > > >
On Fri, Nov 08, 2024 at 09:45:47AM +0100, Marco Felsch wrote: > On 24-11-07, Frank Li wrote: > > P3T1085UK is a temperature-to-digital converter with a -40 °C to +125 °C > > range. The device can be communicated by a controller via the 2-wire serial > > I3C (up to 12.5 MHz) and I2C (up to 3.4 MHz) interface. > > > > Add it to trivial-devices.yaml because only one 'reg' and 'interrupts' > > needs. > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > > index 6ecd6432b021b..361943b3d73bc 100644 > > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > > @@ -301,6 +301,8 @@ properties: > > - national,lm92 > > # Nuvoton Temperature Sensor > > - nuvoton,w83773g > > + # NXP I2C/I3C Temperature Sensor (-40 °C to +125 °C) > > + - nxp,p3t1085 > > The description of this binding says: > > "This is a list of trivial I2C and SPI devices ..." > > but you add a I2C and I3C device. > > Also I really like to see that you add a "power-supply" property which > is most the time missing for such simple devices but always required. Aye, the done thing in iio land is to make the supplies required too.
diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml index 6ecd6432b021b..361943b3d73bc 100644 --- a/Documentation/devicetree/bindings/trivial-devices.yaml +++ b/Documentation/devicetree/bindings/trivial-devices.yaml @@ -301,6 +301,8 @@ properties: - national,lm92 # Nuvoton Temperature Sensor - nuvoton,w83773g + # NXP I2C/I3C Temperature Sensor (-40 °C to +125 °C) + - nxp,p3t1085 # OKI ML86V7667 video decoder - oki,ml86v7667 # ON Semiconductor ADT7462 Temperature, Voltage Monitor and Fan Controller
P3T1085UK is a temperature-to-digital converter with a -40 °C to +125 °C range. The device can be communicated by a controller via the 2-wire serial I3C (up to 12.5 MHz) and I2C (up to 3.4 MHz) interface. Add it to trivial-devices.yaml because only one 'reg' and 'interrupts' needs. Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/trivial-devices.yaml | 2 ++ 1 file changed, 2 insertions(+)