| Message ID | 20241113-iio-adc-ad4695-move-dt-bindings-header-v1-2-aba1f0f9b628@baylibre.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | iio: adc: ad4695: move dt-bindings header | expand |
On Wed, 13 Nov 2024 10:55:20 -0600, David Lechner wrote: > Change the include path for the adi,ad4695.h header since it has been > moved to the include/dt-bindings/iio/adc/ directory. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: Documentation/devicetree/bindings/iio/adc/adi,ad4695.example.dts:19:18: fatal error: dt-bindings/iio/adc/adi,ad4695.h: No such file or directory 19 | #include <dt-bindings/iio/adc/adi,ad4695.h> | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ compilation terminated. make[2]: *** [scripts/Makefile.dtbs:129: Documentation/devicetree/bindings/iio/adc/adi,ad4695.example.dtb] Error 1 make[2]: *** Waiting for unfinished jobs.... make[1]: *** [/builds/robherring/dt-review-ci/linux/Makefile:1442: dt_binding_check] Error 2 make: *** [Makefile:224: __sub-make] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241113-iio-adc-ad4695-move-dt-bindings-header-v1-2-aba1f0f9b628@baylibre.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On 11/13/24 12:18 PM, Rob Herring (Arm) wrote: > > On Wed, 13 Nov 2024 10:55:20 -0600, David Lechner wrote: >> Change the include path for the adi,ad4695.h header since it has been >> moved to the include/dt-bindings/iio/adc/ directory. >> >> Signed-off-by: David Lechner <dlechner@baylibre.com> >> --- >> Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++--- >> 1 file changed, 4 insertions(+), 3 deletions(-) >> > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > Documentation/devicetree/bindings/iio/adc/adi,ad4695.example.dts:19:18: fatal error: dt-bindings/iio/adc/adi,ad4695.h: No such file or directory > 19 | #include <dt-bindings/iio/adc/adi,ad4695.h> > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Is this testing this patch without the other patch from this series? I did run make `dt_binding_check DT_SCHEMA_FILES=adi,ad4695.yaml ...` locally before sending the patch, so wasn't expecting an error here. I know that normally we should be including the header change in the same patch as the .yaml file, but in this case, I had to make an exception because the same header is also included in a .c file. It seemed better to not break compiling .c files rather than follow the rule strictly.
On Wed, 13 Nov 2024 10:55:20 -0600, David Lechner wrote: > Change the include path for the adi,ad4695.h header since it has been > moved to the include/dt-bindings/iio/adc/ directory. > > Signed-off-by: David Lechner <dlechner@baylibre.com> > --- > Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml index 310f046e139f..7d2229dee444 100644 --- a/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml +++ b/Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml @@ -134,8 +134,9 @@ patternProperties: description: Describes the common mode channel for single channels. 0xFF is REFGND and OxFE is COM. Macros are available for these values in - dt-bindings/iio/adi,ad4695.h. Values 1 to 15 correspond to INx inputs. - Only odd numbered INx inputs can be used as common mode channels. + dt-bindings/iio/adc/adi,ad4695.h. Values 1 to 15 correspond to INx + inputs. Only odd numbered INx inputs can be used as common mode + channels. enum: [1, 3, 5, 7, 9, 11, 13, 15, 0xFE, 0xFF] default: 0xFF @@ -209,7 +210,7 @@ unevaluatedProperties: false examples: - | #include <dt-bindings/gpio/gpio.h> - #include <dt-bindings/iio/adi,ad4695.h> + #include <dt-bindings/iio/adc/adi,ad4695.h> spi { #address-cells = <1>;
Change the include path for the adi,ad4695.h header since it has been moved to the include/dt-bindings/iio/adc/ directory. Signed-off-by: David Lechner <dlechner@baylibre.com> --- Documentation/devicetree/bindings/iio/adc/adi,ad4695.yaml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-)