| Message ID | 20241202181907.21471-2-vassilisamir@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: pressure: bmp280: Minor cleanup | expand |
On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote: > The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it > in the device-tree. > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > --- > .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++ > 1 file changed, 32 insertions(+) > My bot found errors running 'make dt_binding_check' on your patch: yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]] from schema $id: http://devicetree.org/schemas/iio/pressure/bmp085.yaml# doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241202181907.21471-2-vassilisamir@gmail.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema.
On Mon, Dec 02, 2024 at 02:46:13PM -0600, Rob Herring (Arm) wrote: > > On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote: > > The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it > > in the device-tree. > > > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > > --- > > .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++ > > 1 file changed, 32 insertions(+) > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]] Hi Rob, Krzysztof, The error is in the example, I put the tree from the I2C example to SPI but I used bmp280 which is not supporting interrupts. Will be fixed. Cheers, Vasilis > from schema $id: http://devicetree.org/schemas/iio/pressure/bmp085.yaml# > > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241202181907.21471-2-vassilisamir@gmail.com > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. >
On 02/12/2024 23:04, Vasileios Amoiridis wrote: > On Mon, Dec 02, 2024 at 02:46:13PM -0600, Rob Herring (Arm) wrote: >> >> On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote: >>> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it >>> in the device-tree. >>> >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> >>> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> >>> --- >>> .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++ >>> 1 file changed, 32 insertions(+) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]] > > Hi Rob, Krzysztof, > > The error is in the example, I put the tree from the I2C example to SPI > but I used bmp280 which is not supporting interrupts. Will be fixed. So you sent a patch with a known bug or just did not test? Best regards, Krzysztof
On Tue, Dec 03, 2024 at 08:23:35AM +0100, Krzysztof Kozlowski wrote: > On 02/12/2024 23:04, Vasileios Amoiridis wrote: > > On Mon, Dec 02, 2024 at 02:46:13PM -0600, Rob Herring (Arm) wrote: > >> > >> On Mon, 02 Dec 2024 19:19:05 +0100, Vasileios Amoiridis wrote: > >>> The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it > >>> in the device-tree. > >>> > >>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > >>> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> > >>> --- > >>> .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++ > >>> 1 file changed, 32 insertions(+) > >>> > >> > >> My bot found errors running 'make dt_binding_check' on your patch: > >> > >> yamllint warnings/errors: > >> > >> dtschema/dtc warnings/errors: > >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/iio/pressure/bmp085.example.dtb: pressure@0: interrupts: False schema does not allow [[25, 1]] > > > > Hi Rob, Krzysztof, > > > > The error is in the example, I put the tree from the I2C example to SPI > > but I used bmp280 which is not supporting interrupts. Will be fixed. > > > So you sent a patch with a known bug or just did not test? > > Best regards, > Krzysztof Hi Krzysztof, Nothing of the two. I didn't test properly. I am trying to automate my testing+sending patches process (Andy mentioned something similar in another e-mail in this series). Do you have any advice/tool to propose on how to automate this? It would be very welcome! Sorry for the inconvenience in any case. Cheers, Vasilis
diff --git a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml index cb201cecfa1a..43af400a9939 100644 --- a/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml +++ b/Documentation/devicetree/bindings/iio/pressure/bmp085.yaml @@ -55,12 +55,16 @@ properties: If not set, defaults to push-pull configuration. type: boolean + spi-max-frequency: + maximum: 10000000 + required: - compatible - vddd-supply - vdda-supply allOf: + - $ref: /schemas/spi/spi-peripheral-props.yaml# - if: properties: compatible: @@ -73,6 +77,16 @@ allOf: then: properties: interrupts: false + - if: + properties: + compatible: + contains: + enum: + - bosch,bmp085 + - bosch,bmp180 + then: + properties: + spi-max-frequency: false additionalProperties: false @@ -93,3 +107,21 @@ examples: vdda-supply = <&bar>; }; }; + - | + # include <dt-bindings/gpio/gpio.h> + # include <dt-bindings/interrupt-controller/irq.h> + spi { + #address-cells = <1>; + #size-cells = <0>; + pressure@0 { + compatible = "bosch,bmp280"; + reg = <0>; + spi-max-frequency = <10000000>; + interrupt-parent = <&gpio0>; + interrupts = <25 IRQ_TYPE_EDGE_RISING>; + reset-gpios = <&gpio0 26 GPIO_ACTIVE_LOW>; + vddd-supply = <&foo>; + vdda-supply = <&bar>; + }; + }; +
The BMP{2,3,5}80 and BME280 devices have an SPI interface, so include it in the device-tree. Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Signed-off-by: Vasileios Amoiridis <vassilisamir@gmail.com> --- .../bindings/iio/pressure/bmp085.yaml | 32 +++++++++++++++++++ 1 file changed, 32 insertions(+)