From patchwork Mon Feb 17 14:16:12 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jonathan Cameron X-Patchwork-Id: 13977944 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BD80822332C for ; Mon, 17 Feb 2025 14:17:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739801876; cv=none; b=cknzLYskOBeBZtV+8kJv8Up/t+14ZSOss2QXUa8v4pS3Cg8JVVzgi97tMQ6VpDaeNMZ55ckvc+0I1liZRsFXy6zXC9hKQ4nor8Z/p+j+GD/FgHmxP0PBJaFRdSgVi6JwsnmyuW7qNG/1JoRwbrq40YqGqz8maDX0+ygsX8eQzEs= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739801876; c=relaxed/simple; bh=ByhlkCrkjQqcJio/gxxmPyJVVQtcOBdbFa/D8+oHRag=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pSYxxnM9ey5s2O/kKtCSpyWiShzcN3Ajg/ve3wDyXLrXMNUC1JQXC6zo4wBGFlFVOFYW+ho6JnJfc54Sh6twABgmd/igVpiLFxMZD0WWDFYKdY84A8vgCJCvV7n0eNMEp686zWPtEKqteFElPbf3baUprPzJzzTg3R9fheuwqT8= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=K6JMYIXK; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="K6JMYIXK" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2D896C4CED1; Mon, 17 Feb 2025 14:17:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1739801876; bh=ByhlkCrkjQqcJio/gxxmPyJVVQtcOBdbFa/D8+oHRag=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=K6JMYIXKEveBWThJ0VL1HINhCEwDIbKBy3lRdhUqB1U9ZY7XLPC2Y3KQvHUfGzRX5 W03KW2mYj7ZaH2t6lwwCGruv6vGRt8BHSZZUhvLfb8fyt2JVwa+iMwKHzIiqbgfXY9 CVHcRXhk4D+dnEU4WnFemE6wfDF7yJ7WzzOS2mh8LFvfXuS6bff6mWyic/SPchhtJ/ rWWMOczi01IkBhWEJhBWXh/H/Dfa+lvlAkHmovPhojyzbEhl/oY1egKPEfMzWIUxZH k+E4Bv+kSiWVySCA+x6GktU4KnZ8THxNaGVuPMO7RTi/YX0BL6vmeL83PLRaJBDF76 mxr1VMIMxKsnA== From: Jonathan Cameron To: linux-iio@vger.kernel.org Cc: David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Olivier Moysan , Mike Looijmans , Phil Reid , Marek Vasut , Miquel Raynal , Claudiu Beznea , =?utf-8?q?Uwe_Kleine-K=C3=B6nig?= , Alisa-Dariana Roman , Marek Vasut , Frank Li , Jonathan Cameron Subject: [PATCH 12/29] iio: adc: ad7768-1: Move setting of val a bit later to avoid unnecessary return value check Date: Mon, 17 Feb 2025 14:16:12 +0000 Message-ID: <20250217141630.897334-13-jic23@kernel.org> X-Mailer: git-send-email 2.48.1 In-Reply-To: <20250217141630.897334-1-jic23@kernel.org> References: <20250217141630.897334-1-jic23@kernel.org> Precedence: bulk X-Mailing-List: linux-iio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 From: Jonathan Cameron The data used is all in local variables so there is no advantage in setting *val = ret with the direct mode claim held. Move it later to after error check. Signed-off-by: Jonathan Cameron Reviewed-by: Nuno Sá --- drivers/iio/adc/ad7768-1.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/iio/adc/ad7768-1.c b/drivers/iio/adc/ad7768-1.c index 113703fb7245..c2ba357b82d8 100644 --- a/drivers/iio/adc/ad7768-1.c +++ b/drivers/iio/adc/ad7768-1.c @@ -370,12 +370,11 @@ static int ad7768_read_raw(struct iio_dev *indio_dev, return ret; ret = ad7768_scan_direct(indio_dev); - if (ret >= 0) - *val = ret; iio_device_release_direct_mode(indio_dev); if (ret < 0) return ret; + *val = ret; return IIO_VAL_INT;