| Message ID | 20250217141630.897334-15-jic23@kernel.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | IIO: ADCs: Sparse friendly claim of direct mode | expand |
On Mon, 2025-02-17 at 14:16 +0000, Jonathan Cameron wrote: > From: Jonathan Cameron <Jonathan.Cameron@huawei.com> > > These new functions allow sparse to find failures to release > direct mode reducing chances of bugs over the claim_direct_mode() > functions that are deprecated. > > This driver got partly converted during removal of the _scoped form. > However some more cases got added in parallel. > > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com> > --- Reviewed-by: Nuno Sá <nuno.sa@analog.com> > drivers/iio/adc/ad7606.c | 14 ++++++-------- > 1 file changed, 6 insertions(+), 8 deletions(-) > > diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c > index 87908cc51e48..f566248db70a 100644 > --- a/drivers/iio/adc/ad7606.c > +++ b/drivers/iio/adc/ad7606.c > @@ -862,11 +862,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev, > val = (val * MICRO) + val2; > i = find_closest(val, scale_avail_uv, cs->num_scales); > > - ret = iio_device_claim_direct_mode(indio_dev); > - if (ret < 0) > - return ret; > + if (!iio_device_claim_direct(indio_dev)) > + return -EBUSY; > ret = st->write_scale(indio_dev, ch, i + cs->reg_offset); > - iio_device_release_direct_mode(indio_dev); > + iio_device_release_direct(indio_dev); > if (ret < 0) > return ret; > cs->range = i; > @@ -878,11 +877,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev, > i = find_closest(val, st->oversampling_avail, > st->num_os_ratios); > > - ret = iio_device_claim_direct_mode(indio_dev); > - if (ret < 0) > - return ret; > + if (!iio_device_claim_direct(indio_dev)) > + return -EBUSY; > ret = st->write_os(indio_dev, i); > - iio_device_release_direct_mode(indio_dev); > + iio_device_release_direct(indio_dev); > if (ret < 0) > return ret; > st->oversampling = st->oversampling_avail[i];
diff --git a/drivers/iio/adc/ad7606.c b/drivers/iio/adc/ad7606.c index 87908cc51e48..f566248db70a 100644 --- a/drivers/iio/adc/ad7606.c +++ b/drivers/iio/adc/ad7606.c @@ -862,11 +862,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev, val = (val * MICRO) + val2; i = find_closest(val, scale_avail_uv, cs->num_scales); - ret = iio_device_claim_direct_mode(indio_dev); - if (ret < 0) - return ret; + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; ret = st->write_scale(indio_dev, ch, i + cs->reg_offset); - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); if (ret < 0) return ret; cs->range = i; @@ -878,11 +877,10 @@ static int ad7606_write_raw(struct iio_dev *indio_dev, i = find_closest(val, st->oversampling_avail, st->num_os_ratios); - ret = iio_device_claim_direct_mode(indio_dev); - if (ret < 0) - return ret; + if (!iio_device_claim_direct(indio_dev)) + return -EBUSY; ret = st->write_os(indio_dev, i); - iio_device_release_direct_mode(indio_dev); + iio_device_release_direct(indio_dev); if (ret < 0) return ret; st->oversampling = st->oversampling_avail[i];