| Message ID | 20250224175056.560111-2-sam.winchenbach@framepointer.org (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | [v3,1/2] iio: filter: admv8818: fix range calculation | expand |
On 24/02/2025 18:50, Sam Winchenbach wrote: > Adds two properties to add a margin when automatically finding the > corner frequencies. > > Signed-off-by: Sam Winchenbach <sam.winchenbach@framepointer.org> <form letter> Please use scripts/get_maintainers.pl to get a list of necessary people and lists to CC. It might happen, that command when run on an older kernel, gives you outdated entries. Therefore please be sure you base your patches on recent Linux kernel. Tools like b4 or scripts/get_maintainer.pl provide you proper list of people, so fix your workflow. Tools might also fail if you work on some ancient tree (don't, instead use mainline) or work on fork of kernel (don't, instead use mainline). Just use b4 and everything should be fine, although remember about `b4 prep --auto-to-cc` if you added new patches to the patchset. You missed at least devicetree list (maybe more), so this won't be tested by automated tooling. Performing review on untested code might be a waste of time. Please kindly resend and include all necessary To/Cc entries. </form letter> > --- > .../devicetree/bindings/iio/filter/adi,admv8818.yaml | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > index b77e855bd594..1be6f1fe4bfc 100644 > --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > @@ -44,6 +44,16 @@ properties: > '#clock-cells': > const: 0 > > + adi,lpf-margin-hz: > + description: > + Sets minimum low-pass corner frequency to the frequency of rf_in plus this value when in auto mode. Wrap according to coding style. Best regards, Krzysztof
On Tue, Feb 25, 2025 at 08:42:04AM +0100, Krzysztof Kozlowski wrote: > On 24/02/2025 18:50, Sam Winchenbach wrote: > > Adds two properties to add a margin when automatically finding the > > corner frequencies. > > > > Signed-off-by: Sam Winchenbach <sam.winchenbach@framepointer.org> > > <form letter> > Please use scripts/get_maintainers.pl to get a list of necessary people > and lists to CC. It might happen, that command when run on an older > kernel, gives you outdated entries. Therefore please be sure you base > your patches on recent Linux kernel. > > Tools like b4 or scripts/get_maintainer.pl provide you proper list of > people, so fix your workflow. Tools might also fail if you work on some > ancient tree (don't, instead use mainline) or work on fork of kernel > (don't, instead use mainline). Just use b4 and everything should be > fine, although remember about `b4 prep --auto-to-cc` if you added new > patches to the patchset. > > You missed at least devicetree list (maybe more), so this won't be > tested by automated tooling. Performing review on untested code might be > a waste of time. > > Please kindly resend and include all necessary To/Cc entries. > </form letter> Updated the maintainers list per your instruction and resubmitted as v4. Thank you for your assistance. > > > --- > > .../devicetree/bindings/iio/filter/adi,admv8818.yaml | 12 ++++++++++++ > > 1 file changed, 12 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > > index b77e855bd594..1be6f1fe4bfc 100644 > > --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > > +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml > > @@ -44,6 +44,16 @@ properties: > > '#clock-cells': > > const: 0 > > > > + adi,lpf-margin-hz: > > + description: > > + Sets minimum low-pass corner frequency to the frequency of rf_in plus this value when in auto mode. > > Wrap according to coding style. Updated in the v4 patch. > > > > Best regards, > Krzysztof
diff --git a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml index b77e855bd594..1be6f1fe4bfc 100644 --- a/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml +++ b/Documentation/devicetree/bindings/iio/filter/adi,admv8818.yaml @@ -44,6 +44,16 @@ properties: '#clock-cells': const: 0 + adi,lpf-margin-hz: + description: + Sets minimum low-pass corner frequency to the frequency of rf_in plus this value when in auto mode. + default: 0 + + adi,hpf-margin-hz: + description: + Sets maximum high-pass corner frequency to the frequency of rf_in minus this value when in auto mode. + default: 0 + required: - compatible - reg @@ -61,6 +71,8 @@ examples: spi-max-frequency = <10000000>; clocks = <&admv8818_rfin>; clock-names = "rf_in"; + adi,lpf-margin-hz = /bits/ 64 <30000000>; + adi,hpf-margin-hz = /bits/ 64 <30000000>; }; }; ...
Adds two properties to add a margin when automatically finding the corner frequencies. Signed-off-by: Sam Winchenbach <sam.winchenbach@framepointer.org> --- .../devicetree/bindings/iio/filter/adi,admv8818.yaml | 12 ++++++++++++ 1 file changed, 12 insertions(+)