| Message ID | 20250319-al3010-iio-regmap-v2-10-1310729d0543@ixit.cz (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | iio: light: Modernize al3010 and al3320a codebase | expand |
On Wed, 19 Mar 2025 21:59:49 +0100 David Heidelberg via B4 Relay <devnull+david.ixit.cz@kernel.org> wrote: > From: David Heidelberg <david@ixit.cz> > > Slight simplification of the code. > > Signed-off-by: David Heidelberg <david@ixit.cz> This one is fine but given I've not picked up 9 I can't pick this up either for this version. Thanks, Jonathan > --- > drivers/iio/light/al3010.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c > index 8098c92c9572befe92d00ef0785ded5e1a08d587..af7ed028259837f2232f30072b87cc0da7c77f37 100644 > --- a/drivers/iio/light/al3010.c > +++ b/drivers/iio/light/al3010.c > @@ -184,10 +184,8 @@ static int al3010_probe(struct i2c_client *client) > indio_dev->modes = INDIO_DIRECT_MODE; > > ret = al3010_init(data); > - if (ret < 0) { > - dev_err(dev, "al3010 chip init failed\n"); > - return ret; > - } > + if (ret) > + return dev_err_probe(dev, ret, "failed to init ALS\n"); > > ret = devm_add_action_or_reset(dev, al3010_set_pwr_off, data); > if (ret) >
diff --git a/drivers/iio/light/al3010.c b/drivers/iio/light/al3010.c index 8098c92c9572befe92d00ef0785ded5e1a08d587..af7ed028259837f2232f30072b87cc0da7c77f37 100644 --- a/drivers/iio/light/al3010.c +++ b/drivers/iio/light/al3010.c @@ -184,10 +184,8 @@ static int al3010_probe(struct i2c_client *client) indio_dev->modes = INDIO_DIRECT_MODE; ret = al3010_init(data); - if (ret < 0) { - dev_err(dev, "al3010 chip init failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "failed to init ALS\n"); ret = devm_add_action_or_reset(dev, al3010_set_pwr_off, data); if (ret)