From patchwork Wed Mar 7 00:43:47 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Siqueira X-Patchwork-Id: 10263279 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 3310E602BD for ; Wed, 7 Mar 2018 00:43:55 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1FD372923A for ; Wed, 7 Mar 2018 00:43:55 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 14D972923E; Wed, 7 Mar 2018 00:43:55 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9EC6D2923A for ; Wed, 7 Mar 2018 00:43:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754167AbeCGAnx (ORCPT ); Tue, 6 Mar 2018 19:43:53 -0500 Received: from mail-qk0-f195.google.com ([209.85.220.195]:37929 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754108AbeCGAnw (ORCPT ); Tue, 6 Mar 2018 19:43:52 -0500 Received: by mail-qk0-f195.google.com with SMTP id s198so677385qke.5; Tue, 06 Mar 2018 16:43:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Yww7g5ARGdlzH1cTpZjGY9wcuNXvqUnAmmcgWdO8hR4=; b=ZlMNeRuzZBGPEGbP114GNj/lTyD3LSXA5yuUz4ukLHTUJTBolNrQ6/iYKpStL6AJ3a fiP8tm/PoMdlNXoaojb34oryCEdoPkAae5SwmvYJJDPU1t5dBJSZXIay1xoY2+vpQdzN bNRSymJAQAs1C/HP7YAenWRA8akmd4u1WdjK7jXDwbSyxmbxaVB+NOIjpsk1ARpCQ5dI gfUSTocbBB5v1mK1fxJtmvn7BRTWoRAqafRn5wgVl8HzN5Tj6ASLXqQ94VrJkxR55ne9 Cmf7f7o8yo7SHB1WHcYwMu00KxFz1IjLMZN+/CWviqJlkuVF8ty+fvP/O4c3VKiJiQZQ R+WA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Yww7g5ARGdlzH1cTpZjGY9wcuNXvqUnAmmcgWdO8hR4=; b=lw8gthx0/i7uFUvdpAHweRfOUXeRpoOkewnEMZ6BSAmgbZpGPCtaUu7aBCDOkft7fR umFsR8Cg0AVMtFCSlkKVME91hbEJFP+unNAfrDmxjQyYTQfswJuo1/74Wg8Jo3ehlJld zJ43TCjRjICVhTG2DDetLMf9c0GrKEqAsZ+B1I29M33H/aZj49FY4ACleyI26g2G98f0 Y6v/z5aI4a7fOmOTQZTEInNt8myDov2jKrbcoApKHabxZNRgXmRhaS4ptqfnsqasQxn6 ArsDnZqI9/efY9DrbYme6JkWiJ6+pC5Uuj0LgtclIIwKVHXaeAH+hNvIFhPP/wI3O/Xe PPOg== X-Gm-Message-State: AElRT7F77xERE2Q8axRWLH8AP6VbnXpPTDetpJ9myioS0M93cXhKCttf syQyRo5AK7iCyIOFYsQYAEkSv8It X-Google-Smtp-Source: AG47ELtAzgzDZ1JIuaNbZ+Ern/YO1WbHk46ZdpplnAJbkbZXBwjIGVzkQqLkMqybHTdKox8z51lXnQ== X-Received: by 10.55.163.87 with SMTP id m84mr30945948qke.82.1520383431844; Tue, 06 Mar 2018 16:43:51 -0800 (PST) Received: from smtp.gmail.com ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id m8sm12020013qkm.26.2018.03.06.16.43.49 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 06 Mar 2018 16:43:51 -0800 (PST) Date: Tue, 6 Mar 2018 21:43:47 -0300 From: Rodrigo Siqueira To: Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Greg Kroah-Hartman Cc: daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v2 1/3] staging:iio:meter: Replaces IIO_DEV_ATTR_CH_OFF by IIO_DEVICE_ATTR Message-ID: <3af0e5a795059a8418cf08ff29f05f8d5e00da9b.1520382753.git.rodrigosiqueiramelo@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20171215 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The macro IIO_DEV_ATTR_CH_OFF is a wrapper for IIO_DEVICE_ATTR, with a tiny change in the name definition. This extra macro does not improve the readability and also creates some checkpatch errors. This patch fixes the checkpatch.pl errors: staging/iio/meter/ade7753.c:391: ERROR: Use 4 digit octal (0777) not decimal permissions staging/iio/meter/ade7753.c:395: ERROR: Use 4 digit octal (0777) not decimal permissions staging/iio/meter/ade7759.c:331: ERROR: Use 4 digit octal (0777) not decimal permissions staging/iio/meter/ade7759.c:335: ERROR: Use 4 digit octal (0777) not decimal permissions Signed-off-by: Rodrigo Siqueira --- drivers/staging/iio/meter/ade7753.c | 18 ++++++++++-------- drivers/staging/iio/meter/ade7759.c | 18 ++++++++++-------- 2 files changed, 20 insertions(+), 16 deletions(-) diff --git a/drivers/staging/iio/meter/ade7753.c b/drivers/staging/iio/meter/ade7753.c index c44eb577dc35..275e8dfff836 100644 --- a/drivers/staging/iio/meter/ade7753.c +++ b/drivers/staging/iio/meter/ade7753.c @@ -388,14 +388,16 @@ static IIO_DEV_ATTR_VPERIOD(0444, ade7753_read_16bit, NULL, ADE7753_PERIOD); -static IIO_DEV_ATTR_CH_OFF(1, 0644, - ade7753_read_8bit, - ade7753_write_8bit, - ADE7753_CH1OS); -static IIO_DEV_ATTR_CH_OFF(2, 0644, - ade7753_read_8bit, - ade7753_write_8bit, - ADE7753_CH2OS); + +static IIO_DEVICE_ATTR(choff_1, 0644, + ade7753_read_8bit, + ade7753_write_8bit, + ADE7753_CH1OS); + +static IIO_DEVICE_ATTR(choff_2, 0644, + ade7753_read_8bit, + ade7753_write_8bit, + ADE7753_CH2OS); static int ade7753_set_irq(struct device *dev, bool enable) { diff --git a/drivers/staging/iio/meter/ade7759.c b/drivers/staging/iio/meter/ade7759.c index 1decb2b8afab..c078b770fa53 100644 --- a/drivers/staging/iio/meter/ade7759.c +++ b/drivers/staging/iio/meter/ade7759.c @@ -328,14 +328,16 @@ static IIO_DEV_ATTR_ACTIVE_POWER_GAIN(0644, ade7759_read_16bit, ade7759_write_16bit, ADE7759_APGAIN); -static IIO_DEV_ATTR_CH_OFF(1, 0644, - ade7759_read_8bit, - ade7759_write_8bit, - ADE7759_CH1OS); -static IIO_DEV_ATTR_CH_OFF(2, 0644, - ade7759_read_8bit, - ade7759_write_8bit, - ADE7759_CH2OS); + +static IIO_DEVICE_ATTR(choff_1, 0644, + ade7759_read_8bit, + ade7759_write_8bit, + ADE7759_CH1OS); + +static IIO_DEVICE_ATTR(choff_2, 0644, + ade7759_read_8bit, + ade7759_write_8bit, + ADE7759_CH2OS); static int ade7759_set_irq(struct device *dev, bool enable) {