From patchwork Thu Apr 6 14:40:13 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: William Breathitt Gray X-Patchwork-Id: 13203548 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 89D46C77B70 for ; Thu, 6 Apr 2023 14:42:33 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239148AbjDFOmb (ORCPT ); Thu, 6 Apr 2023 10:42:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42190 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239124AbjDFOmR (ORCPT ); Thu, 6 Apr 2023 10:42:17 -0400 Received: from mail-oi1-x22f.google.com (mail-oi1-x22f.google.com [IPv6:2607:f8b0:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED902BB93 for ; Thu, 6 Apr 2023 07:40:37 -0700 (PDT) Received: by mail-oi1-x22f.google.com with SMTP id y184so29201938oiy.8 for ; Thu, 06 Apr 2023 07:40:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1680792037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U5QEeXDXo+8Slk68c7cxRCftpIfRluY8LXkH8WgnI7Y=; b=SK/NklCaaBaTM/Glz90edPtzaUc6wm8CheJFHJgxB8egsFyIDt2Uvlk7xVY4DH/N60 Xw8We6CFUka6LZHvkAmbJKtbDzNt6QAlYNLNDqKpjl9TmYLz6572rYsyj7XXiA4j2huU Xz8ZRRPP5tfvmrV/Ce7cHv19ONC+txfVah0vXoAvUHHq3Ja3Vii+yJvncPhW+ruhT1kG RBJvzn9m3rE8N5b2lvHF7tDG2iUi7h0MraW/l6fbhv+9RVcVOW3RueTVEmn1p7DOWIGy kUiWGMzcL8R3zUCCdwlOb2yPG0qmbJPcVRruLB5U1Ep3w6OwRAJMCB7aOt/oqFK5miXM iCeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680792037; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U5QEeXDXo+8Slk68c7cxRCftpIfRluY8LXkH8WgnI7Y=; b=4NEXzP3S1ZeisK2aiVFRI2lCCW9L4x3oeovc/iPZnstrVzxuK0zVUn3dE+Om1bd5iI aR7xnQcGPo+XFmsy52U/zgy+++ODyl53de4Zf8Txcll9VdyBeXQSDAWi+BIhTxcj4ywo etmwrpON993l9nSTM48aPzsFh8yk8MNzvFN8/+/AkSkU4Oclw6eXVtmw3S3O0Y1t759c JE+QQ5oWDm8wmD0gMNB9mej7+18sfJCoWGuaQ65iC3RkDhbhnvBdIOBV+1N6heW0/eTX 5/dYYFIQye+AVHzU3NG+IkLev4kbwSk81IJAn87z301rWkJpqMK/HZfTlYlZEAXrEmSu rBRw== X-Gm-Message-State: AAQBX9dZ9FQ0OMbG0ifxzcr7LODnzDdWdr8C9vLBAuMWoWIal0efi03x Wr+Wv3I6kCeLpoZ1Q9FfP+j8ug== X-Google-Smtp-Source: AKy350Z4NesDaNZ6svLg943zXrdWqiqQrl3C+lM0UCfe+MlQeUzwbcQUQpigKabEFPi1BbuXIWWbSA== X-Received: by 2002:a05:6808:285:b0:384:2b1d:45a with SMTP id z5-20020a056808028500b003842b1d045amr4430203oic.30.1680792036750; Thu, 06 Apr 2023 07:40:36 -0700 (PDT) Received: from fedora.attlocal.net (69-109-179-158.lightspeed.dybhfl.sbcglobal.net. [69.109.179.158]) by smtp.gmail.com with ESMTPSA id q7-20020acaf207000000b0037d7f4eb7e8sm726209oih.31.2023.04.06.07.40.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Apr 2023 07:40:36 -0700 (PDT) From: William Breathitt Gray To: Jonathan Cameron , Lars-Peter Clausen Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Andy Shevchenko , William Breathitt Gray Subject: [PATCH v5 4/6] iio: addac: stx104: Improve indentation in stx104_write_raw() Date: Thu, 6 Apr 2023 10:40:13 -0400 Message-Id: <487d17da9e2612f3e6b2bd1c3def2fa1b955db9b.1680790580.git.william.gray@linaro.org> X-Mailer: git-send-email 2.39.2 In-Reply-To: References: MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org By bailing out early if chan->output is false for the IIO_CHAN_INFO_RAW, indentation can be decreased by a tab and code readability improved. Suggested-by: Andy Shevchenko Signed-off-by: William Breathitt Gray --- Changes in v5: none drivers/iio/addac/stx104.c | 20 ++++++++++---------- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/addac/stx104.c b/drivers/iio/addac/stx104.c index 0ed5f71b18cb..81020b710195 100644 --- a/drivers/iio/addac/stx104.c +++ b/drivers/iio/addac/stx104.c @@ -181,19 +181,19 @@ static int stx104_write_raw(struct iio_dev *indio_dev, return 0; case IIO_CHAN_INFO_RAW: - if (chan->output) { - if (val < 0 || val > U16_MAX) - return -EINVAL; + if (!chan->output) + return -EINVAL; - mutex_lock(&priv->lock); + if (val < 0 || val > U16_MAX) + return -EINVAL; - priv->chan_out_states[chan->channel] = val; - iowrite16(val, &priv->reg->dac[chan->channel]); + mutex_lock(&priv->lock); - mutex_unlock(&priv->lock); - return 0; - } - return -EINVAL; + priv->chan_out_states[chan->channel] = val; + iowrite16(val, &priv->reg->dac[chan->channel]); + + mutex_unlock(&priv->lock); + return 0; } return -EINVAL;