From patchwork Fri Mar 23 14:25:48 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Siqueira X-Patchwork-Id: 10304787 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 820C9605F7 for ; Fri, 23 Mar 2018 14:25:56 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 70EC328DE3 for ; Fri, 23 Mar 2018 14:25:56 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 65CC028DF6; Fri, 23 Mar 2018 14:25:56 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0BDFD28DFB for ; Fri, 23 Mar 2018 14:25:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751427AbeCWOZz (ORCPT ); Fri, 23 Mar 2018 10:25:55 -0400 Received: from mail-qt0-f194.google.com ([209.85.216.194]:35296 "EHLO mail-qt0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751395AbeCWOZy (ORCPT ); Fri, 23 Mar 2018 10:25:54 -0400 Received: by mail-qt0-f194.google.com with SMTP id s2so12692370qti.2; Fri, 23 Mar 2018 07:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:date:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=ev902ykwT74ijDpVO6kprIAolV0QsBlcnQ3JJVPv0KM=; b=KMDMy2JUbnL3FGNbyLpkdXNBsw9AKc6eW0yDmfYNgk5OX4+HM7J/1tLJyGanLjVrs5 +br1o4nzt2+DUTRTV1K87oq33nX1a2eFX0UIcsbXRAeU8BfyuFuhQVjaacJwlnOVn1KC KviJC3XMvfc1Pudh+cF9JzUV8F69TwYfYNbhL7F/PzAUeXpwVrqKHdDuvYsjV8kVpHd+ z2nsBcK60xaYH0MBtm2QAnaO/K5WPvjMYI/HZx+h7AeNnLiIIy5JWjLCPlbCahhHzz13 xWxQIUsGfUm7ty2uRPGZkGMTqpuiwdwiWnvyzQI3ERwTF0BGo/Igs8CEzv4OPU0drAzT 35qA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:date:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=ev902ykwT74ijDpVO6kprIAolV0QsBlcnQ3JJVPv0KM=; b=OdSZF54NVP4hOCBAyF/Sqy8dOZZp4NccJlKxDVjW079GKjEg/D1P0zwmO4d+cr3FlE aawKzSwOo7mPrTTKvTbmUiUM767YE3oCmueJ7V0oeckCLE9/Xv+lc+iaFTjLQwGodmgi sO4PNPi35YOAp6V62uoE7aJ2FI8DiD+DoLRimJKarBOZBmTlzPEM4aDA8IYQde3SFB4X /fGwwuO7HCbo9glT3FuLnBNhGf83BDCZwd+Nc94unH1vqYFN911N70B+fhD/zoBx8UWO ouUQn0qAcOd+7Y1YH7ZyQw++cEbOF1bzApQqvz8YnZblGrhRMfDWZz54w4HIwAneKl7w iOsQ== X-Gm-Message-State: AElRT7HF48GcH0nULcuFaTSSr4+xv1G6PKsdnTdy6f8zmXOpO9qN3aFH uJCkX4vLSbDqneoxPQSYeHc= X-Google-Smtp-Source: AG47ELuLqOlKBLK/KIIQqeN0R6LnI1k7nAQGgKFJgyFlzP7hVXYMrJXjh+5ZGK3qEaPSWL7jmEyx0w== X-Received: by 10.200.6.6 with SMTP id d6mr39972947qth.112.1521815153677; Fri, 23 Mar 2018 07:25:53 -0700 (PDT) Received: from smtp.gmail.com ([143.107.45.1]) by smtp.gmail.com with ESMTPSA id t62sm6863456qkd.50.2018.03.23.07.25.50 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 23 Mar 2018 07:25:53 -0700 (PDT) From: John Syne X-Google-Original-From: John Syne Date: Fri, 23 Mar 2018 11:25:48 -0300 To: John Syne , Jonathan Cameron , Hartmut Knaack , Lars-Peter Clausen , Peter Meerwald-Stadler , Greg Kroah-Hartman , linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, Barry Song <21cnbao@gmail.com> Cc: daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH v3 2/8] staging:iio:ade7854: Fix the wrong number of bits to read Message-ID: <5a7be7d02989db19d35f6d919fc9bce995666a55.1521813782.git.rodrigosiqueiramelo@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180223 Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Fixes: correctly handle the data size in the read operation for I2C The function ade7854_i2c_read_reg_32() have to invoke the i2c_master_recv() for read 32 bits values, however, the counter is set to 3 which means 24 bits. This patch fixes the wrong size of 24 bits, to 32 bits. Signed-off-by: John Syne Signed-off-by: Rodrigo Siqueira --- Changes in v3: - Clarify authorship - Add Fixes tag in the commit message drivers/staging/iio/meter/ade7854-i2c.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/iio/meter/ade7854-i2c.c b/drivers/staging/iio/meter/ade7854-i2c.c index 4437f1e33261..37c957482493 100644 --- a/drivers/staging/iio/meter/ade7854-i2c.c +++ b/drivers/staging/iio/meter/ade7854-i2c.c @@ -191,7 +191,7 @@ static int ade7854_i2c_read_reg_32(struct device *dev, if (ret < 0) goto out; - ret = i2c_master_recv(st->i2c, st->rx, 3); + ret = i2c_master_recv(st->i2c, st->rx, 4); if (ret < 0) goto out;