diff mbox series

iio: core: Make mlock internal to the iio core

Message ID 5e72484b.1c69fb81.53f77.5a16@mx.google.com (mailing list archive)
State Accepted
Headers show
Series iio: core: Make mlock internal to the iio core | expand

Commit Message

Rohit Sarkar March 18, 2020, 4:11 p.m. UTC
"mlock" should ideally only be used by the iio core. The mlock
implementation may change in the future which means that no driver
should be explicitly using mlock.

Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
---
 include/linux/iio/iio.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Jonathan Cameron March 21, 2020, 11:02 a.m. UTC | #1
On Wed, 18 Mar 2020 21:41:51 +0530
Rohit Sarkar <rohitsarkar5398@gmail.com> wrote:

> "mlock" should ideally only be used by the iio core. The mlock
> implementation may change in the future which means that no driver
> should be explicitly using mlock.
> 
> Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com>
Good idea.

Applied to the togreg branch of iio.git and pushed out as testing for
the autobuilders to play with it.

Thanks,

Jonathan

> ---
>  include/linux/iio/iio.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
> index eed58ed2f368..e975020abaa6 100644
> --- a/include/linux/iio/iio.h
> +++ b/include/linux/iio/iio.h
> @@ -492,7 +492,7 @@ struct iio_buffer_setup_ops {
>   * @buffer:		[DRIVER] any buffer present
>   * @buffer_list:	[INTERN] list of all buffers currently attached
>   * @scan_bytes:		[INTERN] num bytes captured to be fed to buffer demux
> - * @mlock:		[DRIVER] lock used to prevent simultaneous device state
> + * @mlock:		[INTERN] lock used to prevent simultaneous device state
>   *			changes
>   * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
>   * @masklength:		[INTERN] the length of the mask established from
diff mbox series

Patch

diff --git a/include/linux/iio/iio.h b/include/linux/iio/iio.h
index eed58ed2f368..e975020abaa6 100644
--- a/include/linux/iio/iio.h
+++ b/include/linux/iio/iio.h
@@ -492,7 +492,7 @@  struct iio_buffer_setup_ops {
  * @buffer:		[DRIVER] any buffer present
  * @buffer_list:	[INTERN] list of all buffers currently attached
  * @scan_bytes:		[INTERN] num bytes captured to be fed to buffer demux
- * @mlock:		[DRIVER] lock used to prevent simultaneous device state
+ * @mlock:		[INTERN] lock used to prevent simultaneous device state
  *			changes
  * @available_scan_masks: [DRIVER] optional array of allowed bitmasks
  * @masklength:		[INTERN] the length of the mask established from