| Message ID | 5e7ef454.1c69fb81.56770.82c7@mx.google.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | iio: temperature: ltc2983: remove redundant comparison to bool | expand |
> -----Original Message----- > From: Rohit Sarkar <rohitsarkar5398@gmail.com> > Sent: Samstag, 28. März 2020 07:53 > To: linux-iio@vger.kernel.org > Cc: Sa, Nuno <Nuno.Sa@analog.com>; rohitsarkar5398@gmail.com; > jic23@kernel.org; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen > <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; linux- > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Bogdan, Dragos > <Dragos.Bogdan@analog.com> > Subject: [PATCH] iio: temperature: ltc2983: remove redundant comparison to > bool > > > Remove redundant comparison to a boolean variable. > > Fixes coccinelle warning: > drivers/iio/temperature//ltc2983.c:393:20-32: WARNING: Comparison to > bool > drivers/iio/temperature//ltc2983.c:394:20-32: WARNING: Comparison to > bool > > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com> > --- > drivers/iio/temperature/ltc2983.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/temperature/ltc2983.c > b/drivers/iio/temperature/ltc2983.c > index d39c0d6b77f1..8976e8d59826 100644 > --- a/drivers/iio/temperature/ltc2983.c > +++ b/drivers/iio/temperature/ltc2983.c > @@ -390,8 +390,8 @@ static struct ltc2983_custom_sensor > *__ltc2983_custom_sensor_new( > * For custom steinhart, the full u32 is taken. For all the others > * the MSB is discarded. > */ > - const u8 n_size = (is_steinhart == true) ? 4 : 3; > - const u8 e_size = (is_steinhart == true) ? sizeof(u32) : sizeof(u64); > + const u8 n_size = is_steinhart ? 4 : 3; > + const u8 e_size = is_steinhart ? sizeof(u32) : sizeof(u64); > > n_entries = of_property_count_elems_of_size(np, propname, e_size); > /* n_entries must be an even number */ > -- Acked-by: Nuno Sá <nuno.sa@analog.com> Thanks, Nuno Sá
On Sat, 28 Mar 2020 09:43:58 +0000 "Sa, Nuno" <Nuno.Sa@analog.com> wrote: > > -----Original Message----- > > From: Rohit Sarkar <rohitsarkar5398@gmail.com> > > Sent: Samstag, 28. März 2020 07:53 > > To: linux-iio@vger.kernel.org > > Cc: Sa, Nuno <Nuno.Sa@analog.com>; rohitsarkar5398@gmail.com; > > jic23@kernel.org; Hartmut Knaack <knaack.h@gmx.de>; Lars-Peter Clausen > > <lars@metafoo.de>; Peter Meerwald-Stadler <pmeerw@pmeerw.net>; linux- > > iio@vger.kernel.org; linux-kernel@vger.kernel.org; Bogdan, Dragos > > <Dragos.Bogdan@analog.com> > > Subject: [PATCH] iio: temperature: ltc2983: remove redundant comparison to > > bool > > > > > > Remove redundant comparison to a boolean variable. > > > > Fixes coccinelle warning: > > drivers/iio/temperature//ltc2983.c:393:20-32: WARNING: Comparison to > > bool > > drivers/iio/temperature//ltc2983.c:394:20-32: WARNING: Comparison to > > bool > > > > Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com> > > --- > > drivers/iio/temperature/ltc2983.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/iio/temperature/ltc2983.c > > b/drivers/iio/temperature/ltc2983.c > > index d39c0d6b77f1..8976e8d59826 100644 > > --- a/drivers/iio/temperature/ltc2983.c > > +++ b/drivers/iio/temperature/ltc2983.c > > @@ -390,8 +390,8 @@ static struct ltc2983_custom_sensor > > *__ltc2983_custom_sensor_new( > > * For custom steinhart, the full u32 is taken. For all the others > > * the MSB is discarded. > > */ > > - const u8 n_size = (is_steinhart == true) ? 4 : 3; > > - const u8 e_size = (is_steinhart == true) ? sizeof(u32) : sizeof(u64); > > + const u8 n_size = is_steinhart ? 4 : 3; > > + const u8 e_size = is_steinhart ? sizeof(u32) : sizeof(u64); > > > > n_entries = of_property_count_elems_of_size(np, propname, e_size); > > /* n_entries must be an even number */ > > -- > > Acked-by: Nuno Sá <nuno.sa@analog.com> > Applied to the togreg branch of iio.git and pushed out as testing for the autobuilders to play with it. Thanks, Jonathan > Thanks, > Nuno Sá >
diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c index d39c0d6b77f1..8976e8d59826 100644 --- a/drivers/iio/temperature/ltc2983.c +++ b/drivers/iio/temperature/ltc2983.c @@ -390,8 +390,8 @@ static struct ltc2983_custom_sensor *__ltc2983_custom_sensor_new( * For custom steinhart, the full u32 is taken. For all the others * the MSB is discarded. */ - const u8 n_size = (is_steinhart == true) ? 4 : 3; - const u8 e_size = (is_steinhart == true) ? sizeof(u32) : sizeof(u64); + const u8 n_size = is_steinhart ? 4 : 3; + const u8 e_size = is_steinhart ? sizeof(u32) : sizeof(u64); n_entries = of_property_count_elems_of_size(np, propname, e_size); /* n_entries must be an even number */
Remove redundant comparison to a boolean variable. Fixes coccinelle warning: drivers/iio/temperature//ltc2983.c:393:20-32: WARNING: Comparison to bool drivers/iio/temperature//ltc2983.c:394:20-32: WARNING: Comparison to bool Signed-off-by: Rohit Sarkar <rohitsarkar5398@gmail.com> --- drivers/iio/temperature/ltc2983.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)