From patchwork Fri Apr 20 19:30:19 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: David Veenstra X-Patchwork-Id: 10353583 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 28461602B1 for ; Fri, 20 Apr 2018 19:30:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 144752887B for ; Fri, 20 Apr 2018 19:30:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0848B28860; Fri, 20 Apr 2018 19:30:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.8 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, MAILING_LIST_MULTI, RCVD_IN_DNSWL_HI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 88CCB28877 for ; Fri, 20 Apr 2018 19:30:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752392AbeDTTa0 (ORCPT ); Fri, 20 Apr 2018 15:30:26 -0400 Received: from mail-wr0-f194.google.com ([209.85.128.194]:46073 "EHLO mail-wr0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752362AbeDTTaX (ORCPT ); Fri, 20 Apr 2018 15:30:23 -0400 Received: by mail-wr0-f194.google.com with SMTP id u11-v6so25643157wri.12; Fri, 20 Apr 2018 12:30:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=LRHmU404aqqR1ZW8fehyCf+WU/96NQIS0HadUp2Icck=; b=e5l9PMDmkj5/3Uu1BrRa+pfFDm2Uh3HiyFLD5C9nNmtKGz/YOqF+Q/uiERP5vBqX2g euy0brKq029MShveGiiR6tE+BCTIG+UWxZOeVoLQqymKBJnlXYzMENxL++LGWQ1m3Ca6 dPwzFVxeuCfSs8KWe8V61gUmM09RvsqWwPZ5P1u4WDbQlqDoWiq1C38p45j5pFydTjxi DZAflQUvanwQXI/TVvXGU9S0XBBz+vVluiPI+172LIFC7DgP0U8pezT0AovVZXL52Ss2 7qvPbhcvSaK7OUWbCYs+/DMryRmwHvCwPSlSiagmlgUcrxK44ul0tZ9XYUztLf3AyWP5 O5zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=LRHmU404aqqR1ZW8fehyCf+WU/96NQIS0HadUp2Icck=; b=g/h8qAd/sOJET8md8IpaRAkHrK1bhXtH0eV784/6cwDi0GrFBa/XJFdfXeKEDF+vQ0 n44e63I29Gfyq/fwwT9WmpXeyCccNFI5X0Th0NeFuy4Mxqon9TV2UBfES84zKfqPaM9+ i8sZMElaCxABr7DDsIHXVJxfkJloB+2rmPzHMxWP/flj+98V15LkvdywHyYSQZsb4FCT RSkxgHS1XEvMXWiVctd4Vhy1v2R28AEBXSWfSJxeDJH4Tzn6wmxD80zcso9SA6RgVTCL FY6zM3GphqUa47cmr+sMr530azgfU3Zv93Yrcj0IObMXPvtozpo3zCSjJtOGco6MraCp DSRw== X-Gm-Message-State: ALQs6tAvd1/b4mpzTeXLwXAd9IbS2FOZwu/9p+7m71cjo2fJHIU9RBcZ zbTZ5ssaQKmLSgqXyA7gWX5WJZto X-Google-Smtp-Source: AIpwx49VFkj1mfs6bMbPeNFjUjAmJdorEtXmM3TFcpjUT4eQwkqnayV3qjsW8nmhIfzMXQ3JlAW7LA== X-Received: by 10.80.181.130 with SMTP id a2mr15319378ede.113.1524252622407; Fri, 20 Apr 2018 12:30:22 -0700 (PDT) Received: from zenbook-arch (s559434a1.adsl.online.nl. [85.148.52.161]) by smtp.gmail.com with ESMTPSA id u59sm3724170edc.30.2018.04.20.12.30.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 20 Apr 2018 12:30:21 -0700 (PDT) Date: Fri, 20 Apr 2018 21:30:19 +0200 From: David Veenstra To: lars@metafoo.de, jic23@kernel.org, pmeerw@pmeerw.net Cc: robh+dt@kernel.org, Michael.Hennerich@analog.com, knaack.h@gmx.de, daniel.baluta@nxp.com, linux-iio@vger.kernel.org, devel@driverdev.osuosl.org, devicetree@vger.kernel.org Subject: [PATCH v2 06/13] staging: iio: ad2s1200: Introduce variable for repeated value Message-ID: <6ec9752ef32af09d0f0f419030be09d1dec68c6d.1524247563.git.davidjulianveenstra@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Sender: linux-iio-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Add variable to hold &spi->dev in ad2s1200_probe. This value is repeatedly used in ad2s1200_probe. Signed-off-by: David Veenstra --- drivers/staging/iio/resolver/ad2s1200.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/staging/iio/resolver/ad2s1200.c b/drivers/staging/iio/resolver/ad2s1200.c index f07aab7e7a35..0a5fc9917e32 100644 --- a/drivers/staging/iio/resolver/ad2s1200.c +++ b/drivers/staging/iio/resolver/ad2s1200.c @@ -117,19 +117,22 @@ static int ad2s1200_probe(struct spi_device *spi) unsigned short *pins = spi->dev.platform_data; struct ad2s1200_state *st; struct iio_dev *indio_dev; + struct device *dev; int pn, ret = 0; + dev = &spi->dev; + for (pn = 0; pn < AD2S1200_PN; pn++) { - ret = devm_gpio_request_one(&spi->dev, pins[pn], GPIOF_DIR_OUT, + ret = devm_gpio_request_one(dev, pins[pn], GPIOF_DIR_OUT, DRV_NAME); if (ret) { - dev_err(&spi->dev, "request gpio pin %d failed\n", + dev_err(dev, "request gpio pin %d failed\n", pins[pn]); return ret; } } - indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st)); + indio_dev = devm_iio_device_alloc(dev, sizeof(*st)); if (!indio_dev) return -ENOMEM; @@ -140,14 +143,14 @@ static int ad2s1200_probe(struct spi_device *spi) st->sample = pins[0]; st->rdvel = pins[1]; - indio_dev->dev.parent = &spi->dev; + indio_dev->dev.parent = dev; indio_dev->info = &ad2s1200_info; indio_dev->modes = INDIO_DIRECT_MODE; indio_dev->channels = ad2s1200_channels; indio_dev->num_channels = ARRAY_SIZE(ad2s1200_channels); indio_dev->name = spi_get_device_id(spi)->name; - ret = devm_iio_device_register(&spi->dev, indio_dev); + ret = devm_iio_device_register(dev, indio_dev); if (ret) return ret;