diff mbox

[v2,6/7] iio: adc: ina2xx: Align timestamp with conversion ready flag

Message ID 78c52a18-e747-4661-963c-d06e05631eda@rwthex-w2-a.rwth-ad.de (mailing list archive)
State New, archived
Headers show

Commit Message

Stefan Brüns Dec. 21, 2017, 6:31 p.m. UTC
As the timestamp is no longer (ab-)used to measure the function run time,
it can be taken at the correct time, i.e. when the conversion has finished.

Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
---

Changes in v2: None

 drivers/iio/adc/ina2xx-adc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Jonathan Cameron Dec. 29, 2017, 5:49 p.m. UTC | #1
On Thu, 21 Dec 2017 19:31:37 +0100
Stefan Brüns <stefan.bruens@rwth-aachen.de> wrote:

> As the timestamp is no longer (ab-)used to measure the function run time,
> it can be taken at the correct time, i.e. when the conversion has finished.
> 
> Signed-off-by: Stefan Brüns <stefan.bruens@rwth-aachen.de>
Applied.

Thanks,

Jonathan

> ---
> 
> Changes in v2: None
> 
>  drivers/iio/adc/ina2xx-adc.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
> index 415e53b5c0a6..b7407ac91b59 100644
> --- a/drivers/iio/adc/ina2xx-adc.c
> +++ b/drivers/iio/adc/ina2xx-adc.c
> @@ -706,8 +706,6 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>  	s64 time;
>  	unsigned int alert;
>  
> -	time = iio_get_time_ns(indio_dev);
> -
>  	/*
>  	 * Because the timer thread and the chip conversion clock
>  	 * are asynchronous, the period difference will eventually
> @@ -736,6 +734,8 @@ static int ina2xx_work_buffer(struct iio_dev *indio_dev)
>  
>  		} while (!alert);
>  
> +	time = iio_get_time_ns(indio_dev);
> +
>  	/*
>  	 * Single register reads: bulk_read will not work with ina226/219
>  	 * as there is no auto-increment of the register pointer.

--
To unsubscribe from this list: send the line "unsubscribe linux-iio" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
diff mbox

Patch

diff --git a/drivers/iio/adc/ina2xx-adc.c b/drivers/iio/adc/ina2xx-adc.c
index 415e53b5c0a6..b7407ac91b59 100644
--- a/drivers/iio/adc/ina2xx-adc.c
+++ b/drivers/iio/adc/ina2xx-adc.c
@@ -706,8 +706,6 @@  static int ina2xx_work_buffer(struct iio_dev *indio_dev)
 	s64 time;
 	unsigned int alert;
 
-	time = iio_get_time_ns(indio_dev);
-
 	/*
 	 * Because the timer thread and the chip conversion clock
 	 * are asynchronous, the period difference will eventually
@@ -736,6 +734,8 @@  static int ina2xx_work_buffer(struct iio_dev *indio_dev)
 
 		} while (!alert);
 
+	time = iio_get_time_ns(indio_dev);
+
 	/*
 	 * Single register reads: bulk_read will not work with ina226/219
 	 * as there is no auto-increment of the register pointer.