From patchwork Fri May 19 11:01:47 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 13248201 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6E78AC77B7A for ; Fri, 19 May 2023 11:02:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231915AbjESLCj (ORCPT ); Fri, 19 May 2023 07:02:39 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44416 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231869AbjESLC1 (ORCPT ); Fri, 19 May 2023 07:02:27 -0400 Received: from mail-lj1-x22d.google.com (mail-lj1-x22d.google.com [IPv6:2a00:1450:4864:20::22d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 929231BD3; Fri, 19 May 2023 04:01:54 -0700 (PDT) Received: by mail-lj1-x22d.google.com with SMTP id 38308e7fff4ca-2ac8d9399d5so35396641fa.1; Fri, 19 May 2023 04:01:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1684494112; x=1687086112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=gkYB7W6EIjjzbGiSlqrEyzRmwdHttot0sA2nFcKs42o=; b=QkXBm0Yk/lsHk/RhV+I75xdBWJGHX+o1sOXTZd1AE9T2+qFXzhgjPZuQ7kli5NiBW5 nTJExjZjzmJmqGJkckwbcM8IU3WXvjSPnCzecWe3JB1XkVfq1pep2IU9SXa8SzifXNbY oGq3UTLs/4lfkGk9Fwv5k71YZUZ+VmuHYiID1Mrd3mFW5Ipxs3Sb1LgDJazQL3eZWfzz XOZmPUYpITfLiamdhxXDdYy2RfIrP2gyI5WbftXnJD1wxG0M69saZfq8lhu6q6K26x69 TXxXtmT4ilVB7/Dxb82w8EszbWQ4WMMlGmE5lArO3Ydrv26RbariaJTkKyeCkYwMxI1p Cikg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1684494112; x=1687086112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gkYB7W6EIjjzbGiSlqrEyzRmwdHttot0sA2nFcKs42o=; b=YZ3M9zcx5mkian6KYcGUZsOxUNRs58zlna+mxHG55XrXU6AYpI5Acp7BvrfcfdaHCG fV0s+OUiuzTPEou8rIKIzvS3vZqu7BU7S/1FKHx3mQ0j8zkDs4vM9YqCPmpjoniYfBIz tEzF1+yHcXR2y3zdRCOZEnmmuVyYtrukGO2NHAxpobhCnxt0mL2D9Yu4zqBnc8Pf5l+6 LgHbMYylavUSotcyAJc4eZOqL9SbG+YYw3HyB2xSsDYZy7PnAAKH4pLEGjGwjyUz5DZb 5TBejGg3pqWVayANucdhMlzYtRX+Rwji4saaoF2Vup5wFcl1PqFOlHQzVaZbMRkwEffG nMZQ== X-Gm-Message-State: AC+VfDwnL9YUN8E6gOzHV3VG0nRlAkVYALFfogvMomImXVDzgDVA10yZ 3IsUnjWgbYylXDYyjnz7cJA= X-Google-Smtp-Source: ACHHUZ5/q+zvMZ+zbg+FKIFk8D5PZvwdxgUr+VEmpWVeklatgBfB34pR/1qPtDrg7FlFnAHRjW/Flg== X-Received: by 2002:ac2:4a84:0:b0:4f3:8507:d90d with SMTP id l4-20020ac24a84000000b004f38507d90dmr563473lfp.34.1684494112221; Fri, 19 May 2023 04:01:52 -0700 (PDT) Received: from fedora (62-78-225-252.bb.dnainternet.fi. [62.78.225.252]) by smtp.gmail.com with ESMTPSA id s11-20020ac25feb000000b004f122a378d4sm560346lfg.163.2023.05.19.04.01.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 19 May 2023 04:01:51 -0700 (PDT) Date: Fri, 19 May 2023 14:01:47 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v5 3/8] net-next: mvpp2: relax return value check for IRQ get Message-ID: <7c7b1a123d6d5c15c8b37754f1f0c4bd1cad5a01.1684493615.git.mazziesaccount@gmail.com> References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen --- Revision history: v4 = v5: Fix the subject, mb1232 => mvpp2 The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index adc953611913..5b987af306a5 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -5833,7 +5833,7 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port, v->irq = of_irq_get_byname(port_node, irqname); else v->irq = fwnode_irq_get(port->fwnode, i); - if (v->irq <= 0) { + if (v->irq < 0) { ret = -EINVAL; goto err; } @@ -6764,7 +6764,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, err = -EPROBE_DEFER; goto err_deinit_qvecs; } - if (port->port_irq <= 0) + if (port->port_irq < 0) /* the link irq is optional */ port->port_irq = 0;