| Message ID | 8327ac591d244ac85aa83c01e559076159c7ba12.1711283728.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | iio: pressure: hsc030pa: Use spi_read() | expand |
On Sun, 24 Mar 2024 13:36:16 +0100 Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote: > Use spi_read() instead of hand-writing it. > It is less verbose. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Applied to the togreg-normal branch of iio.git. Thanks, Jonathan > --- > Compile test only > --- > drivers/iio/pressure/hsc030pa_spi.c | 7 +------ > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git a/drivers/iio/pressure/hsc030pa_spi.c b/drivers/iio/pressure/hsc030pa_spi.c > index 818fa6303454..337eecc577d2 100644 > --- a/drivers/iio/pressure/hsc030pa_spi.c > +++ b/drivers/iio/pressure/hsc030pa_spi.c > @@ -23,14 +23,9 @@ > static int hsc_spi_recv(struct hsc_data *data) > { > struct spi_device *spi = to_spi_device(data->dev); > - struct spi_transfer xfer = { > - .tx_buf = NULL, > - .rx_buf = data->buffer, > - .len = HSC_REG_MEASUREMENT_RD_SIZE, > - }; > > msleep_interruptible(HSC_RESP_TIME_MS); > - return spi_sync_transfer(spi, &xfer, 1); > + return spi_read(spi, data->buffer, HSC_REG_MEASUREMENT_RD_SIZE); > } > > static int hsc_spi_probe(struct spi_device *spi)
diff --git a/drivers/iio/pressure/hsc030pa_spi.c b/drivers/iio/pressure/hsc030pa_spi.c index 818fa6303454..337eecc577d2 100644 --- a/drivers/iio/pressure/hsc030pa_spi.c +++ b/drivers/iio/pressure/hsc030pa_spi.c @@ -23,14 +23,9 @@ static int hsc_spi_recv(struct hsc_data *data) { struct spi_device *spi = to_spi_device(data->dev); - struct spi_transfer xfer = { - .tx_buf = NULL, - .rx_buf = data->buffer, - .len = HSC_REG_MEASUREMENT_RD_SIZE, - }; msleep_interruptible(HSC_RESP_TIME_MS); - return spi_sync_transfer(spi, &xfer, 1); + return spi_read(spi, data->buffer, HSC_REG_MEASUREMENT_RD_SIZE); } static int hsc_spi_probe(struct spi_device *spi)
Use spi_read() instead of hand-writing it. It is less verbose. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- Compile test only --- drivers/iio/pressure/hsc030pa_spi.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-)