| Message ID | CAHd-oW7Xpr-+1SuxsjduFhrRqh7TcGTqmJ22A7W7Oqk8o2E1Kg@mail.gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | staging: iio: ad2s1210: fix 'assignment operator' style checks | expand |
On Fri, 5 Oct 2018 22:24:26 -0300 Matheus Tavares Bernardino <matheus.bernardino@usp.br> wrote: > This patch fixes all "Assignment operator '=' should be on the previous > line" checks found in ad2s1210.c by checkpatch.pl. > > Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br> Hi Matheus, Good change, but unfortunately your email client as converted tabs into spaces so it cannot be applied. Try git am with this email and you'll see what I mean. See Documentation/process/email-clients.rst for some hints on this. Looking forward to V2 with that fixed! Thanks, Jonathan > --- > drivers/staging/iio/resolver/ad2s1210.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/staging/iio/resolver/ad2s1210.c > b/drivers/staging/iio/resolver/ad2s1210.c > index ac13b99bd9cb..d4b1c2c010f2 100644 > --- a/drivers/staging/iio/resolver/ad2s1210.c > +++ b/drivers/staging/iio/resolver/ad2s1210.c > @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev, > "ad2s1210: write control register fail\n"); > goto error_ret; > } > - st->resolution > - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; > + st->resolution = > + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; > if (st->pdata->gpioin) { > data = ad2s1210_read_resolution_pin(st); > if (data != st->resolution) > @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev, > dev_err(dev, "ad2s1210: setting resolution fail\n"); > goto error_ret; > } > - st->resolution > - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; > + st->resolution = > + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; > if (st->pdata->gpioin) { > data = ad2s1210_read_resolution_pin(st); > if (data != st->resolution)
On Fri, Oct 05, 2018 at 10:24:26PM -0300, Matheus Tavares Bernardino wrote: > This patch fixes all "Assignment operator '=' should be on the previous > line" checks found in ad2s1210.c by checkpatch.pl. > > Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br> > --- As already pointed out tabs -> whitespace issue. I assume you attached or copied the patch into your email client and sent it. Usually, these clients wrap the message which leads to patch corruption and hence it would apply to the maintainer's git tree cleanly. Therefore, I would suggest using `git send-email`. Also, as a safety measure you may use the `--dry-run` flag of `git send-email` to see how it would look like when you send the patch. Thanks
diff --git a/drivers/staging/iio/resolver/ad2s1210.c b/drivers/staging/iio/resolver/ad2s1210.c index ac13b99bd9cb..d4b1c2c010f2 100644 --- a/drivers/staging/iio/resolver/ad2s1210.c +++ b/drivers/staging/iio/resolver/ad2s1210.c @@ -301,8 +301,8 @@ static ssize_t ad2s1210_store_control(struct device *dev, "ad2s1210: write control register fail\n"); goto error_ret; } - st->resolution - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; + st->resolution = + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; if (st->pdata->gpioin) { data = ad2s1210_read_resolution_pin(st); if (data != st->resolution) @@ -363,8 +363,8 @@ static ssize_t ad2s1210_store_resolution(struct device *dev, dev_err(dev, "ad2s1210: setting resolution fail\n"); goto error_ret; } - st->resolution - = ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; + st->resolution = + ad2s1210_resolution_value[data & AD2S1210_SET_RESOLUTION]; if (st->pdata->gpioin) { data = ad2s1210_read_resolution_pin(st); if (data != st->resolution)
This patch fixes all "Assignment operator '=' should be on the previous line" checks found in ad2s1210.c by checkpatch.pl. Signed-off-by: Matheus Tavares <matheus.bernardino@usp.br> --- drivers/staging/iio/resolver/ad2s1210.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-)