From patchwork Fri May 26 06:36:57 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Matti Vaittinen X-Patchwork-Id: 13256459 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id D95A5C77B7A for ; Fri, 26 May 2023 06:37:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S242220AbjEZGhS (ORCPT ); Fri, 26 May 2023 02:37:18 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37530 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242212AbjEZGhP (ORCPT ); Fri, 26 May 2023 02:37:15 -0400 Received: from mail-lj1-x235.google.com (mail-lj1-x235.google.com [IPv6:2a00:1450:4864:20::235]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A606D125; Thu, 25 May 2023 23:37:14 -0700 (PDT) Received: by mail-lj1-x235.google.com with SMTP id 38308e7fff4ca-2af177f12d1so3929931fa.0; Thu, 25 May 2023 23:37:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1685083033; x=1687675033; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=nTHyx8ul0jeYvSGVcy/ig3hWeMVLe8/m2Xy5fo29+U4=; b=q3SYsF3JaBt51X/Hhcb3nNtQDRFZCI3Ml+CK3KMqC6/scLDfG0QtiFCnjmmep9zzqw cNk+nEmE8FQwm3mMAwOr2/Yxjh5A/HPK5dWDA8tSTlNON/MlMNDjLkJDFimJnmSXwuiK UOj/QzuNQ10zVJ/wNuZkuu679wLeO7OW87jRLMRS4UBKcTzd7iZm207k8ybqy+VsXiVw Jzrv3P+jOcmAWUGeqmr6c7Va3G7A70Jj7b3wH/3cxknmcYf3LJ73uNUo3V/SNLr3W0kM KJZ+2wG7iYyC2+H++h97wgt+Gtkz3ZeWgmpsKPRT1yOg/x6mV+n+g7ttjYVUsOInfzPf uiKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685083033; x=1687675033; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nTHyx8ul0jeYvSGVcy/ig3hWeMVLe8/m2Xy5fo29+U4=; b=O7Bl6WldQCMaQ9g9kYh2b8Mlj/y/oHm5Dx1vf728dVehPskCi6256q0kuX5kYEWMrJ vPL7ewS66RO5Lv2JUFHtfrA01ZXHwCFgTG3RR/NJp6Eu/0XbyxMEU1FCdRU+Bvn0GewA vo8ucatAvlQUo/my7QFKMhycTVHrbj1I2oBxz/I4t5NHO7qLZ7ycHXU67FsFQAlRKhKa aRe+lUw4L5i0Ky0Vz0G7EK+HyvW3EGzq2GxfG0t2lyO+A96h9fzlr5EBg4Z0OuJBXUog 6EqBLorpeA4GNxMa6/vtx9o0vjCUKHssvq8rf5GcV42hUHIoHGNjwc83++ldbbMjAr+F 8j5w== X-Gm-Message-State: AC+VfDzVqidvVTMbaFhW6XJrWDSAlTRigqO2GuG3eDneUqzRJwZatgxC 3914mh0nxksG24cX+/0AGCc= X-Google-Smtp-Source: ACHHUZ4X9pgC0XVmR+d+Ksrb8LTh0cKOkPQu76crhybPdfb5o9R68exID8yXSG4urcQPdyWB19IhCw== X-Received: by 2002:a2e:87d6:0:b0:2af:22a0:81f6 with SMTP id v22-20020a2e87d6000000b002af22a081f6mr247122ljj.34.1685083032639; Thu, 25 May 2023 23:37:12 -0700 (PDT) Received: from fedora ([213.255.186.46]) by smtp.gmail.com with ESMTPSA id s9-20020a19ad49000000b004edc55d3900sm499848lfd.0.2023.05.25.23.37.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 23:37:11 -0700 (PDT) Date: Fri, 26 May 2023 09:36:57 +0300 From: Matti Vaittinen To: Matti Vaittinen , Matti Vaittinen Cc: Andy Shevchenko , Daniel Scally , Heikki Krogerus , Sakari Ailus , Greg Kroah-Hartman , "Rafael J. Wysocki" , Wolfram Sang , Lars-Peter Clausen , Michael Hennerich , Jonathan Cameron , Andreas Klinger , Marcin Wojtas , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan =?iso-8859-1?q?Neusch=E4fer?= , Linus Walleij , Paul Cercueil , Akhil R , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org, linux-iio@vger.kernel.org, netdev@vger.kernel.org, openbmc@lists.ozlabs.org, linux-gpio@vger.kernel.org, linux-mips@vger.kernel.org Subject: [PATCH v6 3/8] net-next: mvpp2: relax return value check for IRQ get Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: Precedence: bulk List-ID: X-Mailing-List: linux-iio@vger.kernel.org fwnode_irq_get[_byname]() were changed to not return 0 anymore. Drop check for return value 0. Signed-off-by: Matti Vaittinen --- Revision history: v5 =>: - No changes v4 = v5: Fix the subject, mb1232 => mvpp2 The first patch of the series changes the fwnode_irq_get() so this depends on the first patch of the series and should not be applied alone. --- drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c index adc953611913..5b987af306a5 100644 --- a/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c +++ b/drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c @@ -5833,7 +5833,7 @@ static int mvpp2_multi_queue_vectors_init(struct mvpp2_port *port, v->irq = of_irq_get_byname(port_node, irqname); else v->irq = fwnode_irq_get(port->fwnode, i); - if (v->irq <= 0) { + if (v->irq < 0) { ret = -EINVAL; goto err; } @@ -6764,7 +6764,7 @@ static int mvpp2_port_probe(struct platform_device *pdev, err = -EPROBE_DEFER; goto err_deinit_qvecs; } - if (port->port_irq <= 0) + if (port->port_irq < 0) /* the link irq is optional */ port->port_irq = 0;